mirror of https://github.com/samvallad33/vestige.git synced 2026-05-03 21:02:37 +02:00

Sam Valladares 52f1e97e14 fix: restore Intel Mac build via ort-dynamic + system libonnxruntime

Microsoft is discontinuing x86_64 macOS ONNX Runtime prebuilts after
v1.23.0, so ort-sys 2.0.0-rc.11 can't ship an Intel Mac binary and never
will. Previous Intel Mac attempts kept dying in the ort-sys build script
with "does not provide prebuilt binaries for the target x86_64-apple-darwin
with feature set (no features)." Issue #41 was the latest casualty.

Fix: route Intel Mac through the ort-dynamic feature path (runtime dlopen
against a system libonnxruntime installed via Homebrew). This sidesteps
ort-sys prebuilts entirely and works today.

Changes:

- crates/vestige-core/Cargo.toml: split `embeddings` into code-only vs
  backend-choice. The embeddings feature now just pulls fastembed + hf-hub
  + image-models and activates the 27 #[cfg(feature = "embeddings")] gates
  throughout the crate. New `ort-download` feature carries the
  download-binaries-native-tls backend (the historical default). Existing
  `ort-dynamic` feature now transitively enables `embeddings`, so the
  cfg gates stay active when users swap backends.

  Default feature set expands `["embeddings", ...]` -> `["embeddings",
  "ort-download", ...]` so existing consumers see identical behavior.

- crates/vestige-mcp/Cargo.toml: mirrors the split. Adds `ort-download`
  feature that chains to vestige-core/ort-download, keeps `ort-dynamic`
  that chains to vestige-core/ort-dynamic. Both transitively pull
  `embeddings`. Default adds `ort-download` so `cargo install vestige-mcp`
  still picks the prebuilt-ort backend like before.

- .github/workflows/ci.yml: re-adds x86_64-apple-darwin to the
  release-build matrix with `--no-default-features --features
  ort-dynamic,vector-search`. Adds a `brew install onnxruntime` step that
  sets ORT_DYLIB_PATH from `brew --prefix onnxruntime`.

- .github/workflows/release.yml: re-adds x86_64-apple-darwin to the
  release matrix with the same flags + brew install step. The Intel Mac
  tarball now also bundles docs/INSTALL-INTEL-MAC.md so binary consumers
  get the `brew install onnxruntime` + ORT_DYLIB_PATH prereq out of the
  box.

- docs/INSTALL-INTEL-MAC.md: new install guide covering the Homebrew
  prereq, binary install, source build, troubleshooting, and the v2.1
  ort-candle migration plan.

- README.md: replaces the "Intel Mac and Windows build from source only"
  paragraph with the prebuilt Intel Mac install (brew + curl + env var)
  and a link to the full guide. Platform table updated: Intel Mac back
  on the "prebuilt" list.

Verified locally on aarch64-apple-darwin:
- `cargo check --release -p vestige-mcp` -> clean (default features)
- `cargo check --release -p vestige-mcp --no-default-features
   --features ort-dynamic,vector-search` -> clean

Runtime path on Intel Mac (verified on CI):
  brew install onnxruntime
  export ORT_DYLIB_PATH=$(brew --prefix onnxruntime)/lib/libonnxruntime.dylib
  vestige-mcp --version

Fixes #41. Long-term plan (v2.1): migrate to ort-candle pure-Rust backend
so no system ONNX Runtime dep is needed on any platform.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-22 23:02:40 -05:00

2.6 KiB

Raw Blame History

Intel Mac Installation

The Intel Mac (x86_64-apple-darwin) binary links dynamically against a system ONNX Runtime instead of a prebuilt ort-sys library. Microsoft is discontinuing x86_64 macOS prebuilts after ONNX Runtime v1.23.0, so we use the ort-dynamic feature to runtime-link against the version you install locally. This keeps Vestige working on Intel Mac without waiting for a dead upstream.

Prerequisite

Install ONNX Runtime via Homebrew:

brew install onnxruntime

Install

# 1. Download the binary
curl -L https://github.com/samvallad33/vestige/releases/latest/download/vestige-mcp-x86_64-apple-darwin.tar.gz | tar -xz
sudo mv vestige-mcp vestige vestige-restore /usr/local/bin/

# 2. Point the binary at Homebrew's libonnxruntime
echo 'export ORT_DYLIB_PATH="'"$(brew --prefix onnxruntime)"'/lib/libonnxruntime.dylib"' >> ~/.zshrc
source ~/.zshrc

# 3. Verify
vestige-mcp --version

# 4. Connect to Claude Code
claude mcp add vestige vestige-mcp -s user

ORT_DYLIB_PATH is how the ort crate's load-dynamic feature finds the shared library at runtime. Without it the binary starts but fails on the first embedding call with a "could not find libonnxruntime" error.

Building from source

brew install onnxruntime
git clone https://github.com/samvallad33/vestige && cd vestige
cargo build --release -p vestige-mcp \
  --no-default-features \
  --features ort-dynamic,vector-search
export ORT_DYLIB_PATH="$(brew --prefix onnxruntime)/lib/libonnxruntime.dylib"
./target/release/vestige-mcp --version

Troubleshooting

dyld: Library not loaded: libonnxruntime.dylib — ORT_DYLIB_PATH is not set for the shell that spawned vestige-mcp. Claude Code / Codex inherits the env vars from whatever launched it; export ORT_DYLIB_PATH in ~/.zshrc or ~/.bashrc and restart the client.

error: ort-sys does not provide prebuilt binaries for the target x86_64-apple-darwin — you hit this only if you ran cargo build without the --no-default-features --features ort-dynamic,vector-search flags. The default feature set still tries to download a non-existent prebuilt. Add the flags and rebuild.

Homebrew installed onnxruntime but brew --prefix onnxruntime prints nothing — upgrade brew (brew update) and retry. Older brew formulae used onnx-runtime (hyphenated). If your brew still has the hyphenated formula, substitute accordingly in the commands above.

Long-term

Intel Mac will move to a fully pure-Rust backend (ort-candle) in Vestige v2.1, removing the Homebrew prerequisite entirely. Track progress at issue #41.

2.6 KiB Raw Blame History