trustgraph/tests/unit/test_extract/test_ontology/README.md

Ontology Extractor Unit Tests

Comprehensive unit tests for the OntoRAG ontology extraction system.

Test Coverage

1. test_ontology_selector.py - Auto-Include Properties Feature

Tests the critical dependency resolution that automatically includes all properties related to selected classes.

Key Tests:

• test_auto_include_properties_for_recipe_class - Verifies Recipe class auto-includes ingredients, method, produces, serves
• test_auto_include_properties_for_ingredient_class - Verifies Ingredient class auto-includes food property
• test_auto_include_properties_for_range_class - Tests properties are included when class appears in range
• test_auto_include_adds_domain_and_range_classes - Ensures related classes are added too
• test_multiple_classes_get_all_related_properties - Tests combining multiple class selections
• test_no_duplicate_properties_added - Ensures properties aren't duplicated

2. test_uri_expansion.py - URI Expansion

Tests that URIs are properly expanded using ontology definitions instead of constructed fallback URIs.

Key Tests:

• test_expand_class_uri_from_ontology - Class names expand to ontology URIs
• test_expand_object_property_uri_from_ontology - Object properties use ontology URIs
• test_expand_datatype_property_uri_from_ontology - Datatype properties use ontology URIs
• test_expand_rdf_prefix - Standard RDF prefixes expand correctly
• test_expand_rdfs_prefix, test_expand_owl_prefix, test_expand_xsd_prefix - Other standard prefixes
• test_fallback_uri_for_instance - Entity instances get constructed URIs
• test_already_full_uri_unchanged - Full URIs pass through
• test_dict_access_not_object_attribute - Critical test verifying dict access works (not object attributes)

3. test_ontology_triples.py - Ontology Triple Generation

Tests that ontology elements (classes and properties) are properly converted to RDF triples with labels, comments, domains, and ranges.

Key Tests:

• test_generates_class_type_triples - Classes get rdf:type owl:Class triples
• test_generates_class_labels - Classes get rdfs:label triples
• test_generates_class_comments - Classes get rdfs:comment triples
• test_generates_object_property_type_triples - Object properties get proper type triples
• test_generates_object_property_labels - Object properties get labels
• test_generates_object_property_domain - Object properties get rdfs:domain triples
• test_generates_object_property_range - Object properties get rdfs:range triples
• test_generates_datatype_property_type_triples - Datatype properties get proper type triples
• test_generates_datatype_property_range - Datatype properties get XSD type ranges
• test_uses_dict_field_names_not_rdf_names - Critical test verifying dict field names work
• test_total_triple_count_is_reasonable - Validates expected number of triples

4. test_text_processing.py - Text Processing and Segmentation

Tests that text is properly split into sentences for ontology matching, including NLTK tokenization and TextSegment creation.

Key Tests:

• test_segment_single_sentence - Single sentence produces one segment
• test_segment_multiple_sentences - Multiple sentences split correctly
• test_segment_positions - Segment start/end positions are correct
• test_segment_complex_punctuation - Handles abbreviations (Dr., U.S.A., Mr.)
• test_segment_question_and_exclamation - Different sentence terminators
• test_segment_preserves_original_text - Segments can reconstruct original
• test_text_segment_non_overlapping - Segments don't overlap
• test_nltk_punkt_availability - NLTK tokenizer is available
• test_unicode_text - Handles unicode characters
• test_quoted_text - Handles quoted text correctly

5. test_prompt_and_extraction.py - LLM Prompt Construction and Triple Extraction

Tests that the system correctly constructs prompts with ontology constraints and extracts/validates triples from LLM responses.

Key Tests:

• test_build_extraction_variables_includes_text - Prompt includes input text
• test_build_extraction_variables_includes_classes - Prompt includes ontology classes
• test_build_extraction_variables_includes_properties - Prompt includes properties
• test_validates_rdf_type_triple_with_valid_class - Validates rdf:type against ontology
• test_rejects_rdf_type_triple_with_invalid_class - Rejects invalid classes
• test_validates_object_property_triple - Validates object properties
• test_rejects_unknown_property - Rejects properties not in ontology
• test_parse_simple_triple_dict - Parses triple from dict format
• test_filters_invalid_triples - Filters out invalid triples
• test_expands_uris_in_parsed_triples - Expands URIs using ontology
• test_creates_proper_triple_objects - Creates Triple objects with Value subjects/predicates/objects

6. test_embedding_and_similarity.py - Ontology Embedding and Similarity Matching

Tests that ontology elements are properly embedded and matched against input text using vector similarity.

Key Tests:

• test_create_text_from_class_with_id - Text representation includes class ID
• test_create_text_from_class_with_labels - Includes labels in text
• test_create_text_from_class_with_comment - Includes comments in text
• test_create_text_from_property_with_domain_range - Includes domain/range in property text
• test_normalizes_id_with_underscores - Normalizes IDs (underscores to spaces)
• test_includes_subclass_info_for_classes - Includes subclass relationships
• test_vector_store_api_structure - Vector store has expected API
• test_selector_handles_text_segments - Selector processes text segments
• test_merge_subsets_combines_elements - Merging combines ontology elements
• test_ontology_element_metadata_structure - Metadata structure is correct

Running the Tests

Run all ontology extractor tests:

cd /home/mark/work/trustgraph.ai/trustgraph
pytest tests/unit/test_extract/test_ontology/ -v

Run specific test file:

pytest tests/unit/test_extract/test_ontology/test_ontology_selector.py -v
pytest tests/unit/test_extract/test_ontology/test_uri_expansion.py -v
pytest tests/unit/test_extract/test_ontology/test_ontology_triples.py -v
pytest tests/unit/test_extract/test_ontology/test_text_processing.py -v
pytest tests/unit/test_extract/test_ontology/test_prompt_and_extraction.py -v
pytest tests/unit/test_extract/test_ontology/test_embedding_and_similarity.py -v

Run specific test:

pytest tests/unit/test_extract/test_ontology/test_ontology_selector.py::TestOntologySelector::test_auto_include_properties_for_recipe_class -v

Run with coverage:

pytest tests/unit/test_extract/test_ontology/ --cov=trustgraph.extract.kg.ontology --cov-report=html

Test Fixtures

• sample_ontology - Complete Food Ontology with Recipe, Ingredient, Food, Method classes
• ontology_loader_with_sample - Mock OntologyLoader with the sample ontology
• ontology_embedder - Mock embedder for testing
• mock_embedding_service - Mock service for generating deterministic embeddings
• vector_store - InMemoryVectorStore for testing
• extractor - Processor instance for URI expansion tests
• ontology_subset_with_uris - OntologySubset with proper URIs defined
• sample_ontology_subset - OntologySubset for testing triple generation
• text_processor - TextProcessor instance for text segmentation tests
• sample_ontology_class - Sample OntologyClass for testing
• sample_ontology_property - Sample OntologyProperty for testing

Implementation Notes

These tests verify the fixes made to address:

1. Disconnected graph problem - Auto-include properties feature ensures all relevant relationships are available
2. Wrong URIs problem - URI expansion using ontology definitions instead of constructed fallbacks
3. Dict vs object attribute problem - URI expansion works with dicts (from cls.__dict__) not object attributes
4. Ontology visibility in KG - Ontology elements themselves appear in the knowledge graph with proper metadata
5. Text segmentation - Proper sentence splitting for ontology matching using NLTK