Cassandra tidy schema translation

trustgraph-base/trustgraph/messaging/translators/collection.py

@@ -78,7 +78,6 @@ class CollectionManagementResponseTranslator(MessageTranslator):
                 ))
 
         return CollectionManagementResponse(
-            success=data.get("success"),
             error=error,
             timestamp=data.get("timestamp"),
             collections=collections
@@ -87,8 +86,6 @@ class CollectionManagementResponseTranslator(MessageTranslator):
     def from_pulsar(self, obj: CollectionManagementResponse) -> Dict[str, Any]:
         result = {}
 
-        if obj.success is not None:
-            result["success"] = obj.success
         if obj.error is not None:
             result["error"] = {
                 "type": obj.error.type,

trustgraph-base/trustgraph/schema/services/collection.py

@@ -42,8 +42,7 @@ class CollectionManagementRequest(Record):
 
 class CollectionManagementResponse(Record):
     """Response for collection management operations"""
-    success = String()  # "true" or "false"
-    error = Error()  # Only populated if success is "false"
+    error = Error()  # Only populated if there's an error
     timestamp = String()  # ISO timestamp
     collections = Array(CollectionMetadata())
 

trustgraph-flow/trustgraph/librarian/collection_manager.py

@@ -116,7 +116,6 @@ class CollectionManager:
             ]
 
             return CollectionManagementResponse(
-                success="true",
                 collections=collection_metadata,
                 timestamp=datetime.now().isoformat()
             )
@@ -187,7 +186,6 @@ class CollectionManager:
                 )
 
             return CollectionManagementResponse(
-                success="true",
                 collections=[collection_metadata],
                 timestamp=datetime.now().isoformat()
             )
@@ -256,7 +254,6 @@ class CollectionManager:
                 del self.pending_deletions[deletion_key]
 
                 return CollectionManagementResponse(
-                    success="false",
                     error=Error(
                         type="storage_deletion_error",
                         message=error_msg
@@ -272,7 +269,6 @@ class CollectionManager:
             del self.pending_deletions[deletion_key]
 
             return CollectionManagementResponse(
-                success="true",
                 timestamp=datetime.now().isoformat()
             )
 

trustgraph-flow/trustgraph/librarian/service.py

@@ -441,7 +441,6 @@ class Processor(AsyncProcessor):
             )
         except RequestError as e:
             resp = CollectionManagementResponse(
-                success="false",
                 error=Error(
                     type="request-error",
                     message=str(e),
@@ -453,7 +452,6 @@ class Processor(AsyncProcessor):
             )
         except Exception as e:
             resp = CollectionManagementResponse(
-                success="false",
                 error=Error(
                     type="unexpected-error",
                     message=str(e),