diff --git a/trustgraph-base/trustgraph/messaging/translators/collection.py b/trustgraph-base/trustgraph/messaging/translators/collection.py index df1bdf0f..5ad31f26 100644 --- a/trustgraph-base/trustgraph/messaging/translators/collection.py +++ b/trustgraph-base/trustgraph/messaging/translators/collection.py @@ -78,7 +78,6 @@ class CollectionManagementResponseTranslator(MessageTranslator): )) return CollectionManagementResponse( - success=data.get("success"), error=error, timestamp=data.get("timestamp"), collections=collections @@ -87,8 +86,6 @@ class CollectionManagementResponseTranslator(MessageTranslator): def from_pulsar(self, obj: CollectionManagementResponse) -> Dict[str, Any]: result = {} - if obj.success is not None: - result["success"] = obj.success if obj.error is not None: result["error"] = { "type": obj.error.type, diff --git a/trustgraph-base/trustgraph/schema/services/collection.py b/trustgraph-base/trustgraph/schema/services/collection.py index bb837c63..905b2056 100644 --- a/trustgraph-base/trustgraph/schema/services/collection.py +++ b/trustgraph-base/trustgraph/schema/services/collection.py @@ -42,8 +42,7 @@ class CollectionManagementRequest(Record): class CollectionManagementResponse(Record): """Response for collection management operations""" - success = String() # "true" or "false" - error = Error() # Only populated if success is "false" + error = Error() # Only populated if there's an error timestamp = String() # ISO timestamp collections = Array(CollectionMetadata()) diff --git a/trustgraph-flow/trustgraph/librarian/collection_manager.py b/trustgraph-flow/trustgraph/librarian/collection_manager.py index c3641629..03868095 100644 --- a/trustgraph-flow/trustgraph/librarian/collection_manager.py +++ b/trustgraph-flow/trustgraph/librarian/collection_manager.py @@ -116,7 +116,6 @@ class CollectionManager: ] return CollectionManagementResponse( - success="true", collections=collection_metadata, timestamp=datetime.now().isoformat() ) @@ -187,7 +186,6 @@ class CollectionManager: ) return CollectionManagementResponse( - success="true", collections=[collection_metadata], timestamp=datetime.now().isoformat() ) @@ -256,7 +254,6 @@ class CollectionManager: del self.pending_deletions[deletion_key] return CollectionManagementResponse( - success="false", error=Error( type="storage_deletion_error", message=error_msg @@ -272,7 +269,6 @@ class CollectionManager: del self.pending_deletions[deletion_key] return CollectionManagementResponse( - success="true", timestamp=datetime.now().isoformat() ) diff --git a/trustgraph-flow/trustgraph/librarian/service.py b/trustgraph-flow/trustgraph/librarian/service.py index c29ce4a7..00d64010 100755 --- a/trustgraph-flow/trustgraph/librarian/service.py +++ b/trustgraph-flow/trustgraph/librarian/service.py @@ -441,7 +441,6 @@ class Processor(AsyncProcessor): ) except RequestError as e: resp = CollectionManagementResponse( - success="false", error=Error( type="request-error", message=str(e), @@ -453,7 +452,6 @@ class Processor(AsyncProcessor): ) except Exception as e: resp = CollectionManagementResponse( - success="false", error=Error( type="unexpected-error", message=str(e),