apunkt/rowboat
1
0
Fork 0
mirror of https://github.com/rowboatlabs/rowboat.git synced 2026-07-24 21:41:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(x): stage only the current platform's node-pty prebuilds

Browse source 
Every build shipped all platforms' prebuilt binaries. Windows code
signing walks every .node file in the app and signtool hard-fails on
the Mach-O darwin pty.node ("file format cannot be signed"). Filtering
to the host platform fixes signing and drops dead weight from all
installers. The Linux CI-compiled prebuild and the node-gyp self-heal
path both still stage correctly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Ramnique Singh 2026-07-23 10:49:58 +05:30
parent 9eb6a81b98
commit 4e4a91583f
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
apps/x/apps/main/bundle.mjs
View file

@ -59,10 +59,20 @@ const ptySrc = fs.realpathSync(path.join(here, 'node_modules', 'node-pty'));
const ptyDest = path.join(here, '.package', 'node_modules', 'node-pty');
fs.rmSync(ptyDest, { recursive: true, force: true });
fs.mkdirSync(ptyDest, { recursive: true });
for (const item of ['package.json', 'lib', 'prebuilds']) {
for (const item of ['package.json', 'lib']) {
fs.cpSync(path.join(ptySrc, item), path.join(ptyDest, item), { recursive: true, dereference: true });
}
// Stage only the CURRENT platform's prebuilds. Each OS packages natively in CI,
// so other platforms' binaries are dead weight — and worse: Windows code signing
// walks every .node file in the app and signtool hard-fails on the Mach-O darwin
// pty.node ("file format cannot be signed").
const prebuildsSrc = path.join(ptySrc, 'prebuilds');
const prebuildsDir = path.join(ptyDest, 'prebuilds');
fs.mkdirSync(prebuildsDir, { recursive: true });
for (const dir of fs.readdirSync(prebuildsSrc)) {
if (!dir.startsWith(`${process.platform}-`)) continue;
fs.cpSync(path.join(prebuildsSrc, dir), path.join(prebuildsDir, dir), { recursive: true, dereference: true });
}
for (const dir of fs.readdirSync(prebuildsDir)) {
const helper = path.join(prebuildsDir, dir, 'spawn-helper');
if (fs.existsSync(helper)) fs.chmodSync(helper, 0o755);