apunkt/rowboat
1
0
Fork 0
mirror of https://github.com/rowboatlabs/rowboat.git synced 2026-07-24 21:41:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(ci): don't run bare signtool in the signing setup step

Browse source 
signtool with no arguments prints usage and exits 1, and the Actions
pwsh wrapper propagates the last native exit code as the step result,
failing the job after an otherwise successful setup. Log the signtool
version from file metadata instead.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Ramnique Singh 2026-07-23 10:42:30 +05:30
parent df72bb2b29
commit 9eb6a81b98
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
.github/workflows/electron-build.yml vendored
View file

@ -276,7 +276,10 @@ jobs:
Sort-Object { [version]$_.Directory.Parent.Name } | Select-Object -Last 1
if (-not $signtool) { throw "signtool.exe not found in Windows SDK" }
Copy-Item $signtool.FullName "$dir\signtool.exe"
& "$dir\signtool.exe" | Select-Object -First 3
# NOTE: don't run signtool bare to "print usage" — it exits 1 and the
# Actions pwsh wrapper turns the last native exit code into a step
# failure. Read the version from file metadata instead.
echo "Using signtool $((Get-Item "$dir\signtool.exe").VersionInfo.ProductVersion) from $($signtool.FullName)"
echo "AZURE_CODE_SIGNING_DLIB=$dlib" >> $env:GITHUB_ENV
echo "AZURE_METADATA_JSON=$dir\metadata.json" >> $env:GITHUB_ENV