Addresses the Greptile review on #217: P1 — `lint` reported two different names. `command_label` returns `lint`, but `execute_query_lint` passed `"query lint"` as the resolver operation string, so `lint --server` said `lint` while `lint <https>` said `query lint`. Both were pinned by tests. `query lint` is the *deprecated* alias (argv-rewritten to `lint`), so the canonical name is `lint`: switch both user-facing strings in `execute_query_lint` (the storage-plane bail label and the requires-schema-or-target usage message) to `lint`, and update the two pinned assertions in `cli_data.rs`. P2 — user-doc debt (AGENTS.md rule 1: error text is observable behavior). Document the plane model in `cli-reference.md` (new *Command planes* section: data vs storage/maintenance vs control, which addressing flags apply, and the declared wrong-plane / remote-target errors), and add an addressing note to `maintenance.md` cross-referencing it. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
7.4 KiB
Maintenance: Optimize, Repair & Cleanup
db/omnigraph/optimize.rs and db/omnigraph/repair.rs.
Addressing (RFC-010). optimize, repair, and cleanup are storage-plane CLI commands: they run with direct storage access against a positional URI or --target, never through a server, and reject --server / --graph or a --target that resolves to a remote (http(s)://) URL with a declared error. There are no server routes for them by design — to maintain a server-backed graph, run them out-of-band against the graph's storage URI. See the Command planes section of cli-reference.md.
optimize_all_tables(db) — non-destructive
- Lance
compact_files()on every node + edge table onmain, then publishes the compacted version to the__manifestso the manifest'stable_versiontracks the compacted Lance HEAD. Reads pin the manifest version, so without this publish compaction would be invisible to readers and would break the HEAD-vs-manifest precondition of the next schema apply / strict update/delete ("stale view … refresh and retry"). The publish advances the graph version (a system-attributed commit) only for tables that actually compacted. - Rewrites small fragments into fewer large ones; old fragments remain reachable via older manifests until
cleanupruns. - Each table's compact→publish runs under its per-
(table, main)write queue (serializing with concurrent mutations — compaction is a LanceRewriteop that retryable-conflicts with a concurrent merge/update/delete on overlapping fragments). The Lance-HEAD-before-manifest-publish gap is covered by aSidecarKind::Optimizerecovery sidecar (loose-match): a crash in that window rolls the compacted version forward on the nextOmnigraph::open(compaction is content-preserving, so roll-forward is always safe). - Requires a recovered graph.
optimizerefuses (errors) when an unresolved recovery sidecar is present under__recovery— operating on an unrecovered graph could publish a partial write the open-time recovery sweep would roll back. Reopen the graph to run the recovery sweep, then re-runoptimize. - Uncovered drift is skipped, not interpreted. If a table's Lance HEAD is ahead of the version recorded in
__manifestand no recovery sidecar covers that movement,optimizereportsskipped: Some(DriftNeedsRepair)with the manifest/head versions and leaves the table untouched. Runomnigraph repairto classify and explicitly publish that drift. - Bounded by
OMNIGRAPH_MAINTENANCE_CONCURRENCY(default 8). - Returns
[TableOptimizeStats { table_key, fragments_removed, fragments_added, committed, skipped, manifest_version, lance_head_version }]. - Blob tables are skipped. A table that declares any
Blobproperty is not compacted: it is reported withskipped: Some(BlobColumnsUnsupportedByLance)(and logged viatracing::warn) instead of compacted, and the rest of the sweep proceeds normally. The current Lancecompact_filesmis-decodes blob-v2 columns under its forcedBlobHandling::AllBinaryread; reads and writes are unaffected — only compaction is. This is gated byLANCE_SUPPORTS_BLOB_COMPACTION(db/omnigraph/optimize.rs) and removed when the upstream Lance fix lands (see docs/dev/lance.md). Consequence: fragment count and deleted-row space on blob tables are not reclaimed until then; query results are never affected.
repair_all_tables(db, options) — explicit
- Handles uncovered manifest/head drift: a table's Lance HEAD is ahead of the manifest pin and no recovery sidecar records the writer intent.
- Preview by default.
omnigraph repair --json <uri>reports each table'sclassification,action, manifest/head versions, Lance operation names, and any classification error.--confirmpublishes only verified maintenance drift; if any suspicious or unverifiable table is refused, the CLI prints the per-table output and exits non-zero.--force --confirmalso publishes suspicious or unverifiable drift after operator review. - Classifies drift by reading Lance transactions from
manifest_version + 1throughlance_head_version. OnlyReserveFragmentsandRewriteare verified maintenance. Semantic operations such asAppend,Delete,Update,Merge, or missing transaction history are not auto-healed. - Publishes repair by advancing
__manifestto the existing Lance HEAD; it does not rewrite Lance data. If the publish succeeds, normal reads and strict writes use the repaired version. If it fails, no new data-side partial state was created. - Requires a clean recovery state. Pending
__recoverysidecars still belong to automatic sidecar recovery, not manual repair.
cleanup_all_tables(db, options) — destructive
- Lance
cleanup_old_versions()per table. - Removes manifests (and their unique fragments) older than the retention policy.
CleanupPolicyOptions { keep_versions: Option<u32>, older_than: Option<Duration> }— at least one is required.- Returns
[TableCleanupStats { table_key, bytes_removed, old_versions_removed, error }]. - Fault-isolated per table. A single table's transient failure (version GC or
orphan reclaim) is recorded on that table's stats row (
error: Some(..), logged viatracing) and never aborts the healthy tables — cleanup is the convergence backstop, so it does as much as it can and converges on re-run. The CLI reports any failed tables; reruncleanupto retry them. - CLI guards with
--confirm; without it, prints a preview line. - Recovery floor:
--keep < 3may garbage-collect Lance versions that the open-time recovery sweep needs as a rollback target (the sweep restores to the branch's manifest-pinned table version, which is HEAD-1 in the typical Phase B → Phase C drift case). Default--keep 10is safe. - Orphaned-branch reconciliation: before the version GC, cleanup runs
reconcile_orphaned_branches, whichforce_delete_branches any per-table or commit-graph Lance branch absent from the manifest branch list. These orphans arise when abranch_deleteflips the manifest authority but a downstream best-effort reclaim does not complete (see branches-commits.md). The reconciler is authority-derived and idempotent (it no-ops once nothing is orphaned), runs regardless of thekeep_versions/older_thanvalues (those gate version GC only), and never reclaimsmainor system-branch forks. Reclaimed forks are logged viatracing::info.
Tombstones
Logical sub-table delete markers in __manifest; tombstone_object_id(table_key, version) excludes a sub-table version from snapshot reconstruction.
Internal schema migrations (db/manifest/migrations.rs)
Version evolutions of the on-disk __manifest shape are reconciled automatically on the first write under a new binary. INTERNAL_MANIFEST_SCHEMA_VERSION declares the shape the binary expects; the on-disk stamp omnigraph:internal_schema_version (Lance schema-level metadata) records the on-disk shape. The publisher's open-for-write path calls migrate_internal_schema before reading state; reads are side-effect-free. No operator action is required for in-place upgrades. See storage.md → Internal schema versioning for the full mechanism.
A binary opening a manifest stamped at a version higher than it knows about refuses to publish with a clear "upgrade omnigraph first" error — old binaries cannot clobber a newer schema.