mirror of https://github.com/ModernRelay/omnigraph.git synced 2026-06-09 01:35:18 +02:00

Ragnor Comerford 6f25c4f9f8

Address reviewer feedback (Cursor + cubic) on PR #60

All eight comments verified against source and applied:

- AGENTS.md: pull @docs/{invariants,lance,testing}.md imports out of
  the markdown blockquote. Claude Code's @-import parser expects @ at
  column 0; the leading "> " of a blockquote silently broke
  recognition, so the claimed auto-include did nothing. (Cursor,
  Medium severity.)
- docs/cli-reference.md: command-family count 13 → 17. The current
  enum Command in crates/omnigraph-cli/src/main.rs has 17 top-level
  variants. (cubic P2.)
- docs/ci.md: Homebrew tap update is a regular `git push`, not a
  force-push (release.yml:117 is `git push origin HEAD:main`). (cubic
  P2.)
- docs/errors.md: add the Storage variant to the NanoError list — it
  exists at error.rs:88-89 but the doc enumerated only 10 of 11.
  (cubic P2.)
- docs/storage.md: clarify tombstone semantics. There is no
  tombstone_version column; state.rs:180 reads the tombstone version
  from the table_version column on rows where object_type =
  table_tombstone. (cubic P2.)
- docs/branches-commits.md: split the GraphCommit pseudo-struct from
  the underlying storage. actor_id is joined in-memory from
  _graph_commit_actors.lance, not a column on _graph_commits.lance.
  (cubic P2.)
- docs/schema-language.md: rename IR_VERSION to SCHEMA_IR_VERSION to
  match the actual constant name in catalog/schema_ir.rs:11.
  (cubic P3.)
- docs/testing.md: engine integration test count 16 → 15 (matches
  `ls crates/omnigraph/tests/*.rs`). (cubic P3.)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

2026-04-29 00:09:06 +02:00

1.1 KiB

Raw Blame History

CI / Release Workflows

.github/workflows/:

ci.yml: text-only changes skip; otherwise cargo test --workspace --locked on ubuntu-latest with protobuf compiler. OpenAPI-drift check that auto-commits the regenerated openapi.json for same-repo PRs. Also runs the AGENTS.md cross-link integrity check (scripts/check-agents-md.sh).
AWS feature build job: cargo build/test -p omnigraph-server --features aws on ubuntu-latest.
RustFS S3 integration: spins up RustFS in Docker, runs s3_storage, server_opens_s3_repo_directly_and_serves_snapshot_and_read, and local_cli_s3_end_to_end_init_load_read_flow.
release-edge.yml: on every push to main, retags edge, builds Linux/macOS-Intel/macOS-arm64 archives + sha256, publishes a rolling prerelease.
release.yml: on v* tags, builds the 3-platform matrix and updates the Homebrew tap (scripts/update-homebrew-formula.sh) by pushing the regenerated formula to ModernRelay/homebrew-tap.
package.yml: manual ECR image build; emits two image tags per commit (<sha>, <sha>-aws) via CodeBuild.

1.1 KiB Raw Blame History

CI / Release Workflows

1.1 KiB

Raw Blame History