* docs(cli): fix cluster apply semantics — converges graphs+schema, not config-only `cluster apply` creates graphs, applies schema updates (soft drops), writes stored-query/policy catalog resources, and executes approved graph deletes in one ordered run. Both the user docs and the shipped CLI help text still described it as a "Stage 3A" config-only (query/policy) subset that defers graph/schema changes "to a later stage" — wrong since the graph/schema executor landed. - docs/user/cli/reference.md: rewrite the cluster paragraph to describe apply's actual converge behavior; keep deferred for the genuinely-unsupported case (standalone schema deletes); drop the stale "Stage 3A" / "reserved for later stages" framing. - crates/omnigraph-cli/src/cli.rs: fix the `cluster apply` help text to match. Part of the docs/user coherence cleanup (docs/dev/docs-issues.md, P1). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FQ1Hf4eXLsJmeLUkTYBEw7 * docs(server): align stored-query exposure with cluster-only behavior server.md documented a per-query expose knob ("`mcp.expose` defaults to true; set `mcp: { expose: false }` to hide from the catalog") that does not exist in the only deployment mode. Cluster-only serving lists every stored query: the cluster registry has no expose field (`QueryConfig { file }`) and the boot bridge hardcodes `expose: true` for all cluster queries (omnigraph-server settings), and there is no GQ-level expose annotation. This contradicted clusters/config.md, which already states the correct behavior. Replace the knob bullet with the cluster truth (every applied query is listed; per-query exposure may become a Cedar-policy decision later) and drop the "`mcp.expose` stored queries" phrasing from the catalog description, the endpoint table, and the intro. The `mcp_expose` JSON catalog field is unchanged (still emitted, always true in cluster mode). Part of the docs/user coherence cleanup (docs/dev/docs-issues.md, P1). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FQ1Hf4eXLsJmeLUkTYBEw7 * docs(schema): split direct/embedded vs cluster-managed schema apply schema/index.md claimed `allow_data_loss` is "honored uniformly across transports" and listed HTTP `POST /schema/apply` among them. But that route is 409-disabled for cluster-backed serving (already documented in server.md), and cluster-managed graphs evolve only through `cluster apply` with soft drops — there is no cluster HTTP data-loss path. Scope the data-loss flag to the direct/embedded path (`schema apply --store`, SDK), and add a paragraph: cluster-managed graphs use `cluster apply` (soft drops only); HTTP `POST /schema/apply` is 409 for cluster serving; direct apply against a cluster-managed path is refused. Cross-refs server + cluster docs. Part of the docs/user coherence cleanup (docs/dev/docs-issues.md, P2). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FQ1Hf4eXLsJmeLUkTYBEw7 * docs(server): document /load as canonical in limits + admission prose The endpoint table already listed both `/load` (canonical) and `/ingest` (deprecated alias) at 32 MB, but the admission-control, body-limit, rate-limit, and manifest-conflict prose named only `/ingest` — and the constants page called the limit "Ingest body limit". Add `/load` alongside (or ahead of) `/ingest` everywhere, and rename the constant to "Load (bulk-write) body limit" noting the `/ingest` alias shares it. Part of the docs/user coherence cleanup (docs/dev/docs-issues.md, P2). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FQ1Hf4eXLsJmeLUkTYBEw7 * docs(cli): drop stale bearer-token keys + fix version string The "Bearer token resolution (CLI)" section still listed removed omnigraph.yaml keys (`graphs.<name>.bearer_token_env`, `auth.env_file`) — config surfaces that no longer exist and that implied plaintext tokens in config. Replace it with a pointer to the keyed-credential model documented above (`OMNIGRAPH_TOKEN_<NAME>` → `~/.omnigraph/credentials` → `OMNIGRAPH_BEARER_TOKEN`). Also fix the `version` row: the CLI prints 0.7.x, not 0.3.x. Part of the docs/user coherence cleanup (docs/dev/docs-issues.md, P2 + smaller). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FQ1Hf4eXLsJmeLUkTYBEw7 * docs: route-spelling note + drop stale stage/deferred crumbs - server.md: add a one-line note that the per-graph subsections name routes in shorthand (`GET /queries`, `POST /query`, `POST /mutate`, `POST /queries/{name}`) but every one is served under `/graphs/{id}/…` — the endpoint table is already fully-qualified. - clusters/config.md: redefine the `deferred` plan disposition as an unsupported change (e.g. a standalone schema delete) instead of "graph/schema change, later phase" (graph creates and schema updates apply now); drop the "Stage 2C" label from the lock-recovery note. - search/indexes.md: `ingest --mode merge` → canonical `load --mode merge`. Part of the docs/user coherence cleanup (docs/dev/docs-issues.md, P2 + smaller). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FQ1Hf4eXLsJmeLUkTYBEw7 * docs(dev): track user-docs coherence ledger; mark 2026-06-20 findings resolved Convert the scratch review notes into a tracked living ledger and link it from the dev index. All ten findings from the 2026-06-20 docs/user sweep are validated and fixed in this branch (P1 cluster-apply semantics + stored-query exposure; P2 schema-apply paths, /load canonical, bearer-token keys, route shorthand; plus version/ingest/deferred/stage crumbs). The verification grep checklist is retained for future audits. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FQ1Hf4eXLsJmeLUkTYBEw7 * docs(api): align GET /queries OpenAPI contract with cluster-only behavior Greptile P1 on #293: the prose fix in server.md left the OpenAPI surface stale. The utoipa annotations (handlers.rs, omnigraph-api-types QueriesCatalogOutput) still described the catalog as "the `mcp.expose == true` subset", and those drive the checked-in openapi.json — so SDK consumers read a contract the cluster-only server does not honor (it lists every stored query). Update the three Rust doc-comment/annotation strings to "every stored query" and regenerate openapi.json (OMNIGRAPH_UPDATE_OPENAPI=1; drift test green) in the same change, per AGENTS.md rule 4. Ledger updated: this finding resolved, plus the cross-repo drift it surfaced (omnigraph-ts generated spec/types and omnigraph-cookbooks best-practices bearer_token_env) tracked as open follow-ups. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FQ1Hf4eXLsJmeLUkTYBEw7 --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
5.7 KiB
User Docs Coherence Ledger
Last review: 2026-06-20 (against 0.7.1) Status: all open findings resolved — living ledger for future audits.
This page tracks stale or incoherent user-doc claims found during broad docs reviews. Findings are validated against current code/behavior, not just cross-doc consistency. Record new findings as they surface; mark them resolved (with the fixing commit) once the public pages are corrected.
Resolved — 2026-06-20 docs/user coherence sweep
Every finding from the 2026-06-20 review was validated (all reproduced) and
fixed. Branch docs/user-coherence-0-7-1.
| Pri | Finding | Resolution |
|---|---|---|
| P1 | cluster apply documented as catalog-only / "Stage 3A" with graph+schema deferred — in both cli/reference.md and the shipped CLI help (cli.rs) |
Rewrote both to describe the real converge behavior (creates graphs, applies schema with soft drops, writes catalog, executes approved deletes in one ordered run); deferred now means the genuinely-unsupported case (standalone schema delete). |
| P1 | Stored-query exposure had two contracts: server.md documented a per-query mcp:{expose:false} knob; cluster docs said all queries are listed |
Confirmed in code: cluster registry has no expose field (QueryConfig), boot bridge hardcodes expose: true (omnigraph-server settings), no GQ-level annotation. Removed the knob from server.md; documented "every applied query is listed; per-query exposure may become a Cedar-policy decision later". |
| P1 | The same stale "mcp.expose == true subset" contract lived in the OpenAPI surface: utoipa annotations (handlers.rs:1029,1037, omnigraph-api-types/src/lib.rs:404) drove openapi.json (Greptile catch on #293) |
Updated the three Rust doc-comment/annotation strings to "every stored query" and regenerated openapi.json (OMNIGRAPH_UPDATE_OPENAPI=1); drift test green. Same-change per AGENTS.md rule 4. |
| P2 | schema/index.md claimed allow_data_loss honored "uniformly across transports" incl. HTTP POST /schema/apply |
Scoped to the direct/embedded path; added that cluster-managed graphs evolve via cluster apply (soft drops only) and the HTTP route is 409-disabled for cluster serving. |
| P2 | /load missing from admission / body-limit / rate-limit / manifest-conflict prose (named /ingest only); constants called it "Ingest body limit" |
Documented /load as canonical everywhere with /ingest as the deprecated alias; renamed the constant to "Load (bulk-write) body limit". |
| P2 | CLI "Bearer token resolution" section listed removed omnigraph.yaml keys (graphs.<name>.bearer_token_env, auth.env_file) |
Replaced with a pointer to the keyed-credential model (OMNIGRAPH_TOKEN_<NAME> → ~/.omnigraph/credentials → OMNIGRAPH_BEARER_TOKEN); no plaintext-in-config path. |
| P2 | Flat route names in a cluster-only server (POST /query, POST /mutate, GET /queries, POST /queries/{name}) |
Added a one-line note that the per-graph subsections use shorthand under /graphs/{id}/…; the endpoint table is already fully qualified. |
| — | version printed omnigraph 0.3.x |
→ 0.7.x. |
| — | search/indexes.md used deprecated ingest --mode merge |
→ load --mode merge. |
| — | config.md deferred disposition described as "graph/schema change, later phase" |
→ "an unsupported change (e.g. standalone schema delete)". |
| — | Stale stage labels (Stage 3A, Stage 2C, Stage 1) in active reference docs |
Removed / reworded to plain language; release notes keep history. |
Open — surfaced 2026-06-20, not yet fixed
- Stale "config-only apply" / "Stage 3A" comments in
omnigraph-clustersource (internal rustdoc, not user docs — out of scope for the docs sweep above):src/types.rs:147("Applied changes execute (config-only query/policy catalog writes)"),src/types.rs:265("Output of config-only cluster apply"),src/diff.rs:256, andsrc/tests.rs:1129("config-only apply (Stage 3A)"). Apply now also runs graph creates, schema applies, and approved deletes (diff.rs:411GraphCreate/SchemaApply; the Stage-4 create/schema/delete executors + testsapply_creates_graph_and_unblocks_dependents,apply_schema_update_and_dependent_query_in_one_run,apply_blocks_graph_delete_without_approval). Update these comments in a cluster-crate change. - Cross-repo drift from this sweep (separate repos — track here, fix in a
follow-up in each repo):
omnigraph-tsSDK ships a stale generatedspec/openapi.json+packages/sdk/src/generated/types.gen.tsstill describing theGET /queriescatalog as themcp.exposesubset. Regenerate from this repo'sopenapi.jsononce the SDK's deferred refresh happens (the SDK is known to lag the API by design).omnigraph-cookbooks/docs/best-practices.md(~line 372) still describes client-side auth as resolving through the removedbearer_token_envchain. Update to the keyed-credential model (OMNIGRAPH_TOKEN_<NAME>→ credentials file →OMNIGRAPH_BEARER_TOKEN).
Verification checklist (re-run on the next docs audit)
rg -n "Stage [0-9]|graph/schema changes are deferred|reserved for later stages" docs/user crates/omnigraph-cli/src/cli.rs
rg -n "POST /query|POST /mutate|GET /queries|POST /queries/\{name\}|POST /schema/apply" docs/user
rg -n "ingest --mode|Ingest body limit|/ingest" docs/user
rg -n "0\.3\.x|bearer_token_env|auth\.env_file" docs/user
rg -n "expose: false|mcp\.expose" docs/user
Expected: active user docs have no matches for stale phrases, or the remaining
matches are explicitly marked as deprecated aliases, "no longer exist" notes, or
route shorthand disclaimed relative to /graphs/{id}. Release notes are allowed
to preserve historical behavior.