apunkt/ktx
1
0
Fork 0
mirror of https://github.com/Kaelio/ktx.git synced 2026-06-07 07:55:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(cli): remove redundant "already" from configured sources label (#83)

Browse source 
The word "already" in "Primary sources already configured" adds no
information and reads awkwardly in the setup flow.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Luca Martial 2026-05-13 19:51:24 -04:00 • committed by GitHub
parent 5b4ba73e64
commit 6d7d90571e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

22
packages/cli/src/setup-databases.test.ts
View file

@ -628,7 +628,7 @@ describe('setup databases step', () => {
expect(result).toEqual({ status: 'ready', projectDir: tempDir, connectionIds: ['warehouse'] });
expect(prompts.multiselect).not.toHaveBeenCalled();
expect(prompts.select).toHaveBeenCalledWith({
message: 'Databases already configured: warehouse\nWhat would you like to do?',
message: 'Databases configured: warehouse\nWhat would you like to do?',
options: [
{ value: 'continue', label: 'Continue to context sources' },
{ value: 'edit', label: 'Edit an existing database' },
@ -687,7 +687,7 @@ describe('setup databases step', () => {
required: true,
}));
expect(prompts.select).toHaveBeenCalledWith({
message: 'Databases already configured: warehouse\nWhat would you like to do?',
message: 'Databases configured: warehouse\nWhat would you like to do?',
options: [
{ value: 'continue', label: 'Continue to context sources' },
{ value: 'edit', label: 'Edit an existing database' },
@ -733,7 +733,7 @@ describe('setup databases step', () => {
required: true,
}));
expect(prompts.select).toHaveBeenCalledWith({
message: 'Databases already configured: postgres-warehouse\nWhat would you like to do?',
message: 'Databases configured: postgres-warehouse\nWhat would you like to do?',
options: [
{ value: 'continue', label: 'Continue to context sources' },
{ value: 'edit', label: 'Edit an existing database' },
@ -778,7 +778,7 @@ describe('setup databases step', () => {
}));
expect(io.stdout()).not.toContain('KTX cannot work without at least one database');
expect(prompts.select).toHaveBeenNthCalledWith(3, {
message: 'Databases already configured: postgres-warehouse\nWhat would you like to do?',
message: 'Databases configured: postgres-warehouse\nWhat would you like to do?',
options: [
{ value: 'continue', label: 'Continue to context sources' },
{ value: 'edit', label: 'Edit an existing database' },
@ -823,7 +823,7 @@ describe('setup databases step', () => {
}));
expect(io.stdout()).not.toContain('KTX cannot work without at least one database');
expect(prompts.select).toHaveBeenNthCalledWith(2, {
message: 'Databases already configured: warehouse\nWhat would you like to do?',
message: 'Databases configured: warehouse\nWhat would you like to do?',
options: [
{ value: 'continue', label: 'Continue to context sources' },
{ value: 'edit', label: 'Edit an existing database' },
@ -870,7 +870,7 @@ describe('setup databases step', () => {
],
});
expect(prompts.select).toHaveBeenNthCalledWith(3, {
message: 'Databases already configured: warehouse\nWhat would you like to do?',
message: 'Databases configured: warehouse\nWhat would you like to do?',
options: [
{ value: 'continue', label: 'Continue to context sources' },
{ value: 'edit', label: 'Edit an existing database' },
@ -907,7 +907,7 @@ describe('setup databases step', () => {
});
let primaryMenuCount = 0;
vi.mocked(prompts.select).mockImplementation(async (options) => {
if (options.message === 'Databases already configured: warehouse\nWhat would you like to do?') {
if (options.message === 'Databases configured: warehouse\nWhat would you like to do?') {
primaryMenuCount += 1;
return primaryMenuCount === 1 ? 'edit' : 'continue';
}
@ -980,7 +980,7 @@ describe('setup databases step', () => {
});
let primaryMenuCount = 0;
vi.mocked(prompts.select).mockImplementation(async (options) => {
if (options.message === 'Databases already configured: warehouse\nWhat would you like to do?') {
if (options.message === 'Databases configured: warehouse\nWhat would you like to do?') {
primaryMenuCount += 1;
return primaryMenuCount === 1 ? 'edit' : 'continue';
}
@ -1053,7 +1053,7 @@ describe('setup databases step', () => {
});
let primaryMenuCount = 0;
vi.mocked(prompts.select).mockImplementation(async (options) => {
if (options.message === 'Databases already configured: warehouse\nWhat would you like to do?') {
if (options.message === 'Databases configured: warehouse\nWhat would you like to do?') {
primaryMenuCount += 1;
return primaryMenuCount === 1 ? 'edit' : 'continue';
}
@ -1120,7 +1120,7 @@ describe('setup databases step', () => {
const prompts = makePromptAdapter({ textValues: ['env:DATABASE_URL'] });
let primaryMenuCount = 0;
vi.mocked(prompts.select).mockImplementation(async (options) => {
if (options.message === 'Databases already configured: warehouse\nWhat would you like to do?') {
if (options.message === 'Databases configured: warehouse\nWhat would you like to do?') {
primaryMenuCount += 1;
return primaryMenuCount === 1 ? 'edit' : 'continue';
}
@ -1188,7 +1188,7 @@ describe('setup databases step', () => {
textValues: ['env:DATABASE_URL'],
});
vi.mocked(prompts.select).mockImplementation(async (options) => {
if (options.message === 'Databases already configured: warehouse\nWhat would you like to do?') return 'edit';
if (options.message === 'Databases configured: warehouse\nWhat would you like to do?') return 'edit';
if (options.message === 'Database to edit') return 'warehouse';
if (options.message === 'How do you want to connect to PostgreSQL?') return 'url';
if (options.message.startsWith('Enable query-history ingest')) return 'no';

2
packages/cli/src/setup-databases.ts
View file

@ -541,7 +541,7 @@ function configuredPrimarySourcesPrompt(connectionIds: string[]): {
options: Array<{ value: string; label: string }>;
} {
return {
message: `Databases already configured: ${connectionIds.join(', ')}\nWhat would you like to do?`,
message: `Databases configured: ${connectionIds.join(', ')}\nWhat would you like to do?`,
options: [
{ value: 'continue', label: 'Continue to context sources' },
{ value: 'edit', label: 'Edit an existing database' },