From 6d7d90571e606768cf95d8a3f3bfce35430e3cfb Mon Sep 17 00:00:00 2001 From: Luca Martial <48870843+luca-martial@users.noreply.github.com> Date: Wed, 13 May 2026 19:51:24 -0400 Subject: [PATCH] fix(cli): remove redundant "already" from configured sources label (#83) The word "already" in "Primary sources already configured" adds no information and reads awkwardly in the setup flow. Co-authored-by: Claude Opus 4.6 (1M context) --- packages/cli/src/setup-databases.test.ts | 22 +++++++++++----------- packages/cli/src/setup-databases.ts | 2 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/packages/cli/src/setup-databases.test.ts b/packages/cli/src/setup-databases.test.ts index 8e53f0bf..276d95f1 100644 --- a/packages/cli/src/setup-databases.test.ts +++ b/packages/cli/src/setup-databases.test.ts @@ -628,7 +628,7 @@ describe('setup databases step', () => { expect(result).toEqual({ status: 'ready', projectDir: tempDir, connectionIds: ['warehouse'] }); expect(prompts.multiselect).not.toHaveBeenCalled(); expect(prompts.select).toHaveBeenCalledWith({ - message: 'Databases already configured: warehouse\nWhat would you like to do?', + message: 'Databases configured: warehouse\nWhat would you like to do?', options: [ { value: 'continue', label: 'Continue to context sources' }, { value: 'edit', label: 'Edit an existing database' }, @@ -687,7 +687,7 @@ describe('setup databases step', () => { required: true, })); expect(prompts.select).toHaveBeenCalledWith({ - message: 'Databases already configured: warehouse\nWhat would you like to do?', + message: 'Databases configured: warehouse\nWhat would you like to do?', options: [ { value: 'continue', label: 'Continue to context sources' }, { value: 'edit', label: 'Edit an existing database' }, @@ -733,7 +733,7 @@ describe('setup databases step', () => { required: true, })); expect(prompts.select).toHaveBeenCalledWith({ - message: 'Databases already configured: postgres-warehouse\nWhat would you like to do?', + message: 'Databases configured: postgres-warehouse\nWhat would you like to do?', options: [ { value: 'continue', label: 'Continue to context sources' }, { value: 'edit', label: 'Edit an existing database' }, @@ -778,7 +778,7 @@ describe('setup databases step', () => { })); expect(io.stdout()).not.toContain('KTX cannot work without at least one database'); expect(prompts.select).toHaveBeenNthCalledWith(3, { - message: 'Databases already configured: postgres-warehouse\nWhat would you like to do?', + message: 'Databases configured: postgres-warehouse\nWhat would you like to do?', options: [ { value: 'continue', label: 'Continue to context sources' }, { value: 'edit', label: 'Edit an existing database' }, @@ -823,7 +823,7 @@ describe('setup databases step', () => { })); expect(io.stdout()).not.toContain('KTX cannot work without at least one database'); expect(prompts.select).toHaveBeenNthCalledWith(2, { - message: 'Databases already configured: warehouse\nWhat would you like to do?', + message: 'Databases configured: warehouse\nWhat would you like to do?', options: [ { value: 'continue', label: 'Continue to context sources' }, { value: 'edit', label: 'Edit an existing database' }, @@ -870,7 +870,7 @@ describe('setup databases step', () => { ], }); expect(prompts.select).toHaveBeenNthCalledWith(3, { - message: 'Databases already configured: warehouse\nWhat would you like to do?', + message: 'Databases configured: warehouse\nWhat would you like to do?', options: [ { value: 'continue', label: 'Continue to context sources' }, { value: 'edit', label: 'Edit an existing database' }, @@ -907,7 +907,7 @@ describe('setup databases step', () => { }); let primaryMenuCount = 0; vi.mocked(prompts.select).mockImplementation(async (options) => { - if (options.message === 'Databases already configured: warehouse\nWhat would you like to do?') { + if (options.message === 'Databases configured: warehouse\nWhat would you like to do?') { primaryMenuCount += 1; return primaryMenuCount === 1 ? 'edit' : 'continue'; } @@ -980,7 +980,7 @@ describe('setup databases step', () => { }); let primaryMenuCount = 0; vi.mocked(prompts.select).mockImplementation(async (options) => { - if (options.message === 'Databases already configured: warehouse\nWhat would you like to do?') { + if (options.message === 'Databases configured: warehouse\nWhat would you like to do?') { primaryMenuCount += 1; return primaryMenuCount === 1 ? 'edit' : 'continue'; } @@ -1053,7 +1053,7 @@ describe('setup databases step', () => { }); let primaryMenuCount = 0; vi.mocked(prompts.select).mockImplementation(async (options) => { - if (options.message === 'Databases already configured: warehouse\nWhat would you like to do?') { + if (options.message === 'Databases configured: warehouse\nWhat would you like to do?') { primaryMenuCount += 1; return primaryMenuCount === 1 ? 'edit' : 'continue'; } @@ -1120,7 +1120,7 @@ describe('setup databases step', () => { const prompts = makePromptAdapter({ textValues: ['env:DATABASE_URL'] }); let primaryMenuCount = 0; vi.mocked(prompts.select).mockImplementation(async (options) => { - if (options.message === 'Databases already configured: warehouse\nWhat would you like to do?') { + if (options.message === 'Databases configured: warehouse\nWhat would you like to do?') { primaryMenuCount += 1; return primaryMenuCount === 1 ? 'edit' : 'continue'; } @@ -1188,7 +1188,7 @@ describe('setup databases step', () => { textValues: ['env:DATABASE_URL'], }); vi.mocked(prompts.select).mockImplementation(async (options) => { - if (options.message === 'Databases already configured: warehouse\nWhat would you like to do?') return 'edit'; + if (options.message === 'Databases configured: warehouse\nWhat would you like to do?') return 'edit'; if (options.message === 'Database to edit') return 'warehouse'; if (options.message === 'How do you want to connect to PostgreSQL?') return 'url'; if (options.message.startsWith('Enable query-history ingest')) return 'no'; diff --git a/packages/cli/src/setup-databases.ts b/packages/cli/src/setup-databases.ts index 1fd76faa..add31a4d 100644 --- a/packages/cli/src/setup-databases.ts +++ b/packages/cli/src/setup-databases.ts @@ -541,7 +541,7 @@ function configuredPrimarySourcesPrompt(connectionIds: string[]): { options: Array<{ value: string; label: string }>; } { return { - message: `Databases already configured: ${connectionIds.join(', ')}\nWhat would you like to do?`, + message: `Databases configured: ${connectionIds.join(', ')}\nWhat would you like to do?`, options: [ { value: 'continue', label: 'Continue to context sources' }, { value: 'edit', label: 'Edit an existing database' },