test: split cli tests from source tree (#216)

* feat(cli): define full warehouse dialect contract

* test(cli): keep dialect edge tests focused

* fix(cli): stabilize dialect contract foundation

* refactor(connectors): own read-only query preparation

* refactor(connectors): resolve dialects through registry

* refactor(connectors): keep concrete dialect classes internal

* chore(workspace): enforce dialect import boundary

* refactor(cli): resolve relationship dialect at scan boundary

* refactor(cli): use dialect display parsing for entity details

* refactor(cli): use dialect display parsing for warehouse catalog

* refactor(cli): use dialect SQL in relationship workflows

* test(cli): verify solid dialect scan workflow closure

* test: split cli tests from source tree

* refactor(cli): standardize BigQuery scope listing

* feat(sqlite): implement connector scope listing

* test(connectors): cover required table listing

* feat(cli): add warehouse driver registry

* refactor(setup): route scope discovery through driver registry

* refactor(cli): route local query execution through driver registry

* refactor(historic-sql): route dialect support through driver registry

* refactor(cli): test warehouse connections through driver registry

* fix(cli): close driver registry type export gaps

* Improve setup daemon diagnostics

* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback

Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.

* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match

The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.

Align the picker boundary with the canonical 3-level KtxTableRef:

- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
  resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
  (resolveEnabledTables already accepts the 3-part shape) and
  schemasFromEnabledTables now goes through parseDottedTableEntry so it
  recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
  reuse.

Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).

* fix(cli): allow debug telemetry under opt-out env

scripts/anti-fixture-conditional.test.mjs

@@ -19,7 +19,7 @@ const RELATIONSHIP_RUNTIME_SOURCES = Object.freeze([
 ]);
 
 async function checkedInFixtureIds() {
-  const fixtureRoot = new URL('packages/cli/src/test/fixtures/relationship-benchmarks/', KTX_ROOT);
+  const fixtureRoot = new URL('packages/cli/test/fixtures/relationship-benchmarks/', KTX_ROOT);
   const entries = await readdir(fixtureRoot, { withFileTypes: true });
   return entries
     .filter((entry) => entry.isDirectory())

scripts/build-benchmark-snapshot.test.mjs

@@ -257,7 +257,7 @@ describe('buildBenchmarkSnapshot', () => {
 
     assert.equal(
       packageJson.scripts['relationships:benchmarks:test'],
-      'KTX_RUN_RELATIONSHIP_BENCHMARKS=1 vitest run src/context/scan/relationship-benchmarks.test.ts',
+      'KTX_RUN_RELATIONSHIP_BENCHMARKS=1 vitest run test/context/scan/relationship-benchmarks.test.ts',
     );
   });
 });

scripts/check-boundaries.mjs

@@ -68,6 +68,13 @@ const contextProductionLlmBoundaryPatterns = [
   },
 ];
 
+const concreteDialectImportPatterns = [
+  /from\s+['"][^'"]*connectors\/[^'"]+\/dialect\.js['"]/,
+  /import\s*\(\s*['"][^'"]*connectors\/[^'"]+\/dialect\.js['"]\s*\)/,
+  /from\s+['"]\.\/dialect\.js['"]/,
+  /import\s*\(\s*['"]\.\/dialect\.js['"]\s*\)/,
+];
+
 function normalizePath(filePath) {
   return filePath.split(path.sep).join('/');
 }
@@ -99,6 +106,13 @@ function scansForContextProductionLlmBoundaries(relativePath) {
   return scansForLlmBoundaries(relativePath) && !isTestSource(relativePath);
 }
 
+function scansForConcreteDialectImportBoundaries(relativePath) {
+  return (
+    relativePath.startsWith('packages/cli/src/context/scan/') ||
+    /^packages\/cli\/src\/connectors\/[^/]+\/connector\.ts$/.test(relativePath)
+  );
+}
+
 function scansForForbiddenIdentifiers(relativePath) {
   return (isCodeSource(relativePath) && !isTestSource(relativePath)) || isRuntimeAsset(relativePath);
 }
@@ -151,6 +165,19 @@ export function scanFileContent(relativePath, content) {
     }
   }
 
+  if (scansForConcreteDialectImportBoundaries(normalizedPath)) {
+    for (const pattern of concreteDialectImportPatterns) {
+      if (pattern.test(content)) {
+        violations.push({
+          file: normalizedPath,
+          kind: 'dialect-boundary',
+          message:
+            'Forbidden concrete connector dialect import; use getDialectForDriver() from context/connections/dialects.ts',
+        });
+      }
+    }
+  }
+
   if (
     scansForForbiddenIdentifiers(normalizedPath) &&
     !skipsIdentifierScan(normalizedPath) &&

scripts/check-boundaries.test.mjs

@@ -68,8 +68,8 @@ describe('scanFileContent', () => {
   it('allows product identifiers in test fixtures', () => {
     const name = lowerProductName();
 
-    assert.equal(scanFileContent('packages/cli/src/setup.test.ts', `project: ${name}-dev`).length, 0);
-    assert.equal(scanFileContent('packages/cli/src/context/ingest/importer.test.ts', `email: system@${name}.dev`).length, 0);
+    assert.equal(scanFileContent('packages/cli/test/setup.test.ts', `project: ${name}-dev`).length, 0);
+    assert.equal(scanFileContent('packages/cli/test/context/ingest/importer.test.ts', `email: system@${name}.dev`).length, 0);
     assert.equal(scanFileContent('python/ktx-daemon/tests/test_package.py', `${name}-ktx`).length, 0);
   });
 
@@ -112,6 +112,43 @@ describe('scanFileContent', () => {
     );
   });
 
+  it('rejects concrete connector dialect imports from scan workflow and connector classes', () => {
+    const violations = [
+      ...scanFileContent(
+        'packages/cli/src/context/scan/relationship-profiling.ts',
+        "import { KtxPostgresDialect } from '../../connectors/postgres/dialect.js';",
+      ),
+      ...scanFileContent(
+        'packages/cli/src/connectors/postgres/connector.ts',
+        "import { KtxPostgresDialect } from './dialect.js';",
+      ),
+    ];
+
+    assert.deepEqual(
+      violations.map((violation) => violation.kind),
+      ['dialect-boundary', 'dialect-boundary'],
+    );
+    assert.equal(
+      violations[0]?.message,
+      'Forbidden concrete connector dialect import; use getDialectForDriver() from context/connections/dialects.ts',
+    );
+
+    assert.deepEqual(
+      scanFileContent(
+        'packages/cli/src/context/connections/dialects.ts',
+        "import { KtxPostgresDialect } from '../../connectors/postgres/dialect.js';",
+      ),
+      [],
+    );
+    assert.deepEqual(
+      scanFileContent(
+        'packages/cli/test/connectors/postgres/dialect.test.ts',
+        "import { KtxPostgresDialect } from './dialect.js';",
+      ),
+      [],
+    );
+  });
+
   it('rejects old KTX LLM port declarations in context', () => {
     const violations = [
       ...scanFileContent('packages/cli/src/context/agent/agent-runner.service.ts', 'export interface LlmProviderPort {}'),
@@ -150,7 +187,7 @@ describe('scanFileContent', () => {
 
     assert.deepEqual(
       scanFileContent(
-        'packages/cli/src/context/ingest/page-triage/page-triage.service.test.ts',
+        'packages/cli/test/context/ingest/page-triage/page-triage.service.test.ts',
         "const model = this.deps.llmProvider.getModelByName('test-model');",
       ),
       [],

scripts/examples-docs.test.mjs

@@ -309,10 +309,10 @@ describe('standalone example docs', () => {
   it('runs the example smoke in the cli smoke script', async () => {
     const packageJson = JSON.parse(await readText('packages/cli/package.json'));
 
-    assert.match(packageJson.scripts.smoke, /src\/standalone-smoke\.test\.ts/);
-    assert.match(packageJson.scripts.smoke, /src\/example-smoke\.test\.ts/);
-    assert.match(packageJson.scripts.test, /--exclude src\/standalone-smoke\.test\.ts/);
-    assert.match(packageJson.scripts.test, /--exclude src\/example-smoke\.test\.ts/);
+    assert.match(packageJson.scripts.smoke, /test\/standalone-smoke\.test\.ts/);
+    assert.match(packageJson.scripts.smoke, /test\/example-smoke\.test\.ts/);
+    assert.match(packageJson.scripts.test, /--exclude test\/standalone-smoke\.test\.ts/);
+    assert.match(packageJson.scripts.test, /--exclude test\/example-smoke\.test\.ts/);
   });
 
   it('documents daemon HTTP database, source generation, LookML, embedding, and code execution support', async () => {

scripts/relationship-benchmark-report.mjs

@@ -14,7 +14,7 @@ import {
 
 const scriptDir = dirname(fileURLToPath(import.meta.url));
 const ktxRoot = resolve(scriptDir, '..');
-const fixtureRoot = join(ktxRoot, 'packages/cli/src/test/fixtures/relationship-benchmarks');
+const fixtureRoot = join(ktxRoot, 'packages/cli/test/fixtures/relationship-benchmarks');
 
 async function buildDetector() {
   const backend = process.env.KTX_BENCHMARK_LLM_BACKEND;

scripts/test-tiering.test.mjs

@@ -14,41 +14,41 @@ function assertScriptContainsAll(script, expected) {
 
 describe('test tiering', () => {
   const cliSlowTests = [
-    'src/setup-databases.test.ts',
-    'src/scan.test.ts',
-    'src/commands/connection-metabase-setup.test.ts',
-    'src/setup-models.test.ts',
-    'src/setup-sources.test.ts',
-    'src/setup.test.ts',
-    'src/connection.test.ts',
-    'src/setup-embeddings.test.ts',
-    'src/ingest.test.ts',
-    'src/commands/connection-mapping.test.ts',
-    'src/ingest-viz.test.ts',
-    'src/demo.test.ts',
-    'src/setup-project.test.ts',
-    'src/sl.test.ts',
-    'src/local-scan-connectors.test.ts',
-    'src/commands/connection-notion.test.ts',
+    'test/setup-databases.test.ts',
+    'test/scan.test.ts',
+    'test/commands/connection-metabase-setup.test.ts',
+    'test/setup-models.test.ts',
+    'test/setup-sources.test.ts',
+    'test/setup.test.ts',
+    'test/connection.test.ts',
+    'test/setup-embeddings.test.ts',
+    'test/ingest.test.ts',
+    'test/commands/connection-mapping.test.ts',
+    'test/ingest-viz.test.ts',
+    'test/demo.test.ts',
+    'test/setup-project.test.ts',
+    'test/sl.test.ts',
+    'test/local-scan-connectors.test.ts',
+    'test/commands/connection-notion.test.ts',
   ];
 
   const contextSlowTests = [
-    'src/context/scan/local-scan.test.ts',
-    'src/context/mcp/local-project-ports.test.ts',
-    'src/context/ingest/local-stage-ingest.test.ts',
-    'src/context/sl/pglite-sl-search-prototype.test.ts',
-    'src/context/core/git.service.test.ts',
-    'src/context/ingest/local-adapters.test.ts',
-    'src/context/ingest/local-bundle-ingest.test.ts',
-    'src/context/ingest/local-metabase-ingest.test.ts',
-    'src/context/sl/local-sl.test.ts',
-    'src/context/search/pglite-owner-process.test.ts',
-    'src/context/scan/local-enrichment-artifacts.test.ts',
-    'src/context/search/pglite-spike.test.ts',
-    'src/context/wiki/local-knowledge.test.ts',
-    'src/context/sl/local-query.test.ts',
-    'src/context/scan/relationship-review-decisions.test.ts',
-    'src/context/scan/relationship-profiling.test.ts',
+    'test/context/scan/local-scan.test.ts',
+    'test/context/mcp/local-project-ports.test.ts',
+    'test/context/ingest/local-stage-ingest.test.ts',
+    'test/context/sl/pglite-sl-search-prototype.test.ts',
+    'test/context/core/git.service.test.ts',
+    'test/context/ingest/local-adapters.test.ts',
+    'test/context/ingest/local-bundle-ingest.test.ts',
+    'test/context/ingest/local-metabase-ingest.test.ts',
+    'test/context/sl/local-sl.test.ts',
+    'test/context/search/pglite-owner-process.test.ts',
+    'test/context/scan/local-enrichment-artifacts.test.ts',
+    'test/context/search/pglite-spike.test.ts',
+    'test/context/wiki/local-knowledge.test.ts',
+    'test/context/sl/local-query.test.ts',
+    'test/context/scan/relationship-review-decisions.test.ts',
+    'test/context/scan/relationship-profiling.test.ts',
   ];
 
   it('keeps slow package tests out of default local package test scripts', async () => {