ktx/scripts/check-boundaries.test.mjs

import assert from 'node:assert/strict';
import { describe, it } from 'node:test';

import { scanFileContent } from './check-boundaries.mjs';

function productName() {
  return ['Kae', 'lio'].join('');
}

function lowerProductName() {
  return ['kae', 'lio'].join('');
}

describe('scanFileContent', () => {
  it('rejects source imports from application directories', () => {
    const serverAlias = '@' + 'server/contracts';
    const pythonAppPath = `${['python', 'service'].join('-')}/app/api/endpoints/semantic_layer.py`;

    const violations = [
      ...scanFileContent('packages/cli/src/context/index.ts', `import { orpc } from '${serverAlias}';`),
      ...scanFileContent('packages/cli/src/context/index.ts', `import "${pythonAppPath}";`),
    ];

    assert.deepEqual(
      violations.map((violation) => violation.kind),
      ['app-import', 'app-import'],
    );
  });

  it('rejects forbidden product identifiers in code source files', () => {
    const violations = scanFileContent('packages/cli/src/context/index.ts', `export const owner = '${lowerProductName()}';`);

    assert.equal(violations.length, 1);
    assert.equal(violations[0]?.kind, 'identifier');
  });

  it('rejects forbidden product identifiers in shipped runtime prompt assets', () => {
    const violations = scanFileContent(
      'packages/cli/src/prompts/memory_agent_bundle_ingest_work_unit.md',
      `Write output for ${productName()}.`,
    );

    assert.equal(violations.length, 1);
    assert.equal(violations[0]?.kind, 'identifier');
    assert.equal(violations[0]?.file, 'packages/cli/src/prompts/memory_agent_bundle_ingest_work_unit.md');
  });

  it('rejects forbidden product identifiers in shipped runtime skill assets', () => {
    const violations = scanFileContent(
      'packages/cli/src/skills/metabase_ingest/SKILL.md',
      `Use ${productName()} project conventions.`,
    );

    assert.equal(violations.length, 1);
    assert.equal(violations[0]?.kind, 'identifier');
    assert.equal(violations[0]?.file, 'packages/cli/src/skills/metabase_ingest/SKILL.md');
  });

  it('allows product identifiers in docs, examples, and transition metadata', () => {
    const name = productName();

    assert.equal(scanFileContent('docs/transition.md', name).length, 0);
    assert.equal(scanFileContent('examples/transition.md', name).length, 0);
    assert.equal(scanFileContent('python/ktx-sl/plans/brainstorm.md', name).length, 0);
    assert.equal(scanFileContent('python/ktx-sl/openspec/specs/semantic-layer/spec.md', name).length, 0);
  });

  it('allows product identifiers in test fixtures', () => {
    const name = lowerProductName();

    assert.equal(scanFileContent('packages/cli/test/setup.test.ts', `project: ${name}-dev`).length, 0);
    assert.equal(scanFileContent('packages/cli/test/context/ingest/importer.test.ts', `email: system@${name}.dev`).length, 0);
    assert.equal(scanFileContent('python/ktx-daemon/tests/test_package.py', `${name}-ktx`).length, 0);
  });

  it('allows public package identifiers in release packaging and managed runtime source', () => {
    const name = lowerProductName();

    assert.equal(scanFileContent('scripts/local-embeddings-runtime-smoke.mjs', `@${name}/ktx`).length, 0);
    assert.equal(scanFileContent('scripts/package-artifacts.test.mjs', `${name}-ktx`).length, 0);
    assert.equal(scanFileContent('scripts/public-npm-release-metadata.mjs', `@${name}/ktx`).length, 0);
    assert.equal(scanFileContent('scripts/semantic-release-config.cjs', `${name}-ktx-`).length, 0);
    assert.equal(scanFileContent('packages/cli/src/release-version.ts', `@${name}/ktx`).length, 0);
    assert.equal(scanFileContent('packages/cli/src/managed-python-runtime.ts', `${name}_ktx`).length, 0);
    assert.equal(scanFileContent('python/ktx-daemon/src/ktx_daemon/__init__.py', `${name}-ktx`).length, 0);
  });

  it('allows clean source files and clean runtime prompt assets', () => {
    assert.deepEqual(
      scanFileContent('packages/cli/src/context/index.ts', "export const packageName = 'ktx';"),
      [],
    );
    assert.deepEqual(
      scanFileContent('packages/cli/src/prompts/memory_agent_bundle_ingest_work_unit.md', 'Write output for KTX.'),
      [],
    );
  });

  it('rejects context-owned LLM provider construction outside llm modules', () => {
    const violations = [
      ...scanFileContent(
        'packages/cli/src/context/agent/local-llm-provider.ts',
        "import { createAnthropic } from '@ai-sdk/anthropic';",
      ),
      ...scanFileContent('packages/cli/src/context/scan/local-ai-gateway-enrichment.ts', "import { createGateway } from 'ai';"),
      ...scanFileContent('packages/cli/src/context/core/local-embedding-provider.ts', "import { embedMany } from 'ai';"),
    ];

    assert.deepEqual(
      violations.map((violation) => violation.kind),
      ['llm-boundary', 'llm-boundary', 'llm-boundary'],
    );
  });

  it('rejects concrete connector dialect imports from scan workflow and connector classes', () => {
    const violations = [
      ...scanFileContent(
        'packages/cli/src/context/scan/relationship-profiling.ts',
        "import { KtxPostgresDialect } from '../../connectors/postgres/dialect.js';",
      ),
      ...scanFileContent(
        'packages/cli/src/connectors/postgres/connector.ts',
        "import { KtxPostgresDialect } from './dialect.js';",
      ),
    ];

    assert.deepEqual(
      violations.map((violation) => violation.kind),
      ['dialect-boundary', 'dialect-boundary'],
    );
    assert.equal(
      violations[0]?.message,
      'Forbidden concrete connector dialect import; use getDialectForDriver() from context/connections/dialects.ts',
    );

    assert.deepEqual(
      scanFileContent(
        'packages/cli/src/context/connections/dialects.ts',
        "import { KtxPostgresDialect } from '../../connectors/postgres/dialect.js';",
      ),
      [],
    );
    assert.deepEqual(
      scanFileContent(
        'packages/cli/test/connectors/postgres/dialect.test.ts',
        "import { KtxPostgresDialect } from './dialect.js';",
      ),
      [],
    );
  });

  it('rejects old KTX LLM port declarations in context', () => {
    const violations = [
      ...scanFileContent('packages/cli/src/context/agent/agent-runner.service.ts', 'export interface LlmProviderPort {}'),
      ...scanFileContent('packages/cli/src/context/scan/types.ts', 'export interface KtxScanLlmPort {}'),
      ...scanFileContent('packages/cli/src/context/agent/gateway-llm-provider.ts', 'export function createGatewayLlmProvider() {}'),
    ];

    assert.deepEqual(
      violations.map((violation) => violation.kind),
      ['llm-boundary', 'llm-boundary', 'llm-boundary'],
    );
  });

  it('rejects getModelByName calls in context production source', () => {
    const violations = scanFileContent(
      'packages/cli/src/context/ingest/page-triage/page-triage.service.ts',
      "const model = this.deps.llmProvider.getModelByName('claude-sonnet-4-6');",
    );

    assert.equal(violations.length, 1);
    assert.equal(violations[0]?.kind, 'llm-boundary');
    assert.equal(
      violations[0]?.message,
      'Forbidden context getModelByName call; use getModel(role) inside context modules',
    );
  });

  it('allows role-driven getModel calls, test calls, and provider shape declarations', () => {
    assert.deepEqual(
      scanFileContent(
        'packages/cli/src/context/ingest/page-triage/page-triage.service.ts',
        "const model = this.deps.llmProvider.getModel('triage');",
      ),
      [],
    );

    assert.deepEqual(
      scanFileContent(
        'packages/cli/test/context/ingest/page-triage/page-triage.service.test.ts',
        "const model = this.deps.llmProvider.getModelByName('test-model');",
      ),
      [],
    );

    assert.deepEqual(
      scanFileContent(
        'packages/cli/src/context/scan/local-enrichment.ts',
        'return { getModel() { return model; }, getModelByName() { return model; } };',
      ),
      [],
    );
  });
});