feat: add server time to obsidian connect responses and enhance error handling

- Included server_time_utc in the connect response schema for better synchronization.
- Updated obsidian_connect function to set server_time_utc during connection handling.
- Enhanced integration tests to verify the presence of server_time_utc in responses.
- Improved connectivity status recovery in the sync engine for better error management.

surfsense_obsidian/src/sync-engine.ts

@@ -239,7 +239,10 @@ export class SyncEngine {
 	// ---- queue draining ---------------------------------------------------
 
 	async flushQueue(): Promise<void> {
-		if (this.deps.queue.size === 0) return;
+		if (this.deps.queue.size === 0) {
+			await this.recoverStatusIfNeeded();
+			return;
+		}
 		// Shared gate for every flush trigger so the first /sync can't race /connect.
 		if (!this.deps.getSettings().connectorId) {
 			const connected = await this.ensureConnected();
@@ -259,6 +262,31 @@ export class SyncEngine {
 		this.setStatus(this.queueStatusKind(), this.statusDetail());
 	}
 
+	/**
+	 * Lightweight status recovery path used after network-change signals.
+	 * Clears stale offline/auth/error only when connectivity/auth is explicitly re-validated.
+	 */
+	async recoverConnectivityStatus(): Promise<void> {
+		const settings = this.deps.getSettings();
+		if (!settings.apiToken) {
+			this.refreshStatus({ force: true });
+			return;
+		}
+		if (!settings.searchSpaceId) {
+			try {
+				const health = await this.deps.apiClient.health();
+				this.applyHealth(health);
+				this.refreshStatus({ force: true });
+			} catch (err) {
+				this.handleStartupError(err);
+			}
+			return;
+		}
+		const connected = await this.ensureConnected();
+		if (!connected) return;
+		this.refreshStatus({ force: true });
+	}
+
 	private async processBatch(batch: QueueItem[]): Promise<BatchResult> {
 		const settings = this.deps.getSettings();
 		const upserts = batch.filter((b): b is QueueItem & { op: "upsert" } => b.op === "upsert");
@@ -510,6 +538,7 @@ export class SyncEngine {
 	refreshStatus(opts: { force?: boolean } = {}): void {
 		if (!opts.force) {
 			const last = this.lastAppliedKind;
+			if (last === "syncing") return;
 			const isError =
 				last === "auth-error" || last === "offline" || last === "error";
 			const s = this.deps.getSettings();
@@ -523,6 +552,18 @@ export class SyncEngine {
 		this.setStatus("auth-error", message ?? "API token expired or invalid");
 	}
 
+	reportError(err: unknown): void {
+		if (err instanceof AuthError) {
+			this.reportAuthError(err.message);
+			return;
+		}
+		if (err instanceof TransientError) {
+			this.setStatus("offline", err.message);
+			return;
+		}
+		this.setStatus("error", (err as Error).message ?? "Unknown error");
+	}
+
 	private setStatus(kind: StatusKind, detail?: string): void {
 		const s = this.deps.getSettings();
 		if (!s.apiToken) {
@@ -601,6 +642,19 @@ export class SyncEngine {
 		this.setStatus(this.queueStatusKind(), `${prefix}: ${(err as Error).message}`);
 	}
 
+	private async recoverStatusIfNeeded(): Promise<void> {
+		if (!this.isRecoverableErrorState()) return;
+		await this.recoverConnectivityStatus();
+	}
+
+	private isRecoverableErrorState(): boolean {
+		return (
+			this.lastAppliedKind === "offline" ||
+			this.lastAppliedKind === "auth-error" ||
+			this.lastAppliedKind === "error"
+		);
+	}
+
 	// ---- predicates -------------------------------------------------------
 
 	private shouldTrack(file: TAbstractFile): boolean {