chore: cleanup dead code warnings and apply clippy fixes for v1.1.1

- Add #![allow(dead_code)] to deprecated tool modules (kept for
  backwards compatibility but not exposed in MCP tool list)
- Mark unused functions with #[allow(dead_code)] annotations
- Fix unused variable warnings (prefix with _)
- Apply clippy auto-fixes for redundant closures and derives
- Fix test to account for protocol version negotiation
- Reorganize tools/mod.rs to clarify active vs deprecated tools

Security review: LOW RISK - no critical vulnerabilities found
Dead code review: deprecated tools properly annotated

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Sam Valladares 2026-01-27 01:23:27 -06:00
parent bfa91474a6
commit e06dd3d69a
27 changed files with 104 additions and 119 deletions

View file

@ -1,28 +1,42 @@
//! MCP Tools
//!
//! Tool implementations for the Vestige MCP server.
//!
//! The unified tools (codebase_unified, intention_unified, memory_unified, search_unified)
//! are the primary API. The granular tools below are kept for backwards compatibility
//! but are not exposed in the MCP tool list.
pub mod codebase;
pub mod consolidate;
pub mod ingest;
pub mod intentions;
pub mod knowledge;
pub mod recall;
pub mod review;
pub mod search;
pub mod smart_ingest;
pub mod stats;
// Neuroscience-inspired tools
pub mod context;
pub mod memory_states;
pub mod tagging;
// Feedback / preference learning
pub mod feedback;
// Unified tools (consolidate multiple operations into single tools)
// Active unified tools
pub mod codebase_unified;
pub mod ingest;
pub mod intention_unified;
pub mod memory_unified;
pub mod search_unified;
pub mod smart_ingest;
// Deprecated tools - kept for internal backwards compatibility
// These modules are intentionally unused in the public API
#[allow(dead_code)]
pub mod codebase;
#[allow(dead_code)]
pub mod consolidate;
#[allow(dead_code)]
pub mod context;
#[allow(dead_code)]
pub mod feedback;
#[allow(dead_code)]
pub mod intentions;
#[allow(dead_code)]
pub mod knowledge;
#[allow(dead_code)]
pub mod memory_states;
#[allow(dead_code)]
pub mod recall;
#[allow(dead_code)]
pub mod review;
#[allow(dead_code)]
pub mod search;
#[allow(dead_code)]
pub mod stats;
#[allow(dead_code)]
pub mod tagging;