apunkt/vestige
1
0
Fork 0
mirror of https://github.com/samvallad33/vestige.git synced 2026-05-08 07:12:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: dream connection eviction uses composite score instead of FIFO

Browse source
This commit is contained in:
Matthias Queitsch 2026-04-13 19:15:31 +02:00
parent 1c924bf47c
commit df6d819add
No known key found for this signature in database
GPG key ID: FDC53CE3FE359E17
3 changed files with 58 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crates/vestige-mcp/src/dashboard/handlers.rs
View file

@ -539,17 +539,23 @@ pub async fn trigger_dream(
// Run dream through CognitiveEngine
let cog = cognitive.lock().await;
let pre_dream_count = cog.dreamer.get_connections().len();
// Capture start time before the dream — composite-score eviction in store_connections
// reorders the buffer, making positional slicing (pre_dream_count..) unreliable.
let dream_start = Utc::now();
let dream_result = cog.dreamer.dream(&dream_memories).await;
let insights = cog.dreamer.synthesize_insights(&dream_memories);
let all_connections = cog.dreamer.get_connections();
drop(cog);
// Persist new connections
let new_connections = &all_connections[pre_dream_count..];
// Filter by timestamp — same approach as dream.rs to avoid positional index issues.
let new_connections: Vec<&vestige_core::DiscoveredConnection> = all_connections
.iter()
.filter(|c| c.discovered_at >= dream_start)
.collect();
let mut connections_persisted = 0u64;
let now = Utc::now();
for conn in new_connections {
for conn in new_connections.iter() {
let link_type = match conn.connection_type {
vestige_core::DiscoveredConnectionType::Semantic => "semantic",
vestige_core::DiscoveredConnectionType::SharedConcept => "shared_concepts",

20
crates/vestige-mcp/src/tools/dream.rs
View file

@ -89,7 +89,12 @@ pub async fn execute(
}).collect();
let cog = cognitive.lock().await;
let pre_dream_count = cog.dreamer.get_connections().len();
// Capture start time before the dream so we can identify newly discovered
// connections by timestamp rather than by buffer position. This is robust
// against the composite-score eviction sort in store_connections, which
// reorders the buffer and makes positional slicing (pre_dream_count..)
// unreliable.
let dream_start = Utc::now();
let dream_result = cog.dreamer.dream(&dream_memories).await;
let insights = cog.dreamer.synthesize_insights(&dream_memories);
let all_connections = cog.dreamer.get_connections();
@ -115,12 +120,17 @@ pub async fn execute(
}
}
// v1.9.0: Persist only NEW connections from this dream (skip accumulated ones)
let new_connections = all_connections.get(pre_dream_count..).unwrap_or(&[]);
// Identify new connections from this dream by timestamp rather than buffer
// position — positional slicing is broken after composite-score eviction
// reorders the buffer.
let new_connections: Vec<&vestige_core::DiscoveredConnection> = all_connections
.iter()
.filter(|c| c.discovered_at >= dream_start)
.collect();
let mut connections_persisted = 0u64;
{
let now = Utc::now();
for conn in new_connections {
for conn in new_connections.iter() {
let link_type = match conn.connection_type {
vestige_core::DiscoveredConnectionType::Semantic => "semantic",
vestige_core::DiscoveredConnectionType::SharedConcept => "shared_concepts",
@ -162,7 +172,7 @@ pub async fn execute(
// Hydrate live cognitive engine with newly persisted connections
if connections_persisted > 0 {
let mut cog = cognitive.lock().await;
for conn in new_connections {
for conn in new_connections.iter() {
let link_type_enum = match conn.connection_type {
vestige_core::DiscoveredConnectionType::Semantic => LinkType::Semantic,
vestige_core::DiscoveredConnectionType::SharedConcept => LinkType::Semantic,