apunkt/vestige
1
0
Fork 0
mirror of https://github.com/samvallad33/vestige.git synced 2026-07-02 22:01:01 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor(cinema): canonical sprite center (positionNode = instancePos)

Browse source 
SpriteNodeMaterial.setupPositionView already rebuilds the billboard quad from
positionGeometry — the prior .add(positionLocal) double-counted it (harmless at
0.1 size). Bare center is required for the upcoming velocity-stretch streak
(scaleNode/rotationNode will drive the quad). Verified renders identically.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Sam Valladares 2026-06-22 13:53:52 -05:00
parent 12678596d5
commit d9fb791af6
1 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

15
apps/dashboard/src/lib/graph/cinema/storm.ts
View file

@ -43,7 +43,6 @@ import {
fract,
abs,
floor,
positionLocal,
smoothstep,
oneMinus,
cross,
@ -525,15 +524,15 @@ export class SemanticComputeStorm {
emissiveNode: unknown;
};
// CRITICAL: particle world position = per-instance GPU compute output
// (storage buffer, indexed by instanceIndex) PLUS the sprite's local quad
// vertex (positionLocal) so each billboard keeps its size while being
// translated to its computed position. Assigning the bare storage element
// to positionNode (without positionLocal) collapses every quad to a point
// at its instance origin — the bug the audit caught.
// CANONICAL SPRITE CENTER: positionNode is the sprite's CENTER only.
// SpriteNodeMaterial.setupPositionView already builds the billboard quad
// from positionGeometry.xy (scaled by scaleNode, rotated by rotationNode),
// so the previous `.add(positionLocal)` double-counted the quad (harmless at
// the 0.1 size, sub-pixel). Using the bare center is required for the
// velocity-stretch streak (scaleNode/rotationNode now drive the quad shape).
const phaseStore = storage(bufferPhase, 'float', this.count);
const instancePos = storage(bufferPos, 'vec3', this.count).element(instanceIndex);
mat.positionNode = instancePos.add(positionLocal);
mat.positionNode = instancePos;
// ── SHARED RAINBOW COLOR ──
// One Fn produces the pure iridescent color for a particle; we feed it to