diff --git a/.gitignore b/.gitignore index a7d7e02..1ce041f 100644 --- a/.gitignore +++ b/.gitignore @@ -122,3 +122,8 @@ credentials.json # ============================================================================= **/.fastembed_cache/ .fastembed_cache/ + +# ============================================================================= +# External repos (forks, submodules) +# ============================================================================= +fastembed-rs/ diff --git a/CHANGELOG.md b/CHANGELOG.md index f33183d..5c03017 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,89 @@ All notable changes to Vestige will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [1.6.0] - 2026-02-19 + +### Changed +- **F16 vector quantization** — USearch vectors stored as F16 instead of F32 (2x storage savings) +- **Matryoshka 256-dim truncation** — embedding dimensions reduced from 768 to 256 (3x embedding storage savings) +- **Convex Combination fusion** — replaced RRF with 0.3 keyword / 0.7 semantic weighted fusion for better score preservation +- **Cross-encoder reranker** — added Jina Reranker v1 Turbo (fastembed TextRerank) for neural reranking (~20% retrieval quality improvement) +- Combined: **6x vector storage reduction** with better retrieval quality +- Cross-encoder loads in background — server starts instantly +- Old 768-dim embeddings auto-migrated on load + +--- + +## [1.5.0] - 2026-02-18 + +### Added +- **CognitiveEngine** — 28-module stateful engine with full neuroscience pipeline on every tool call +- **`dream`** tool — memory consolidation via replay, discovers hidden connections and synthesizes insights +- **`explore_connections`** tool — graph traversal with chain, associations, and bridges actions +- **`predict`** tool — proactive retrieval based on context and activity patterns +- **`restore`** tool — restore memories from JSON backup files +- **Automatic consolidation** — FSRS-6 decay runs on a 6-hour timer + inline every 100 tool calls +- ACT-R base-level activation with full access history +- Episodic-to-semantic auto-merge during consolidation +- Cross-memory reinforcement on access +- Park et al. triple retrieval scoring +- Personalized w20 optimization + +### Changed +- All existing tools upgraded with cognitive pre/post processing pipelines +- Tool count: 19 → 23 + +--- + +## [1.3.0] - 2026-02-12 + +### Added +- **`importance_score`** tool — 4-channel neuroscience scoring (novelty, arousal, reward, attention) +- **`session_checkpoint`** tool — batch smart_ingest up to 20 items with Prediction Error Gating +- **`find_duplicates`** tool — cosine similarity clustering with union-find for dedup +- `vestige ingest` CLI command for memory ingestion via command line + +### Changed +- Tool count: 16 → 19 +- Made `get_node_embedding` public in core API +- Added `get_all_embeddings` for duplicate scanning + +--- + +## [1.2.0] - 2026-02-12 + +### Added +- **Web dashboard** — Axum-based on port 3927 with memory browser, search, and system stats +- **`memory_timeline`** tool — browse memories chronologically, grouped by day +- **`memory_changelog`** tool — audit trail of memory state transitions +- **`health_check`** tool — system health status with recommendations +- **`consolidate`** tool — run FSRS-6 maintenance cycle +- **`stats`** tool — full memory system statistics +- **`backup`** tool — create SQLite database backups +- **`export`** tool — export memories as JSON/JSONL with filters +- **`gc`** tool — garbage collect low-retention memories +- `backup_to()` and `get_recent_state_transitions()` storage APIs + +### Changed +- Search now supports `detail_level` (brief/summary/full) to control token usage +- Tool count: 8 → 16 + +--- + +## [1.1.3] - 2026-02-12 + +### Changed +- Upgraded to Rust edition 2024 +- Security hardening and dependency updates + +### Fixed +- Dedup on ingest edge cases +- Intel Mac CI builds +- NPM package version alignment +- Removed dead TypeScript package + +--- + ## [1.1.2] - 2025-01-27 ### Fixed @@ -87,7 +170,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - SIGSEGV crash in vector index (reserve before add) - Memory safety with Mutex wrapper for embedding model -## [0.1.0] - 2026-01-24 +--- + +## [0.1.0] - 2025-01-24 ### Added - Initial release diff --git a/Cargo.toml b/Cargo.toml index 92c981b..87f980a 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -5,6 +5,9 @@ members = [ "crates/vestige-mcp", "tests/e2e", ] +exclude = [ + "fastembed-rs", +] [workspace.package] version = "1.6.0" diff --git a/LICENSE b/LICENSE index 0c4443c..be3f7b2 100644 --- a/LICENSE +++ b/LICENSE @@ -1,14 +1,661 @@ -Licensed under either of + GNU AFFERO GENERAL PUBLIC LICENSE + Version 3, 19 November 2007 - * Apache License, Version 2.0 - ([LICENSE-APACHE](LICENSE-APACHE) or http://www.apache.org/licenses/LICENSE-2.0) - * MIT license - ([LICENSE-MIT](LICENSE-MIT) or http://opensource.org/licenses/MIT) + Copyright (C) 2007 Free Software Foundation, Inc. + Everyone is permitted to copy and distribute verbatim copies + of this license document, but changing it is not allowed. -at your option. + Preamble -## Contribution + The GNU Affero General Public License is a free, copyleft license for +software and other kinds of works, specifically designed to ensure +cooperation with the community in the case of network server software. -Unless you explicitly state otherwise, any contribution intentionally submitted -for inclusion in the work by you, as defined in the Apache-2.0 license, shall be -dual licensed as above, without any additional terms or conditions. + The licenses for most software and other practical works are designed +to take away your freedom to share and change the works. By contrast, +our General Public Licenses are intended to guarantee your freedom to +share and change all versions of a program--to make sure it remains free +software for all its users. + + When we speak of free software, we are referring to freedom, not +price. Our General Public Licenses are designed to make sure that you +have the freedom to distribute copies of free software (and charge for +them if you wish), that you receive source code or can get it if you +want it, that you can change the software or use pieces of it in new +free programs, and that you know you can do these things. + + Developers that use our General Public Licenses protect your rights +with two steps: (1) assert copyright on the software, and (2) offer +you this License which gives you legal permission to copy, distribute +and/or modify the software. + + A secondary benefit of defending all users' freedom is that +improvements made in alternate versions of the program, if they +receive widespread use, become available for other developers to +incorporate. Many developers of free software are heartened and +encouraged by the resulting cooperation. However, in the case of +software used on network servers, this result may fail to come about. +The GNU General Public License permits making a modified version and +letting the public access it on a server without ever releasing its +source code to the public. + + The GNU Affero General Public License is designed specifically to +ensure that, in such cases, the modified source code becomes available +to the community. It requires the operator of a network server to +provide the source code of the modified version running there to the +users of that server. Therefore, public use of a modified version, on +a publicly accessible server, gives the public access to the source +code of the modified version. + + An older license, called the Affero General Public License and +published by Affero, was designed to accomplish similar goals. This is +a different license, not a version of the Affero GPL, but Affero has +released a new version of the Affero GPL which permits relicensing under +this license. + + The precise terms and conditions for copying, distribution and +modification follow. + + TERMS AND CONDITIONS + + 0. Definitions. + + "This License" refers to version 3 of the GNU Affero General Public License. + + "Copyright" also means copyright-like laws that apply to other kinds of +works, such as semiconductor masks. + + "The Program" refers to any copyrightable work licensed under this +License. Each licensee is addressed as "you". "Licensees" and +"recipients" may be individuals or organizations. + + To "modify" a work means to copy from or adapt all or part of the work +in a fashion requiring copyright permission, other than the making of an +exact copy. The resulting work is called a "modified version" of the +earlier work or a work "based on" the earlier work. + + A "covered work" means either the unmodified Program or a work based +on the Program. + + To "propagate" a work means to do anything with it that, without +permission, would make you directly or secondarily liable for +infringement under applicable copyright law, except executing it on a +computer or modifying a private copy. Propagation includes copying, +distribution (with or without modification), making available to the +public, and in some countries other activities as well. + + To "convey" a work means any kind of propagation that enables other +parties to make or receive copies. Mere interaction with a user through +a computer network, with no transfer of a copy, is not conveying. + + An interactive user interface displays "Appropriate Legal Notices" +to the extent that it includes a convenient and prominently visible +feature that (1) displays an appropriate copyright notice, and (2) +tells the user that there is no warranty for the work (except to the +extent that warranties are provided), that licensees may convey the +work under this License, and how to view a copy of this License. If +the interface presents a list of user commands or options, such as a +menu, a prominent item in the list meets this criterion. + + 1. Source Code. + + The "source code" for a work means the preferred form of the work +for making modifications to it. "Object code" means any non-source +form of a work. + + A "Standard Interface" means an interface that either is an official +standard defined by a recognized standards body, or, in the case of +interfaces specified for a particular programming language, one that +is widely used among developers working in that language. + + The "System Libraries" of an executable work include anything, other +than the work as a whole, that (a) is included in the normal form of +packaging a Major Component, but which is not part of that Major +Component, and (b) serves only to enable use of the work with that +Major Component, or to implement a Standard Interface for which an +implementation is available to the public in source code form. A +"Major Component", in this context, means a major essential component +(kernel, window system, and so on) of the specific operating system +(if any) on which the executable work runs, or a compiler used to +produce the work, or an object code interpreter used to run it. + + The "Corresponding Source" for a work in object code form means all +the source code needed to generate, install, and (for an executable +work) run the object code and to modify the work, including scripts to +control those activities. However, it does not include the work's +System Libraries, or general-purpose tools or generally available free +programs which are used unmodified in performing those activities but +which are not part of the work. For example, Corresponding Source +includes interface definition files associated with source files for +the work, and the source code for shared libraries and dynamically +linked subprograms that the work is specifically designed to require, +such as by intimate data communication or control flow between those +subprograms and other parts of the work. + + The Corresponding Source need not include anything that users +can regenerate automatically from other parts of the Corresponding +Source. + + The Corresponding Source for a work in source code form is that +same work. + + 2. Basic Permissions. + + All rights granted under this License are granted for the term of +copyright on the Program, and are irrevocable provided the stated +conditions are met. This License explicitly affirms your unlimited +permission to run the unmodified Program. The output from running a +covered work is covered by this License only if the output, given its +content, constitutes a covered work. This License acknowledges your +rights of fair use or other equivalent, as provided by copyright law. + + You may make, run and propagate covered works that you do not +convey, without conditions so long as your license otherwise remains +in force. You may convey covered works to others for the sole purpose +of having them make modifications exclusively for you, or provide you +with facilities for running those works, provided that you comply with +the terms of this License in conveying all material for which you do +not control copyright. Those thus making or running the covered works +for you must do so exclusively on your behalf, under your direction +and control, on terms that prohibit them from making any copies of +your copyrighted material outside their relationship with you. + + Conveying under any other circumstances is permitted solely under +the conditions stated below. Sublicensing is not allowed; section 10 +makes it unnecessary. + + 3. Protecting Users' Legal Rights From Anti-Circumvention Law. + + No covered work shall be deemed part of an effective technological +measure under any applicable law fulfilling obligations under article +11 of the WIPO copyright treaty adopted on 20 December 1996, or +similar laws prohibiting or restricting circumvention of such +measures. + + When you convey a covered work, you waive any legal power to forbid +circumvention of technological measures to the extent such circumvention +is effected by exercising rights under this License with respect to +the covered work, and you disclaim any intention to limit operation or +modification of the work as a means of enforcing, against the work's +users, your or third parties' legal rights to forbid circumvention of +technological measures. + + 4. Conveying Verbatim Copies. + + You may convey verbatim copies of the Program's source code as you +receive it, in any medium, provided that you conspicuously and +appropriately publish on each copy an appropriate copyright notice; +keep intact all notices stating that this License and any +non-permissive terms added in accord with section 7 apply to the code; +keep intact all notices of the absence of any warranty; and give all +recipients a copy of this License along with the Program. + + You may charge any price or no price for each copy that you convey, +and you may offer support or warranty protection for a fee. + + 5. Conveying Modified Source Versions. + + You may convey a work based on the Program, or the modifications to +produce it from the Program, in the form of source code under the +terms of section 4, provided that you also meet all of these conditions: + + a) The work must carry prominent notices stating that you modified + it, and giving a relevant date. + + b) The work must carry prominent notices stating that it is + released under this License and any conditions added under section + 7. This requirement modifies the requirement in section 4 to + "keep intact all notices". + + c) You must license the entire work, as a whole, under this + License to anyone who comes into possession of a copy. This + License will therefore apply, along with any applicable section 7 + additional terms, to the whole of the work, and all its parts, + regardless of how they are packaged. This License gives no + permission to license the work in any other way, but it does not + invalidate such permission if you have separately received it. + + d) If the work has interactive user interfaces, each must display + Appropriate Legal Notices; however, if the Program has interactive + interfaces that do not display Appropriate Legal Notices, your + work need not make them do so. + + A compilation of a covered work with other separate and independent +works, which are not by their nature extensions of the covered work, +and which are not combined with it such as to form a larger program, +in or on a volume of a storage or distribution medium, is called an +"aggregate" if the compilation and its resulting copyright are not +used to limit the access or legal rights of the compilation's users +beyond what the individual works permit. Inclusion of a covered work +in an aggregate does not cause this License to apply to the other +parts of the aggregate. + + 6. Conveying Non-Source Forms. + + You may convey a covered work in object code form under the terms +of sections 4 and 5, provided that you also convey the +machine-readable Corresponding Source under the terms of this License, +in one of these ways: + + a) Convey the object code in, or embodied in, a physical product + (including a physical distribution medium), accompanied by the + Corresponding Source fixed on a durable physical medium + customarily used for software interchange. + + b) Convey the object code in, or embodied in, a physical product + (including a physical distribution medium), accompanied by a + written offer, valid for at least three years and valid for as + long as you offer spare parts or customer support for that product + model, to give anyone who possesses the object code either (1) a + copy of the Corresponding Source for all the software in the + product that is covered by this License, on a durable physical + medium customarily used for software interchange, for a price no + more than your reasonable cost of physically performing this + conveying of source, or (2) access to copy the + Corresponding Source from a network server at no charge. + + c) Convey individual copies of the object code with a copy of the + written offer to provide the Corresponding Source. This + alternative is allowed only occasionally and noncommercially, and + only if you received the object code with such an offer, in accord + with subsection 6b. + + d) Convey the object code by offering access from a designated + place (gratis or for a charge), and offer equivalent access to the + Corresponding Source in the same way through the same place at no + further charge. You need not require recipients to copy the + Corresponding Source along with the object code. If the place to + copy the object code is a network server, the Corresponding Source + may be on a different server (operated by you or a third party) + that supports equivalent copying facilities, provided you maintain + clear directions next to the object code saying where to find the + Corresponding Source. Regardless of what server hosts the + Corresponding Source, you remain obligated to ensure that it is + available for as long as needed to satisfy these requirements. + + e) Convey the object code using peer-to-peer transmission, provided + you inform other peers where the object code and Corresponding + Source of the work are being offered to the general public at no + charge under subsection 6d. + + A separable portion of the object code, whose source code is excluded +from the Corresponding Source as a System Library, need not be +included in conveying the object code work. + + A "User Product" is either (1) a "consumer product", which means any +tangible personal property which is normally used for personal, family, +or household purposes, or (2) anything designed or sold for incorporation +into a dwelling. In determining whether a product is a consumer product, +doubtful cases shall be resolved in favor of coverage. For a particular +product received by a particular user, "normally used" refers to a +typical or common use of that class of product, regardless of the status +of the particular user or of the way in which the particular user +actually uses, or expects or is expected to use, the product. A product +is a consumer product regardless of whether the product has substantial +commercial, industrial or non-consumer uses, unless such uses represent +the only significant mode of use of the product. + + "Installation Information" for a User Product means any methods, +procedures, authorization keys, or other information required to install +and execute modified versions of a covered work in that User Product from +a modified version of its Corresponding Source. The information must +suffice to ensure that the continued functioning of the modified object +code is in no case prevented or interfered with solely because +modification has been made. + + If you convey an object code work under this section in, or with, or +specifically for use in, a User Product, and the conveying occurs as +part of a transaction in which the right of possession and use of the +User Product is transferred to the recipient in perpetuity or for a +fixed term (regardless of how the transaction is characterized), the +Corresponding Source conveyed under this section must be accompanied +by the Installation Information. But this requirement does not apply +if neither you nor any third party retains the ability to install +modified object code on the User Product (for example, the work has +been installed in ROM). + + The requirement to provide Installation Information does not include a +requirement to continue to provide support service, warranty, or updates +for a work that has been modified or installed by the recipient, or for +the User Product in which it has been modified or installed. Access to a +network may be denied when the modification itself materially and +adversely affects the operation of the network or violates the rules and +protocols for communication across the network. + + Corresponding Source conveyed, and Installation Information provided, +in accord with this section must be in a format that is publicly +documented (and with an implementation available to the public in +source code form), and must require no special password or key for +unpacking, reading or copying. + + 7. Additional Terms. + + "Additional permissions" are terms that supplement the terms of this +License by making exceptions from one or more of its conditions. +Additional permissions that are applicable to the entire Program shall +be treated as though they were included in this License, to the extent +that they are valid under applicable law. If additional permissions +apply only to part of the Program, that part may be used separately +under those permissions, but the entire Program remains governed by +this License without regard to the additional permissions. + + When you convey a copy of a covered work, you may at your option +remove any additional permissions from that copy, or from any part of +it. (Additional permissions may be written to require their own +removal in certain cases when you modify the work.) You may place +additional permissions on material, added by you to a covered work, +for which you have or can give appropriate copyright permission. + + Notwithstanding any other provision of this License, for material you +add to a covered work, you may (if authorized by the copyright holders of +that material) supplement the terms of this License with terms: + + a) Disclaiming warranty or limiting liability differently from the + terms of sections 15 and 16 of this License; or + + b) Requiring preservation of specified reasonable legal notices or + author attributions in that material or in the Appropriate Legal + Notices displayed by works containing it; or + + c) Prohibiting misrepresentation of the origin of that material, or + requiring that modified versions of such material be marked in + reasonable ways as different from the original version; or + + d) Limiting the use for publicity purposes of names of licensors or + authors of the material; or + + e) Declining to grant rights under trademark law for use of some + trade names, trademarks, or service marks; or + + f) Requiring indemnification of licensors and authors of that + material by anyone who conveys the material (or modified versions of + it) with contractual assumptions of liability to the recipient, for + any liability that these contractual assumptions directly impose on + those licensors and authors. + + All other non-permissive additional terms are considered "further +restrictions" within the meaning of section 10. If the Program as you +received it, or any part of it, contains a notice stating that it is +governed by this License along with a term that is a further +restriction, you may remove that term. If a license document contains +a further restriction but permits relicensing or conveying under this +License, you may add to a covered work material governed by the terms +of that license document, provided that the further restriction does +not survive such relicensing or conveying. + + If you add terms to a covered work in accord with this section, you +must place, in the relevant source files, a statement of the +additional terms that apply to those files, or a notice indicating +where to find the applicable terms. + + Additional terms, permissive or non-permissive, may be stated in the +form of a separately written license, or stated as exceptions; +the above requirements apply either way. + + 8. Termination. + + You may not propagate or modify a covered work except as expressly +provided under this License. Any attempt otherwise to propagate or +modify it is void, and will automatically terminate your rights under +this License (including any patent licenses granted under the third +paragraph of section 11). + + However, if you cease all violation of this License, then your +license from a particular copyright holder is reinstated (a) +provisionally, unless and until the copyright holder explicitly and +finally terminates your license, and (b) permanently, if the copyright +holder fails to notify you of the violation by some reasonable means +prior to 60 days after the cessation. + + Moreover, your license from a particular copyright holder is +reinstated permanently if the copyright holder notifies you of the +violation by some reasonable means, this is the first time you have +received notice of violation of this License (for any work) from that +copyright holder, and you cure the violation prior to 30 days after +your receipt of the notice. + + Termination of your rights under this section does not terminate the +licenses of parties who have received copies or rights from you under +this License. If your rights have been terminated and not permanently +reinstated, you do not qualify to receive new licenses for the same +material under section 10. + + 9. Acceptance Not Required for Having Copies. + + You are not required to accept this License in order to receive or +run a copy of the Program. Ancillary propagation of a covered work +occurring solely as a consequence of using peer-to-peer transmission +to receive a copy likewise does not require acceptance. However, +nothing other than this License grants you permission to propagate or +modify any covered work. These actions infringe copyright if you do +not accept this License. Therefore, by modifying or propagating a +covered work, you indicate your acceptance of this License to do so. + + 10. Automatic Licensing of Downstream Recipients. + + Each time you convey a covered work, the recipient automatically +receives a license from the original licensors, to run, modify and +propagate that work, subject to this License. You are not responsible +for enforcing compliance by third parties with this License. + + An "entity transaction" is a transaction transferring control of an +organization, or substantially all assets of one, or subdividing an +organization, or merging organizations. If propagation of a covered +work results from an entity transaction, each party to that +transaction who receives a copy of the work also receives whatever +licenses to the work the party's predecessor in interest had or could +give under the previous paragraph, plus a right to possession of the +Corresponding Source of the work from the predecessor in interest, if +the predecessor has it or can get it with reasonable efforts. + + You may not impose any further restrictions on the exercise of the +rights granted or affirmed under this License. For example, you may +not impose a license fee, royalty, or other charge for exercise of +rights granted under this License, and you may not initiate litigation +(including a cross-claim or counterclaim in a lawsuit) alleging that +any patent claim is infringed by making, using, selling, offering for +sale, or importing the Program or any portion of it. + + 11. Patents. + + A "contributor" is a copyright holder who authorizes use under this +License of the Program or a work on which the Program is based. The +work thus licensed is called the contributor's "contributor version". + + A contributor's "essential patent claims" are all patent claims +owned or controlled by the contributor, whether already acquired or +hereafter acquired, that would be infringed by some manner, permitted +by this License, of making, using, or selling its contributor version, +but do not include claims that would be infringed only as a +consequence of further modification of the contributor version. For +purposes of this definition, "control" includes the right to grant +patent sublicenses in a manner consistent with the requirements of +this License. + + Each contributor grants you a non-exclusive, worldwide, royalty-free +patent license under the contributor's essential patent claims, to +make, use, sell, offer for sale, import and otherwise run, modify and +propagate the contents of its contributor version. + + In the following three paragraphs, a "patent license" is any express +agreement or commitment, however denominated, not to enforce a patent +(such as an express permission to practice a patent or covenant not to +sue for patent infringement). To "grant" such a patent license to a +party means to make such an agreement or commitment not to enforce a +patent against the party. + + If you convey a covered work, knowingly relying on a patent license, +and the Corresponding Source of the work is not available for anyone +to copy, free of charge and under the terms of this License, through a +publicly available network server or other readily accessible means, +then you must either (1) cause the Corresponding Source to be so +available, or (2) arrange to deprive yourself of the benefit of the +patent license for this particular work, or (3) arrange, in a manner +consistent with the requirements of this License, to extend the patent +license to downstream recipients. "Knowingly relying" means you have +actual knowledge that, but for the patent license, your conveying the +covered work in a country, or your recipient's use of the covered work +in a country, would infringe one or more identifiable patents in that +country that you have reason to believe are valid. + + If, pursuant to or in connection with a single transaction or +arrangement, you convey, or propagate by procuring conveyance of, a +covered work, and grant a patent license to some of the parties +receiving the covered work authorizing them to use, propagate, modify +or convey a specific copy of the covered work, then the patent license +you grant is automatically extended to all recipients of the covered +work and works based on it. + + A patent license is "discriminatory" if it does not include within +the scope of its coverage, prohibits the exercise of, or is +conditioned on the non-exercise of one or more of the rights that are +specifically granted under this License. You may not convey a covered +work if you are a party to an arrangement with a third party that is +in the business of distributing software, under which you make payment +to the third party based on the extent of your activity of conveying +the work, and under which the third party grants, to any of the +parties who would receive the covered work from you, a discriminatory +patent license (a) in connection with copies of the covered work +conveyed by you (or copies made from those copies), or (b) primarily +for and in connection with specific products or compilations that +contain the covered work, unless you entered into that arrangement, +or that patent license was granted, prior to 28 March 2007. + + Nothing in this License shall be construed as excluding or limiting +any implied license or other defenses to infringement that may +otherwise be available to you under applicable patent law. + + 12. No Surrender of Others' Freedom. + + If conditions are imposed on you (whether by court order, agreement or +otherwise) that contradict the conditions of this License, they do not +excuse you from the conditions of this License. If you cannot convey a +covered work so as to satisfy simultaneously your obligations under this +License and any other pertinent obligations, then as a consequence you may +not convey it at all. For example, if you agree to terms that obligate you +to collect a royalty for further conveying from those to whom you convey +the Program, the only way you could satisfy both those terms and this +License would be to refrain entirely from conveying the Program. + + 13. Remote Network Interaction; Use with the GNU General Public License. + + Notwithstanding any other provision of this License, if you modify the +Program, your modified version must prominently offer all users +interacting with it remotely through a computer network (if your version +supports such interaction) an opportunity to receive the Corresponding +Source of your version by providing access to the Corresponding Source +from a network server at no charge, through some standard or customary +means of facilitating copying of software. This Corresponding Source +shall include the Corresponding Source for any work covered by version 3 +of the GNU General Public License that is incorporated pursuant to the +following paragraph. + + Notwithstanding any other provision of this License, you have +permission to link or combine any covered work with a work licensed +under version 3 of the GNU General Public License into a single +combined work, and to convey the resulting work. The terms of this +License will continue to apply to the part which is the covered work, +but the work with which it is combined will remain governed by version +3 of the GNU General Public License. + + 14. Revised Versions of this License. + + The Free Software Foundation may publish revised and/or new versions of +the GNU Affero General Public License from time to time. Such new versions +will be similar in spirit to the present version, but may differ in detail to +address new problems or concerns. + + Each version is given a distinguishing version number. If the +Program specifies that a certain numbered version of the GNU Affero General +Public License "or any later version" applies to it, you have the +option of following the terms and conditions either of that numbered +version or of any later version published by the Free Software +Foundation. If the Program does not specify a version number of the +GNU Affero General Public License, you may choose any version ever published +by the Free Software Foundation. + + If the Program specifies that a proxy can decide which future +versions of the GNU Affero General Public License can be used, that proxy's +public statement of acceptance of a version permanently authorizes you +to choose that version for the Program. + + Later license versions may give you additional or different +permissions. However, no additional obligations are imposed on any +author or copyright holder as a result of your choosing to follow a +later version. + + 15. Disclaimer of Warranty. + + THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY +APPLICABLE LAW. EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT +HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY +OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, +THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR +PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM +IS WITH YOU. SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF +ALL NECESSARY SERVICING, REPAIR OR CORRECTION. + + 16. Limitation of Liability. + + IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING +WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS +THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY +GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE +USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF +DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD +PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS), +EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF +SUCH DAMAGES. + + 17. Interpretation of Sections 15 and 16. + + If the disclaimer of warranty and limitation of liability provided +above cannot be given local legal effect according to their terms, +reviewing courts shall apply local law that most closely approximates +an absolute waiver of all civil liability in connection with the +Program, unless a warranty or assumption of liability accompanies a +copy of the Program in return for a fee. + + END OF TERMS AND CONDITIONS + + How to Apply These Terms to Your New Programs + + If you develop a new program, and you want it to be of the greatest +possible use to the public, the best way to achieve this is to make it +free software which everyone can redistribute and change under these terms. + + To do so, attach the following notices to the program. It is safest +to attach them to the start of each source file to most effectively +state the exclusion of warranty; and each file should have at least +the "copyright" line and a pointer to where the full notice is found. + + + Copyright (C) + + This program is free software: you can redistribute it and/or modify + it under the terms of the GNU Affero General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU Affero General Public License for more details. + + You should have received a copy of the GNU Affero General Public License + along with this program. If not, see . + +Also add information on how to contact you by electronic and paper mail. + + If your software can interact with users remotely through a computer +network, you should also make sure that it provides a way for users to +get its source. For example, if your program is a web application, its +interface could display a "Source" link that leads users to an archive +of the code. There are many ways you could offer source, and different +solutions will be better for different programs; see section 13 for the +specific requirements. + + You should also get your employer (if you work as a programmer) or school, +if any, to sign a "copyright disclaimer" for the program, if necessary. +For more information on this, and how to apply and follow the GNU AGPL, see +. diff --git a/LICENSE-APACHE b/LICENSE-APACHE deleted file mode 100644 index 8c25275..0000000 --- a/LICENSE-APACHE +++ /dev/null @@ -1,190 +0,0 @@ - Apache License - Version 2.0, January 2004 - http://www.apache.org/licenses/ - -TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION - -1. Definitions. - - "License" shall mean the terms and conditions for use, reproduction, - and distribution as defined by Sections 1 through 9 of this document. - - "Licensor" shall mean the copyright owner or entity authorized by - the copyright owner that is granting the License. - - "Legal Entity" shall mean the union of the acting entity and all - other entities that control, are controlled by, or are under common - control with that entity. For the purposes of this definition, - "control" means (i) the power, direct or indirect, to cause the - direction or management of such entity, whether by contract or - otherwise, or (ii) ownership of fifty percent (50%) or more of the - outstanding shares, or (iii) beneficial ownership of such entity. - - "You" (or "Your") shall mean an individual or Legal Entity - exercising permissions granted by this License. - - "Source" form shall mean the preferred form for making modifications, - including but not limited to software source code, documentation - source, and configuration files. - - "Object" form shall mean any form resulting from mechanical - transformation or translation of a Source form, including but - not limited to compiled object code, generated documentation, - and conversions to other media types. - - "Work" shall mean the work of authorship, whether in Source or - Object form, made available under the License, as indicated by a - copyright notice that is included in or attached to the work - (an example is provided in the Appendix below). - - "Derivative Works" shall mean any work, whether in Source or Object - form, that is based on (or derived from) the Work and for which the - editorial revisions, annotations, elaborations, or other modifications - represent, as a whole, an original work of authorship. For the purposes - of this License, Derivative Works shall not include works that remain - separable from, or merely link (or bind by name) to the interfaces of, - the Work and Derivative Works thereof. - - "Contribution" shall mean any work of authorship, including - the original version of the Work and any modifications or additions - to that Work or Derivative Works thereof, that is intentionally - submitted to the Licensor for inclusion in the Work by the copyright owner - or by an individual or Legal Entity authorized to submit on behalf of - the copyright owner. For the purposes of this definition, "submitted" - means any form of electronic, verbal, or written communication sent - to the Licensor or its representatives, including but not limited to - communication on electronic mailing lists, source code control systems, - and issue tracking systems that are managed by, or on behalf of, the - Licensor for the purpose of discussing and improving the Work, but - excluding communication that is conspicuously marked or otherwise - designated in writing by the copyright owner as "Not a Contribution." - - "Contributor" shall mean Licensor and any individual or Legal Entity - on behalf of whom a Contribution has been received by Licensor and - subsequently incorporated within the Work. - -2. Grant of Copyright License. Subject to the terms and conditions of - this License, each Contributor hereby grants to You a perpetual, - worldwide, non-exclusive, no-charge, royalty-free, irrevocable - copyright license to reproduce, prepare Derivative Works of, - publicly display, publicly perform, sublicense, and distribute the - Work and such Derivative Works in Source or Object form. - -3. Grant of Patent License. Subject to the terms and conditions of - this License, each Contributor hereby grants to You a perpetual, - worldwide, non-exclusive, no-charge, royalty-free, irrevocable - (except as stated in this section) patent license to make, have made, - use, offer to sell, sell, import, and otherwise transfer the Work, - where such license applies only to those patent claims licensable - by such Contributor that are necessarily infringed by their - Contribution(s) alone or by combination of their Contribution(s) - with the Work to which such Contribution(s) was submitted. If You - institute patent litigation against any entity (including a - cross-claim or counterclaim in a lawsuit) alleging that the Work - or a Contribution incorporated within the Work constitutes direct - or contributory patent infringement, then any patent licenses - granted to You under this License for that Work shall terminate - as of the date such litigation is filed. - -4. Redistribution. You may reproduce and distribute copies of the - Work or Derivative Works thereof in any medium, with or without - modifications, and in Source or Object form, provided that You - meet the following conditions: - - (a) You must give any other recipients of the Work or - Derivative Works a copy of this License; and - - (b) You must cause any modified files to carry prominent notices - stating that You changed the files; and - - (c) You must retain, in the Source form of any Derivative Works - that You distribute, all copyright, patent, trademark, and - attribution notices from the Source form of the Work, - excluding those notices that do not pertain to any part of - the Derivative Works; and - - (d) If the Work includes a "NOTICE" text file as part of its - distribution, then any Derivative Works that You distribute must - include a readable copy of the attribution notices contained - within such NOTICE file, excluding those notices that do not - pertain to any part of the Derivative Works, in at least one - of the following places: within a NOTICE text file distributed - as part of the Derivative Works; within the Source form or - documentation, if provided along with the Derivative Works; or, - within a display generated by the Derivative Works, if and - wherever such third-party notices normally appear. The contents - of the NOTICE file are for informational purposes only and - do not modify the License. You may add Your own attribution - notices within Derivative Works that You distribute, alongside - or as an addendum to the NOTICE text from the Work, provided - that such additional attribution notices cannot be construed - as modifying the License. - - You may add Your own copyright statement to Your modifications and - may provide additional or different license terms and conditions - for use, reproduction, or distribution of Your modifications, or - for any such Derivative Works as a whole, provided Your use, - reproduction, and distribution of the Work otherwise complies with - the conditions stated in this License. - -5. Submission of Contributions. Unless You explicitly state otherwise, - any Contribution intentionally submitted for inclusion in the Work - by You to the Licensor shall be under the terms and conditions of - this License, without any additional terms or conditions. - Notwithstanding the above, nothing herein shall supersede or modify - the terms of any separate license agreement you may have executed - with Licensor regarding such Contributions. - -6. Trademarks. This License does not grant permission to use the trade - names, trademarks, service marks, or product names of the Licensor, - except as required for reasonable and customary use in describing the - origin of the Work and reproducing the content of the NOTICE file. - -7. Disclaimer of Warranty. Unless required by applicable law or - agreed to in writing, Licensor provides the Work (and each - Contributor provides its Contributions) on an "AS IS" BASIS, - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or - implied, including, without limitation, any warranties or conditions - of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A - PARTICULAR PURPOSE. You are solely responsible for determining the - appropriateness of using or redistributing the Work and assume any - risks associated with Your exercise of permissions under this License. - -8. Limitation of Liability. In no event and under no legal theory, - whether in tort (including negligence), contract, or otherwise, - unless required by applicable law (such as deliberate and grossly - negligent acts) or agreed to in writing, shall any Contributor be - liable to You for damages, including any direct, indirect, special, - incidental, or consequential damages of any character arising as a - result of this License or out of the use or inability to use the - Work (including but not limited to damages for loss of goodwill, - work stoppage, computer failure or malfunction, or any and all - other commercial damages or losses), even if such Contributor - has been advised of the possibility of such damages. - -9. Accepting Warranty or Additional Liability. While redistributing - the Work or Derivative Works thereof, You may choose to offer, - and charge a fee for, acceptance of support, warranty, indemnity, - or other liability obligations and/or rights consistent with this - License. However, in accepting such obligations, You may act only - on Your own behalf and on Your sole responsibility, not on behalf - of any other Contributor, and only if You agree to indemnify, - defend, and hold each Contributor harmless for any liability - incurred by, or claims asserted against, such Contributor by reason - of your accepting any such warranty or additional liability. - -END OF TERMS AND CONDITIONS - -Copyright 2024-2026 Engram Contributors - -Licensed under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software -distributed under the License is distributed on an "AS IS" BASIS, -WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific language governing permissions and -limitations under the License. diff --git a/LICENSE-MIT b/LICENSE-MIT deleted file mode 100644 index bb22687..0000000 --- a/LICENSE-MIT +++ /dev/null @@ -1,21 +0,0 @@ -MIT License - -Copyright (c) 2024-2026 Engram Contributors - -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. diff --git a/README.md b/README.md index a8f1f2d..496406f 100644 --- a/README.md +++ b/README.md @@ -9,6 +9,15 @@ > Your AI forgets everything between sessions. Vestige fixes that. Built on 130 years of memory research — FSRS-6 spaced repetition, prediction error gating, synaptic tagging — all running in a single Rust binary, 100% local. +### What's New in v1.6.0 + +- **6x vector storage reduction** — F16 quantization + Matryoshka 256-dim truncation +- **Neural reranking** — Jina cross-encoder reranker for ~20% better retrieval +- **Instant startup** — cross-encoder loads in background, zero blocking +- **Auto-migration** — old 768-dim embeddings seamlessly upgraded + +See [CHANGELOG](CHANGELOG.md) for full version history. + --- ## Give Your AI a Brain in 30 Seconds @@ -196,7 +205,7 @@ vestige restore # Restore from backup ## Technical Details -- **Language:** Rust (46,000+ lines) +- **Language:** Rust (52,000+ lines, 1,100+ tests) - **Binary size:** ~20MB - **Embeddings:** Nomic Embed Text v1.5 (768-dim, local ONNX inference via fastembed) - **Vector search:** USearch HNSW (20x faster than FAISS) diff --git a/crates/vestige-core/Cargo.toml b/crates/vestige-core/Cargo.toml index 59e486f..dd6703e 100644 --- a/crates/vestige-core/Cargo.toml +++ b/crates/vestige-core/Cargo.toml @@ -5,7 +5,7 @@ edition = "2024" rust-version = "1.85" authors = ["Vestige Team"] description = "Cognitive memory engine - FSRS-6 spaced repetition, semantic embeddings, and temporal memory" -license = "MIT OR Apache-2.0" +license = "AGPL-3.0-only" repository = "https://github.com/samvallad33/vestige" keywords = ["memory", "spaced-repetition", "fsrs", "embeddings", "knowledge-graph"] categories = ["science", "database"] diff --git a/crates/vestige-core/src/advanced/intent.rs b/crates/vestige-core/src/advanced/intent.rs index 69bc51b..ec6c15b 100644 --- a/crates/vestige-core/src/advanced/intent.rs +++ b/crates/vestige-core/src/advanced/intent.rs @@ -402,6 +402,7 @@ pub struct IntentDetector { } /// A pattern that suggests a specific intent +#[allow(clippy::type_complexity)] struct IntentPattern { /// Name of the pattern name: String, diff --git a/crates/vestige-core/src/memory/mod.rs b/crates/vestige-core/src/memory/mod.rs index 0f228ab..0b5350e 100644 --- a/crates/vestige-core/src/memory/mod.rs +++ b/crates/vestige-core/src/memory/mod.rs @@ -216,8 +216,8 @@ impl KnowledgeEdge { /// Check if the edge was valid at a given time pub fn was_valid_at(&self, time: DateTime) -> bool { - let after_start = self.valid_from.map_or(true, |from| time >= from); - let before_end = self.valid_until.map_or(true, |until| time < until); + let after_start = self.valid_from.is_none_or(|from| time >= from); + let before_end = self.valid_until.is_none_or(|until| time < until); after_start && before_end } } diff --git a/crates/vestige-core/src/neuroscience/hippocampal_index.rs b/crates/vestige-core/src/neuroscience/hippocampal_index.rs index 6ccea36..afff1e3 100644 --- a/crates/vestige-core/src/neuroscience/hippocampal_index.rs +++ b/crates/vestige-core/src/neuroscience/hippocampal_index.rs @@ -1691,6 +1691,7 @@ impl HippocampalIndex { } /// Recursively collect associations + #[allow(clippy::only_used_in_recursion)] fn collect_associations( &self, indices: &HashMap, @@ -1874,6 +1875,7 @@ pub struct MigrationResult { impl HippocampalIndex { /// Migrate a KnowledgeNode to indexed format + #[allow(clippy::too_many_arguments)] pub fn migrate_node( &self, node_id: &str, diff --git a/crates/vestige-core/src/neuroscience/predictive_retrieval.rs b/crates/vestige-core/src/neuroscience/predictive_retrieval.rs index ff029cd..4bace7c 100644 --- a/crates/vestige-core/src/neuroscience/predictive_retrieval.rs +++ b/crates/vestige-core/src/neuroscience/predictive_retrieval.rs @@ -738,6 +738,7 @@ impl Default for PredictiveMemoryConfig { } /// The main predictive memory engine +#[allow(clippy::type_complexity)] pub struct PredictiveMemory { /// User behavior model user_model: Arc>, diff --git a/crates/vestige-core/src/neuroscience/prospective_memory.rs b/crates/vestige-core/src/neuroscience/prospective_memory.rs index 28917f3..0fe2dd6 100644 --- a/crates/vestige-core/src/neuroscience/prospective_memory.rs +++ b/crates/vestige-core/src/neuroscience/prospective_memory.rs @@ -1049,7 +1049,9 @@ impl IntentionParser { /// Extract content from text, removing trigger keywords fn extract_content(&self, _text_lower: &str, original: &str, keyword: &str) -> String { - let content = original + + + original .replace(keyword, "") .replace(&keyword.to_uppercase(), "") .replace("remind me to ", "") @@ -1057,9 +1059,7 @@ impl IntentionParser { .replace("remind me ", "") .replace("Remind me ", "") .trim() - .to_string(); - - content + .to_string() } /// Extract entity names from text diff --git a/crates/vestige-core/src/storage/sqlite.rs b/crates/vestige-core/src/storage/sqlite.rs index 4d9733a..ca53a4b 100644 --- a/crates/vestige-core/src/storage/sqlite.rs +++ b/crates/vestige-core/src/storage/sqlite.rs @@ -1890,7 +1890,7 @@ impl Storage { let all_embeddings = self.get_all_embeddings()?; let n = all_embeddings.len(); - if n < 2 || n > 2000 { + if !(2..=2000).contains(&n) { return Ok(0); } diff --git a/crates/vestige-mcp/Cargo.toml b/crates/vestige-mcp/Cargo.toml index a66cdef..5d827fb 100644 --- a/crates/vestige-mcp/Cargo.toml +++ b/crates/vestige-mcp/Cargo.toml @@ -4,7 +4,7 @@ version = "1.6.0" edition = "2024" description = "Cognitive memory MCP server for Claude - FSRS-6, spreading activation, synaptic tagging, and 130 years of memory research" authors = ["samvallad33"] -license = "MIT OR Apache-2.0" +license = "AGPL-3.0-only" keywords = ["mcp", "ai", "memory", "fsrs", "neuroscience", "cognitive-science", "spaced-repetition"] categories = ["command-line-utilities", "database"] repository = "https://github.com/samvallad33/vestige" diff --git a/crates/vestige-mcp/src/bin/cli.rs b/crates/vestige-mcp/src/bin/cli.rs index 15aa0e9..f3e6fea 100644 --- a/crates/vestige-mcp/src/bin/cli.rs +++ b/crates/vestige-mcp/src/bin/cli.rs @@ -561,11 +561,10 @@ fn run_backup(output: PathBuf) -> anyhow::Result<()> { } // Create parent directories if needed - if let Some(parent) = output.parent() { - if !parent.exists() { + if let Some(parent) = output.parent() + && !parent.exists() { std::fs::create_dir_all(parent)?; } - } // Copy the database file println!("Copying database..."); @@ -638,11 +637,10 @@ fn run_export( .iter() .filter(|node| { // Date filter - if let Some(ref since_dt) = since_date { - if node.created_at < *since_dt { + if let Some(ref since_dt) = since_date + && node.created_at < *since_dt { return false; } - } // Tag filter: node must contain ALL specified tags if !tag_filter.is_empty() { for tag in &tag_filter { @@ -671,11 +669,10 @@ fn run_export( println!(); // Create parent directories if needed - if let Some(parent) = output.parent() { - if !parent.exists() { + if let Some(parent) = output.parent() + && !parent.exists() { std::fs::create_dir_all(parent)?; } - } let file = std::fs::File::create(&output)?; let mut writer = BufWriter::new(file); diff --git a/crates/vestige-mcp/src/cognitive.rs b/crates/vestige-mcp/src/cognitive.rs index 34e04af..5db3e8c 100644 --- a/crates/vestige-mcp/src/cognitive.rs +++ b/crates/vestige-mcp/src/cognitive.rs @@ -61,10 +61,16 @@ pub struct CognitiveEngine { pub temporal_searcher: TemporalSearcher, } +impl Default for CognitiveEngine { + fn default() -> Self { + Self::new() + } +} + impl CognitiveEngine { /// Initialize all cognitive modules with default configurations. pub fn new() -> Self { - let engine = Self { + Self { // Neuroscience activation_network: ActivationNetwork::new(), synaptic_tagging: SynapticTaggingSystem::new(), @@ -98,8 +104,6 @@ impl CognitiveEngine { // Search reranker: Reranker::new(RerankerConfig::default()), temporal_searcher: TemporalSearcher::new(), - }; - - engine + } } } diff --git a/crates/vestige-mcp/src/server.rs b/crates/vestige-mcp/src/server.rs index 30ae1c6..18ffc60 100644 --- a/crates/vestige-mcp/src/server.rs +++ b/crates/vestige-mcp/src/server.rs @@ -87,7 +87,7 @@ impl McpServer { // Version negotiation: use client's version if older than server's // Claude Desktop rejects servers with newer protocol versions - let negotiated_version = if request.protocol_version < MCP_VERSION.to_string() { + let negotiated_version = if request.protocol_version.as_str() < MCP_VERSION { info!("Client requested older protocol version {}, using it", request.protocol_version); request.protocol_version.clone() } else { @@ -593,7 +593,7 @@ impl McpServer { let should_consolidate = self.cognitive.try_lock() .ok() .map(|cog| cog.consolidation_scheduler.should_consolidate()) - .unwrap_or(count % 100 == 0); // Fallback to count-based if lock unavailable + .unwrap_or(count.is_multiple_of(100)); // Fallback to count-based if lock unavailable if should_consolidate { let storage_clone = Arc::clone(&self.storage); diff --git a/crates/vestige-mcp/src/tools/codebase.rs b/crates/vestige-mcp/src/tools/codebase.rs index e31b6fd..3973ce9 100644 --- a/crates/vestige-mcp/src/tools/codebase.rs +++ b/crates/vestige-mcp/src/tools/codebase.rs @@ -1,4 +1,3 @@ -#![allow(dead_code)] //! Codebase Tools (Deprecated - use codebase_unified instead) //! //! Remember patterns, decisions, and context about codebases. @@ -131,12 +130,12 @@ pub async fn execute_pattern( // Build content with structured format let mut content = format!("# Code Pattern: {}\n\n{}", args.name, args.description); - if let Some(ref files) = args.files { - if !files.is_empty() { - content.push_str("\n\n## Files:\n"); - for f in files { - content.push_str(&format!("- {}\n", f)); - } + if let Some(ref files) = args.files + && !files.is_empty() + { + content.push_str("\n\n## Files:\n"); + for f in files { + content.push_str(&format!("- {}\n", f)); } } @@ -189,21 +188,21 @@ pub async fn execute_decision( args.decision ); - if let Some(ref alternatives) = args.alternatives { - if !alternatives.is_empty() { - content.push_str("\n\n## Alternatives Considered:\n"); - for alt in alternatives { - content.push_str(&format!("- {}\n", alt)); - } + if let Some(ref alternatives) = args.alternatives + && !alternatives.is_empty() + { + content.push_str("\n\n## Alternatives Considered:\n"); + for alt in alternatives { + content.push_str(&format!("- {}\n", alt)); } } - if let Some(ref files) = args.files { - if !files.is_empty() { - content.push_str("\n\n## Affected Files:\n"); - for f in files { - content.push_str(&format!("- {}\n", f)); - } + if let Some(ref files) = args.files + && !files.is_empty() + { + content.push_str("\n\n## Affected Files:\n"); + for f in files { + content.push_str(&format!("- {}\n", f)); } } @@ -239,7 +238,7 @@ pub async fn execute_context( args: Option, ) -> Result { let args: ContextArgs = args - .map(|v| serde_json::from_value(v)) + .map(serde_json::from_value) .transpose() .map_err(|e| format!("Invalid arguments: {}", e))? .unwrap_or(ContextArgs { diff --git a/crates/vestige-mcp/src/tools/codebase_unified.rs b/crates/vestige-mcp/src/tools/codebase_unified.rs index 88ef455..d0aa853 100644 --- a/crates/vestige-mcp/src/tools/codebase_unified.rs +++ b/crates/vestige-mcp/src/tools/codebase_unified.rs @@ -127,12 +127,12 @@ async fn execute_remember_pattern( // Build content with structured format let mut content = format!("# Code Pattern: {}\n\n{}", name, description); - if let Some(ref files) = args.files { - if !files.is_empty() { - content.push_str("\n\n## Files:\n"); - for f in files { - content.push_str(&format!("- {}\n", f)); - } + if let Some(ref files) = args.files + && !files.is_empty() + { + content.push_str("\n\n## Files:\n"); + for f in files { + content.push_str(&format!("- {}\n", f)); } } @@ -211,21 +211,21 @@ async fn execute_remember_decision( decision ); - if let Some(ref alternatives) = args.alternatives { - if !alternatives.is_empty() { - content.push_str("\n\n## Alternatives Considered:\n"); - for alt in alternatives { - content.push_str(&format!("- {}\n", alt)); - } + if let Some(ref alternatives) = args.alternatives + && !alternatives.is_empty() + { + content.push_str("\n\n## Alternatives Considered:\n"); + for alt in alternatives { + content.push_str(&format!("- {}\n", alt)); } } - if let Some(ref files) = args.files { - if !files.is_empty() { - content.push_str("\n\n## Affected Files:\n"); - for f in files { - content.push_str(&format!("- {}\n", f)); - } + if let Some(ref files) = args.files + && !files.is_empty() + { + content.push_str("\n\n## Affected Files:\n"); + for f in files { + content.push_str(&format!("- {}\n", f)); } } @@ -336,23 +336,23 @@ async fn execute_get_context( // COGNITIVE: Cross-project knowledge discovery // ==================================================================== let mut universal_patterns = Vec::new(); - if let Some(codebase_name) = &args.codebase { - if let Ok(cog) = cognitive.try_lock() { - let context = vestige_core::advanced::cross_project::ProjectContext { - path: None, - name: Some(codebase_name.clone()), - languages: Vec::new(), - frameworks: Vec::new(), - file_types: std::collections::HashSet::new(), - dependencies: Vec::new(), - structure: Vec::new(), - }; - let applicable = cog.cross_project.detect_applicable(&context); - for knowledge in applicable { - universal_patterns.push(serde_json::json!({ - "pattern": format!("{:?}", knowledge), - })); - } + if let Some(codebase_name) = &args.codebase + && let Ok(cog) = cognitive.try_lock() + { + let context = vestige_core::advanced::cross_project::ProjectContext { + path: None, + name: Some(codebase_name.clone()), + languages: Vec::new(), + frameworks: Vec::new(), + file_types: std::collections::HashSet::new(), + dependencies: Vec::new(), + structure: Vec::new(), + }; + let applicable = cog.cross_project.detect_applicable(&context); + for knowledge in applicable { + universal_patterns.push(serde_json::json!({ + "pattern": format!("{:?}", knowledge), + })); } } diff --git a/crates/vestige-mcp/src/tools/consolidate.rs b/crates/vestige-mcp/src/tools/consolidate.rs index 5ec99a7..4f31ec3 100644 --- a/crates/vestige-mcp/src/tools/consolidate.rs +++ b/crates/vestige-mcp/src/tools/consolidate.rs @@ -1,4 +1,3 @@ -#![allow(dead_code)] //! Consolidation Tool (Deprecated) //! //! Run memory consolidation cycle with FSRS decay and embedding generation. diff --git a/crates/vestige-mcp/src/tools/context.rs b/crates/vestige-mcp/src/tools/context.rs index 154e27f..3d38bfe 100644 --- a/crates/vestige-mcp/src/tools/context.rs +++ b/crates/vestige-mcp/src/tools/context.rs @@ -1,4 +1,3 @@ -#![allow(dead_code)] //! Context-Dependent Memory Tool (Deprecated) //! //! Retrieval based on encoding context match. diff --git a/crates/vestige-mcp/src/tools/dedup.rs b/crates/vestige-mcp/src/tools/dedup.rs index 32e462c..9df5ca7 100644 --- a/crates/vestige-mcp/src/tools/dedup.rs +++ b/crates/vestige-mcp/src/tools/dedup.rs @@ -175,7 +175,7 @@ pub async fn execute( for i in 0..n { for j in (i + 1)..n { - let sim = cosine_similarity(&filtered_embeddings[i].2, &filtered_embeddings[j].2); + let sim = cosine_similarity(filtered_embeddings[i].2, filtered_embeddings[j].2); if sim >= threshold { uf.union(i, j); similarities.push((i, j, sim)); @@ -195,7 +195,7 @@ pub async fn execute( .into_values() .filter(|c| c.len() > 1) .collect(); - clusters.sort_by(|a, b| b.len().cmp(&a.len())); + clusters.sort_by_key(|b| std::cmp::Reverse(b.len())); clusters.truncate(limit); // Build similarity lookup for formatting diff --git a/crates/vestige-mcp/src/tools/feedback.rs b/crates/vestige-mcp/src/tools/feedback.rs index 26fd601..dd0c873 100644 --- a/crates/vestige-mcp/src/tools/feedback.rs +++ b/crates/vestige-mcp/src/tools/feedback.rs @@ -1,4 +1,3 @@ -#![allow(dead_code)] //! Feedback Tools //! //! Promote and demote memories based on outcome quality. diff --git a/crates/vestige-mcp/src/tools/ingest.rs b/crates/vestige-mcp/src/tools/ingest.rs index 75ae13c..8be645c 100644 --- a/crates/vestige-mcp/src/tools/ingest.rs +++ b/crates/vestige-mcp/src/tools/ingest.rs @@ -140,7 +140,7 @@ pub async fn execute( run_post_ingest(cognitive, &node_id, &node_content, &node_type, importance_composite); - return Ok(serde_json::json!({ + Ok(serde_json::json!({ "success": true, "nodeId": node_id, "decision": result.decision, @@ -150,7 +150,7 @@ pub async fn execute( "reason": result.reason, "isNovel": is_novel, "embeddingStrategy": embedding_strategy, - })); + })) } Err(_) => { let node = storage_guard.ingest(fallback_input).map_err(|e| e.to_string())?; @@ -162,7 +162,7 @@ pub async fn execute( run_post_ingest(cognitive, &node_id, &node_content, &node_type, importance_composite); - return Ok(serde_json::json!({ + Ok(serde_json::json!({ "success": true, "nodeId": node_id, "decision": "create", @@ -170,7 +170,7 @@ pub async fn execute( "hasEmbedding": has_embedding, "isNovel": is_novel, "embeddingStrategy": embedding_strategy, - })); + })) } } } diff --git a/crates/vestige-mcp/src/tools/intention_unified.rs b/crates/vestige-mcp/src/tools/intention_unified.rs index 21859ff..55a6c13 100644 --- a/crates/vestige-mcp/src/tools/intention_unified.rs +++ b/crates/vestige-mcp/src/tools/intention_unified.rs @@ -257,38 +257,38 @@ async fn execute_set( if let Ok(cog) = cognitive.try_lock() { // 8A. Try NLP parsing when no explicit trigger is provided - if args.trigger.is_none() { - if let Ok(parsed) = cog.intention_parser.parse(description) { - nlp_parsed = true; - // Extract trigger info from parsed intention - let (t_type, t_data) = match &parsed.trigger { - ProspectiveTrigger::TimeBased { .. } => { - ("time".to_string(), serde_json::json!({"type": "time"}).to_string()) - } - ProspectiveTrigger::DurationBased { after, .. } => { - let mins = after.num_minutes(); - ("time".to_string(), serde_json::json!({"type": "time", "in_minutes": mins}).to_string()) - } - ProspectiveTrigger::EventBased { condition, .. } => { - ("event".to_string(), serde_json::json!({"type": "event", "condition": condition}).to_string()) - } - ProspectiveTrigger::ContextBased { context_match } => { - ("context".to_string(), serde_json::json!({"type": "context", "topic": format!("{:?}", context_match)}).to_string()) - } - ProspectiveTrigger::Recurring { .. } => { - ("recurring".to_string(), serde_json::json!({"type": "recurring"}).to_string()) - } - _ => { - ("event".to_string(), serde_json::json!({"type": "event"}).to_string()) - } - }; - nlp_trigger_type = Some(t_type); - nlp_trigger_data = Some(t_data); - - // Use NLP-detected priority if user didn't specify one - if args.priority.is_none() { - nlp_priority = Some(parsed.priority); + if args.trigger.is_none() + && let Ok(parsed) = cog.intention_parser.parse(description) + { + nlp_parsed = true; + // Extract trigger info from parsed intention + let (t_type, t_data) = match &parsed.trigger { + ProspectiveTrigger::TimeBased { .. } => { + ("time".to_string(), serde_json::json!({"type": "time"}).to_string()) } + ProspectiveTrigger::DurationBased { after, .. } => { + let mins = after.num_minutes(); + ("time".to_string(), serde_json::json!({"type": "time", "in_minutes": mins}).to_string()) + } + ProspectiveTrigger::EventBased { condition, .. } => { + ("event".to_string(), serde_json::json!({"type": "event", "condition": condition}).to_string()) + } + ProspectiveTrigger::ContextBased { context_match } => { + ("context".to_string(), serde_json::json!({"type": "context", "topic": format!("{:?}", context_match)}).to_string()) + } + ProspectiveTrigger::Recurring { .. } => { + ("recurring".to_string(), serde_json::json!({"type": "recurring"}).to_string()) + } + _ => { + ("event".to_string(), serde_json::json!({"type": "event"}).to_string()) + } + }; + nlp_trigger_type = Some(t_type); + nlp_trigger_data = Some(t_data); + + // Use NLP-detected priority if user didn't specify one + if args.priority.is_none() { + nlp_priority = Some(parsed.priority); } } @@ -355,10 +355,8 @@ async fn execute_set( DateTime::parse_from_rfc3339(at) .ok() .map(|dt| dt.with_timezone(&Utc)) - } else if let Some(mins) = trigger.in_minutes { - Some(now + Duration::minutes(mins)) } else { - None + trigger.in_minutes.map(|mins| now + Duration::minutes(mins)) } } else { None @@ -410,21 +408,21 @@ async fn execute_check( // ==================================================================== // COGNITIVE: Update prospective memory context // ==================================================================== - if let Some(ctx) = &args.context { - if let Ok(cog) = cognitive.try_lock() { - let mut prospective_ctx = ProspectiveContext::new(); - if let Some(codebase) = &ctx.codebase { - prospective_ctx.project_name = Some(codebase.clone()); - } - if let Some(file) = &ctx.file { - prospective_ctx.active_files = vec![file.clone()]; - } - if let Some(topics) = &ctx.topics { - prospective_ctx.active_topics = topics.clone(); - } - // Update context on prospective memory (triggers internal monitoring) - let _ = cog.prospective_memory.update_context(prospective_ctx); + if let Some(ctx) = &args.context + && let Ok(cog) = cognitive.try_lock() + { + let mut prospective_ctx = ProspectiveContext::new(); + if let Some(codebase) = &ctx.codebase { + prospective_ctx.project_name = Some(codebase.clone()); } + if let Some(file) = &ctx.file { + prospective_ctx.active_files = vec![file.clone()]; + } + if let Some(topics) = &ctx.topics { + prospective_ctx.active_topics = topics.clone(); + } + // Update context on prospective memory (triggers internal monitoring) + let _ = cog.prospective_memory.update_context(prospective_ctx); } let storage = storage.lock().await; diff --git a/crates/vestige-mcp/src/tools/intentions.rs b/crates/vestige-mcp/src/tools/intentions.rs index fcd2966..2f4c5d4 100644 --- a/crates/vestige-mcp/src/tools/intentions.rs +++ b/crates/vestige-mcp/src/tools/intentions.rs @@ -1,4 +1,3 @@ -#![allow(dead_code)] //! Intentions Tools (Deprecated - use intention_unified instead) //! //! Prospective memory tools for setting and checking future intentions. @@ -264,10 +263,8 @@ pub async fn execute_set( let trigger_at = if let Some(trigger) = &args.trigger { if let Some(at) = &trigger.at { DateTime::parse_from_rfc3339(at).ok().map(|dt| dt.with_timezone(&Utc)) - } else if let Some(mins) = trigger.in_minutes { - Some(now + Duration::minutes(mins)) } else { - None + trigger.in_minutes.map(|mins| now + Duration::minutes(mins)) } } else { None diff --git a/crates/vestige-mcp/src/tools/knowledge.rs b/crates/vestige-mcp/src/tools/knowledge.rs index 2baaa08..ea36451 100644 --- a/crates/vestige-mcp/src/tools/knowledge.rs +++ b/crates/vestige-mcp/src/tools/knowledge.rs @@ -1,4 +1,3 @@ -#![allow(dead_code)] //! Knowledge Tools (Deprecated - use memory_unified instead) //! //! Get and delete specific knowledge nodes. diff --git a/crates/vestige-mcp/src/tools/memory_states.rs b/crates/vestige-mcp/src/tools/memory_states.rs index 06d03d1..8c1786b 100644 --- a/crates/vestige-mcp/src/tools/memory_states.rs +++ b/crates/vestige-mcp/src/tools/memory_states.rs @@ -1,4 +1,3 @@ -#![allow(dead_code)] //! Memory States Tool (Deprecated - use memory_unified instead) //! //! Query and manage memory states (Active, Dormant, Silent, Unavailable). diff --git a/crates/vestige-mcp/src/tools/recall.rs b/crates/vestige-mcp/src/tools/recall.rs index 1f3a34f..7914dc2 100644 --- a/crates/vestige-mcp/src/tools/recall.rs +++ b/crates/vestige-mcp/src/tools/recall.rs @@ -1,4 +1,3 @@ -#![allow(dead_code)] //! Recall Tool (Deprecated - use search_unified instead) //! //! Search and retrieve knowledge from memory. diff --git a/crates/vestige-mcp/src/tools/review.rs b/crates/vestige-mcp/src/tools/review.rs index 431f6d3..587012f 100644 --- a/crates/vestige-mcp/src/tools/review.rs +++ b/crates/vestige-mcp/src/tools/review.rs @@ -1,4 +1,3 @@ -#![allow(dead_code)] //! Review Tool (Deprecated) //! //! Mark memories as reviewed using FSRS-6 algorithm. diff --git a/crates/vestige-mcp/src/tools/search.rs b/crates/vestige-mcp/src/tools/search.rs index d72b264..7db3eec 100644 --- a/crates/vestige-mcp/src/tools/search.rs +++ b/crates/vestige-mcp/src/tools/search.rs @@ -1,4 +1,3 @@ -#![allow(dead_code)] //! Search Tools (Deprecated - use search_unified instead) //! //! Semantic and hybrid search implementations. diff --git a/crates/vestige-mcp/src/tools/search_unified.rs b/crates/vestige-mcp/src/tools/search_unified.rs index b133b1f..08a490f 100644 --- a/crates/vestige-mcp/src/tools/search_unified.rs +++ b/crates/vestige-mcp/src/tools/search_unified.rs @@ -226,19 +226,19 @@ pub async fn execute( // ==================================================================== // STAGE 5: Context matching (Tulving 1973 encoding specificity) // ==================================================================== - if let Some(ref topics) = args.context_topics { - if !topics.is_empty() { - let retrieval_ctx = EncodingContext::new() - .with_topical(TopicalContext::with_topics(topics.clone())); - if let Ok(cog) = cognitive.try_lock() { - for result in &mut filtered_results { - // Build encoding context from memory's tags - let encoding_ctx = EncodingContext::new() - .with_topical(TopicalContext::with_topics(result.node.tags.clone())); - let context_score = cog.context_matcher.match_contexts(&encoding_ctx, &retrieval_ctx); - // Blend: context match boosts relevance up to +30% - result.combined_score *= 1.0 + (context_score as f32 * 0.3); - } + if let Some(ref topics) = args.context_topics + && !topics.is_empty() + { + let retrieval_ctx = EncodingContext::new() + .with_topical(TopicalContext::with_topics(topics.clone())); + if let Ok(cog) = cognitive.try_lock() { + for result in &mut filtered_results { + // Build encoding context from memory's tags + let encoding_ctx = EncodingContext::new() + .with_topical(TopicalContext::with_topics(result.node.tags.clone())); + let context_score = cog.context_matcher.match_contexts(&encoding_ctx, &retrieval_ctx); + // Blend: context match boosts relevance up to +30% + result.combined_score *= 1.0 + (context_score as f32 * 0.3); } } } @@ -270,23 +270,23 @@ pub async fn execute( // STAGE 5B: Retrieval competition (Anderson et al. 1994) // ==================================================================== let mut suppressed_count = 0_usize; - if filtered_results.len() > 1 { - if let Ok(mut cog) = cognitive.try_lock() { - let candidates: Vec = filtered_results - .iter() - .map(|r| CompetitionCandidate { - memory_id: r.node.id.clone(), - relevance_score: r.combined_score as f64, - similarity_to_query: r.semantic_score.unwrap_or(0.0) as f64, - }) - .collect(); - if let Some(result) = cog.competition_mgr.run_competition(&candidates, 0.7) { - // Apply suppression: losers get penalized - for suppressed_id in &result.suppressed_ids { - if let Some(r) = filtered_results.iter_mut().find(|r| &r.node.id == suppressed_id) { - r.combined_score *= 0.85; // 15% suppression penalty - suppressed_count += 1; - } + if filtered_results.len() > 1 + && let Ok(mut cog) = cognitive.try_lock() + { + let candidates: Vec = filtered_results + .iter() + .map(|r| CompetitionCandidate { + memory_id: r.node.id.clone(), + relevance_score: r.combined_score as f64, + similarity_to_query: r.semantic_score.unwrap_or(0.0) as f64, + }) + .collect(); + if let Some(result) = cog.competition_mgr.run_competition(&candidates, 0.7) { + // Apply suppression: losers get penalized + for suppressed_id in &result.suppressed_ids { + if let Some(r) = filtered_results.iter_mut().find(|r| &r.node.id == suppressed_id) { + r.combined_score *= 0.85; // 15% suppression penalty + suppressed_count += 1; } } } diff --git a/crates/vestige-mcp/src/tools/smart_ingest.rs b/crates/vestige-mcp/src/tools/smart_ingest.rs index 4b1db84..d1f2b49 100644 --- a/crates/vestige-mcp/src/tools/smart_ingest.rs +++ b/crates/vestige-mcp/src/tools/smart_ingest.rs @@ -170,7 +170,7 @@ pub async fn execute( // Post-ingest cognitive side effects run_post_ingest(cognitive, &node_id, &node_content, &node_type, importance_composite); - return Ok(serde_json::json!({ + Ok(serde_json::json!({ "success": true, "decision": result.decision, "nodeId": node_id, @@ -191,7 +191,7 @@ pub async fn execute( "add_context" => "Added new content as context to existing memory", _ => "Memory processed successfully" } - })); + })) } #[cfg(not(all(feature = "embeddings", feature = "vector-search")))] diff --git a/crates/vestige-mcp/src/tools/stats.rs b/crates/vestige-mcp/src/tools/stats.rs index 579034e..540e029 100644 --- a/crates/vestige-mcp/src/tools/stats.rs +++ b/crates/vestige-mcp/src/tools/stats.rs @@ -1,4 +1,3 @@ -#![allow(dead_code)] //! Stats Tools (Deprecated - use memory_unified instead) //! //! Memory statistics and health check. diff --git a/crates/vestige-mcp/src/tools/tagging.rs b/crates/vestige-mcp/src/tools/tagging.rs index f0e9f1d..32c7298 100644 --- a/crates/vestige-mcp/src/tools/tagging.rs +++ b/crates/vestige-mcp/src/tools/tagging.rs @@ -1,4 +1,3 @@ -#![allow(dead_code)] //! Synaptic Tagging Tool (Deprecated) //! //! Retroactive importance assignment based on Synaptic Tagging & Capture theory. diff --git a/packages/vestige-init/package.json b/packages/vestige-init/package.json index 05d3bc6..90ea2d6 100644 --- a/packages/vestige-init/package.json +++ b/packages/vestige-init/package.json @@ -20,7 +20,7 @@ "installer" ], "author": "Sam Valladares", - "license": "MIT", + "license": "AGPL-3.0-only", "repository": { "type": "git", "url": "git+https://github.com/samvallad33/vestige.git", diff --git a/packages/vestige-mcp-npm/package.json b/packages/vestige-mcp-npm/package.json index 418d97a..9b1e67c 100644 --- a/packages/vestige-mcp-npm/package.json +++ b/packages/vestige-mcp-npm/package.json @@ -17,7 +17,7 @@ "vestige" ], "author": "Sam Valladares", - "license": "MIT", + "license": "AGPL-3.0-only", "repository": { "type": "git", "url": "git+https://github.com/samvallad33/vestige.git" diff --git a/tests/e2e/src/harness/db_manager.rs b/tests/e2e/src/harness/db_manager.rs index 1d1c1b1..f5ce71c 100644 --- a/tests/e2e/src/harness/db_manager.rs +++ b/tests/e2e/src/harness/db_manager.rs @@ -11,6 +11,7 @@ use std::path::PathBuf; use tempfile::TempDir; /// Helper to create IngestInput (works around non_exhaustive) +#[allow(clippy::too_many_arguments)] fn make_ingest_input( content: String, node_type: String, @@ -21,16 +22,16 @@ fn make_ingest_input( valid_from: Option>, valid_until: Option>, ) -> vestige_core::IngestInput { - let mut input = vestige_core::IngestInput::default(); - input.content = content; - input.node_type = node_type; - input.tags = tags; - input.sentiment_score = sentiment_score; - input.sentiment_magnitude = sentiment_magnitude; - input.source = source; - input.valid_from = valid_from; - input.valid_until = valid_until; - input + vestige_core::IngestInput { + content, + node_type, + tags, + sentiment_score, + sentiment_magnitude, + source, + valid_from, + valid_until, + } } /// Manager for test databases diff --git a/tests/e2e/src/mocks/fixtures.rs b/tests/e2e/src/mocks/fixtures.rs index f887d69..05d2a22 100644 --- a/tests/e2e/src/mocks/fixtures.rs +++ b/tests/e2e/src/mocks/fixtures.rs @@ -9,6 +9,7 @@ use chrono::{DateTime, Duration, Utc}; use vestige_core::{KnowledgeNode, Rating, Storage}; /// Helper to create IngestInput (works around non_exhaustive) +#[allow(clippy::too_many_arguments)] fn make_ingest_input( content: String, node_type: String, @@ -19,16 +20,16 @@ fn make_ingest_input( valid_from: Option>, valid_until: Option>, ) -> vestige_core::IngestInput { - let mut input = vestige_core::IngestInput::default(); - input.content = content; - input.node_type = node_type; - input.tags = tags; - input.sentiment_score = sentiment_score; - input.sentiment_magnitude = sentiment_magnitude; - input.source = source; - input.valid_from = valid_from; - input.valid_until = valid_until; - input + vestige_core::IngestInput { + content, + node_type, + tags, + sentiment_score, + sentiment_magnitude, + source, + valid_from, + valid_until, + } } /// Factory for creating test data