mirror of
https://github.com/samvallad33/vestige.git
synced 2026-07-02 22:01:01 +02:00
fix(ci): restore vector-search feature to Windows MSVC release build (#102)
The Windows x86_64-pc-windows-msvc release binary was built with `--no-default-features --features embeddings,ort-download`, dropping `vector-search` (the usearch HNSW index). Without that feature the storage layer's `#[cfg(feature = "vector-search")]` paths compile out, so embeddings are never persisted or queried. On Windows the binary reports "Embedding Service: Not Ready", 0% coverage, `consolidate` generates 0 embeddings, and no model download is ever attempted. The same machine and model cache work on v2.1.23, which predates the flag. `vector-search` was likely dropped to sidestep the usearch MSVC build failure (C1021 from a bare-fp16 `#warning`), but that was already fixed properly by pinning usearch with `features=["fp16lib"]`, so omitting the feature is both unnecessary and the cause of the regression. Verified locally: building vestige-mcp with `embeddings,ort-download,vector-search` compiles and links cleanly, and the reporter's repro (ingest -> consolidate -> stats) downloads the nomic model and reaches 100% embedding coverage. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
7aade490d8
commit
9d15cce7ab
1 changed files with 8 additions and 1 deletions
9
.github/workflows/release.yml
vendored
9
.github/workflows/release.yml
vendored
|
|
@ -31,7 +31,14 @@ jobs:
|
||||||
- target: x86_64-pc-windows-msvc
|
- target: x86_64-pc-windows-msvc
|
||||||
os: windows-latest
|
os: windows-latest
|
||||||
archive: zip
|
archive: zip
|
||||||
cargo_flags: "--no-default-features --features embeddings,ort-download"
|
# vector-search (usearch HNSW index) is REQUIRED. Without it the
|
||||||
|
# storage layer's #[cfg(feature = "vector-search")] paths compile
|
||||||
|
# out, so embeddings are never persisted or queried: the binary
|
||||||
|
# reports "Embedding Service: Not Ready", 0% coverage, consolidate
|
||||||
|
# generates 0 embeddings, and no model download is ever attempted.
|
||||||
|
# usearch builds cleanly on MSVC because vestige-core pins it with
|
||||||
|
# features=["fp16lib"] (see crates/vestige-core/Cargo.toml).
|
||||||
|
cargo_flags: "--no-default-features --features embeddings,ort-download,vector-search"
|
||||||
needs_onnxruntime: false
|
needs_onnxruntime: false
|
||||||
# Intel Mac uses the ort-dynamic feature to runtime-link against a
|
# Intel Mac uses the ort-dynamic feature to runtime-link against a
|
||||||
# system libonnxruntime (Homebrew), sidestepping the missing
|
# system libonnxruntime (Homebrew), sidestepping the missing
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue