apunkt/vestige
1
0
Fork 0
mirror of https://github.com/samvallad33/vestige.git synced 2026-07-02 22:01:01 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(ci): restore vector-search feature to Windows MSVC release build (#102)

Browse source 
The Windows x86_64-pc-windows-msvc release binary was built with
`--no-default-features --features embeddings,ort-download`, dropping
`vector-search` (the usearch HNSW index). Without that feature the
storage layer's `#[cfg(feature = "vector-search")]` paths compile out,
so embeddings are never persisted or queried. On Windows the binary
reports "Embedding Service: Not Ready", 0% coverage, `consolidate`
generates 0 embeddings, and no model download is ever attempted. The
same machine and model cache work on v2.1.23, which predates the flag.

`vector-search` was likely dropped to sidestep the usearch MSVC build
failure (C1021 from a bare-fp16 `#warning`), but that was already fixed
properly by pinning usearch with `features=["fp16lib"]`, so omitting
the feature is both unnecessary and the cause of the regression.

Verified locally: building vestige-mcp with
`embeddings,ort-download,vector-search` compiles and links cleanly, and
the reporter's repro (ingest -> consolidate -> stats) downloads the
nomic model and reaches 100% embedding coverage.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Sam Valladares 2026-07-01 18:19:56 -05:00 • committed by GitHub
parent 7aade490d8
commit 9d15cce7ab
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
.github/workflows/release.yml vendored
View file

@ -31,7 +31,14 @@ jobs:
- target: x86_64-pc-windows-msvc
os: windows-latest
archive: zip
cargo_flags: "--no-default-features --features embeddings,ort-download"
# vector-search (usearch HNSW index) is REQUIRED. Without it the
# storage layer's #[cfg(feature = "vector-search")] paths compile
# out, so embeddings are never persisted or queried: the binary
# reports "Embedding Service: Not Ready", 0% coverage, consolidate
# generates 0 embeddings, and no model download is ever attempted.
# usearch builds cleanly on MSVC because vestige-core pins it with
# features=["fp16lib"] (see crates/vestige-core/Cargo.toml).
cargo_flags: "--no-default-features --features embeddings,ort-download,vector-search"
needs_onnxruntime: false
# Intel Mac uses the ort-dynamic feature to runtime-link against a
# system libonnxruntime (Homebrew), sidestepping the missing