mirror of
https://github.com/trustgraph-ai/trustgraph.git
synced 2026-05-16 02:45:13 +02:00
Introduces `workspace` as the isolation boundary for config, flows,
library, and knowledge data. Removes `user` as a schema-level field
throughout the code, API specs, and tests; workspace provides the
same separation more cleanly at the trusted flow.workspace layer
rather than through client-supplied message fields.
Design
------
- IAM tech spec (docs/tech-specs/iam.md) documents current state,
proposed auth/access model, and migration direction.
- Data ownership model (docs/tech-specs/data-ownership-model.md)
captures the workspace/collection/flow hierarchy.
Schema + messaging
------------------
- Drop `user` field from AgentRequest/Step, GraphRagQuery,
DocumentRagQuery, Triples/Graph/Document/Row EmbeddingsRequest,
Sparql/Rows/Structured QueryRequest, ToolServiceRequest.
- Keep collection/workspace routing via flow.workspace at the
service layer.
- Translators updated to not serialise/deserialise user.
API specs
---------
- OpenAPI schemas and path examples cleaned of user fields.
- Websocket async-api messages updated.
- Removed the unused parameters/User.yaml.
Services + base
---------------
- Librarian, collection manager, knowledge, config: all operations
scoped by workspace. Config client API takes workspace as first
positional arg.
- `flow.workspace` set at flow start time by the infrastructure;
no longer pass-through from clients.
- Tool service drops user-personalisation passthrough.
CLI + SDK
---------
- tg-init-workspace and workspace-aware import/export.
- All tg-* commands drop user args; accept --workspace.
- Python API/SDK (flow, socket_client, async_*, explainability,
library) drop user kwargs from every method signature.
MCP server
----------
- All tool endpoints drop user parameters; socket_manager no longer
keyed per user.
Flow service
------------
- Closure-based topic cleanup on flow stop: only delete topics
whose blueprint template was parameterised AND no remaining
live flow (across all workspaces) still resolves to that topic.
Three scopes fall out naturally from template analysis:
* {id} -> per-flow, deleted on stop
* {blueprint} -> per-blueprint, kept while any flow of the
same blueprint exists
* {workspace} -> per-workspace, kept while any flow in the
workspace exists
* literal -> global, never deleted (e.g. tg.request.librarian)
Fixes a bug where stopping a flow silently destroyed the global
librarian exchange, wedging all library operations until manual
restart.
RabbitMQ backend
----------------
- heartbeat=60, blocked_connection_timeout=300. Catches silently
dead connections (broker restart, orphaned channels, network
partitions) within ~2 heartbeat windows, so the consumer
reconnects and re-binds its queue rather than sitting forever
on a zombie connection.
Tests
-----
- Full test refresh: unit, integration, contract, provenance.
- Dropped user-field assertions and constructor kwargs across
~100 test files.
- Renamed user-collection isolation tests to workspace-collection.
225 lines
6.8 KiB
Python
Executable file
225 lines
6.8 KiB
Python
Executable file
|
|
"""
|
|
Accepts entity/vector pairs and writes them to a Pinecone store.
|
|
"""
|
|
|
|
from pinecone import Pinecone, ServerlessSpec
|
|
from pinecone.grpc import PineconeGRPC, GRPCClientConfig
|
|
|
|
import time
|
|
import uuid
|
|
import os
|
|
import logging
|
|
|
|
from .... base import GraphEmbeddingsStoreService, CollectionConfigHandler
|
|
from .... base import AsyncProcessor, Consumer, Producer
|
|
from .... base import ConsumerMetrics, ProducerMetrics
|
|
from .... schema import IRI, LITERAL
|
|
|
|
# Module logger
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
def get_term_value(term):
|
|
"""Extract the string value from a Term"""
|
|
if term is None:
|
|
return None
|
|
if term.type == IRI:
|
|
return term.iri
|
|
elif term.type == LITERAL:
|
|
return term.value
|
|
else:
|
|
# For blank nodes or other types, use id or value
|
|
return term.id or term.value
|
|
|
|
default_ident = "graph-embeddings-write"
|
|
default_api_key = os.getenv("PINECONE_API_KEY", "not-specified")
|
|
default_cloud = "aws"
|
|
default_region = "us-east-1"
|
|
|
|
class Processor(CollectionConfigHandler, GraphEmbeddingsStoreService):
|
|
|
|
def __init__(self, **params):
|
|
|
|
self.url = params.get("url", None)
|
|
self.cloud = params.get("cloud", default_cloud)
|
|
self.region = params.get("region", default_region)
|
|
self.api_key = params.get("api_key", default_api_key)
|
|
|
|
if self.api_key is None or self.api_key == "not-specified":
|
|
raise RuntimeError("Pinecone API key must be specified")
|
|
|
|
if self.url:
|
|
|
|
self.pinecone = PineconeGRPC(
|
|
api_key = self.api_key,
|
|
host = self.url
|
|
)
|
|
|
|
else:
|
|
|
|
self.pinecone = Pinecone(api_key = self.api_key)
|
|
|
|
super(Processor, self).__init__(
|
|
**params | {
|
|
"url": self.url,
|
|
"cloud": self.cloud,
|
|
"region": self.region,
|
|
"api_key": self.api_key,
|
|
}
|
|
)
|
|
|
|
self.last_index_name = None
|
|
|
|
# Register for config push notifications
|
|
self.register_config_handler(self.on_collection_config, types=["collection"])
|
|
|
|
def create_index(self, index_name, dim):
|
|
|
|
self.pinecone.create_index(
|
|
name = index_name,
|
|
dimension = dim,
|
|
metric = "cosine",
|
|
spec = ServerlessSpec(
|
|
cloud = self.cloud,
|
|
region = self.region,
|
|
)
|
|
)
|
|
|
|
for i in range(0, 1000):
|
|
|
|
if self.pinecone.describe_index(
|
|
index_name
|
|
).status["ready"]:
|
|
break
|
|
|
|
time.sleep(1)
|
|
|
|
if not self.pinecone.describe_index(
|
|
index_name
|
|
).status["ready"]:
|
|
raise RuntimeError(
|
|
"Gave up waiting for index creation"
|
|
)
|
|
|
|
async def store_graph_embeddings(self, workspace, message):
|
|
|
|
# Validate collection exists in config before processing
|
|
if not self.collection_exists(workspace, message.metadata.collection):
|
|
logger.warning(
|
|
f"Collection {message.metadata.collection} for workspace {workspace} "
|
|
f"does not exist in config (likely deleted while data was in-flight). "
|
|
f"Dropping message."
|
|
)
|
|
return
|
|
|
|
for entity in message.entities:
|
|
entity_value = get_term_value(entity.entity)
|
|
|
|
if entity_value == "" or entity_value is None:
|
|
continue
|
|
|
|
vec = entity.vector
|
|
if not vec:
|
|
continue
|
|
|
|
# Create index name with dimension suffix for lazy creation
|
|
dim = len(vec)
|
|
index_name = (
|
|
f"t-{workspace}-{message.metadata.collection}-{dim}"
|
|
)
|
|
|
|
# Lazily create index if it doesn't exist (but only if authorized in config)
|
|
if not self.pinecone.has_index(index_name):
|
|
logger.info(f"Lazily creating Pinecone index {index_name} with dimension {dim}")
|
|
self.create_index(index_name, dim)
|
|
|
|
index = self.pinecone.Index(index_name)
|
|
|
|
# Generate unique ID for each vector
|
|
vector_id = str(uuid.uuid4())
|
|
|
|
metadata = {"entity": entity_value}
|
|
if entity.chunk_id:
|
|
metadata["chunk_id"] = entity.chunk_id
|
|
|
|
records = [
|
|
{
|
|
"id": vector_id,
|
|
"values": vec,
|
|
"metadata": metadata,
|
|
}
|
|
]
|
|
|
|
index.upsert(
|
|
vectors = records,
|
|
)
|
|
|
|
@staticmethod
|
|
def add_args(parser):
|
|
|
|
GraphEmbeddingsStoreService.add_args(parser)
|
|
|
|
parser.add_argument(
|
|
'-a', '--api-key',
|
|
default=default_api_key,
|
|
help='Pinecone API key. (default from PINECONE_API_KEY)'
|
|
)
|
|
|
|
parser.add_argument(
|
|
'-u', '--url',
|
|
help='Pinecone URL. If unspecified, serverless is used'
|
|
)
|
|
|
|
parser.add_argument(
|
|
'--cloud',
|
|
default=default_cloud,
|
|
help=f'Pinecone cloud, (default: {default_cloud}'
|
|
)
|
|
|
|
parser.add_argument(
|
|
'--region',
|
|
default=default_region,
|
|
help=f'Pinecone region, (default: {default_region}'
|
|
)
|
|
|
|
async def create_collection(self, workspace: str, collection: str, metadata: dict):
|
|
"""
|
|
Create collection via config push - indexes are created lazily on first write
|
|
with the correct dimension determined from the actual embeddings.
|
|
"""
|
|
try:
|
|
logger.info(f"Collection create request for {workspace}/{collection} - will be created lazily on first write")
|
|
|
|
except Exception as e:
|
|
logger.error(f"Failed to create collection {workspace}/{collection}: {e}", exc_info=True)
|
|
raise
|
|
|
|
async def delete_collection(self, workspace: str, collection: str):
|
|
"""Delete the collection for graph embeddings via config push"""
|
|
try:
|
|
prefix = f"t-{workspace}-{collection}-"
|
|
|
|
# Get all indexes and filter for matches
|
|
all_indexes = self.pinecone.list_indexes()
|
|
matching_indexes = [
|
|
idx.name for idx in all_indexes
|
|
if idx.name.startswith(prefix)
|
|
]
|
|
|
|
if not matching_indexes:
|
|
logger.info(f"No indexes found matching prefix {prefix}")
|
|
else:
|
|
for index_name in matching_indexes:
|
|
self.pinecone.delete_index(index_name)
|
|
logger.info(f"Deleted Pinecone index: {index_name}")
|
|
logger.info(f"Deleted {len(matching_indexes)} index(es) for {workspace}/{collection}")
|
|
|
|
except Exception as e:
|
|
logger.error(f"Failed to delete collection {workspace}/{collection}: {e}", exc_info=True)
|
|
raise
|
|
|
|
def run():
|
|
|
|
Processor.launch(default_ident, __doc__)
|
|
|