mirror of
https://github.com/trustgraph-ai/trustgraph.git
synced 2026-04-25 00:16:23 +02:00
d35473f7f7
Introduces `workspace` as the isolation boundary for config, flows,
library, and knowledge data. Removes `user` as a schema-level field
throughout the code, API specs, and tests; workspace provides the
same separation more cleanly at the trusted flow.workspace layer
rather than through client-supplied message fields.
Design
------
- IAM tech spec (docs/tech-specs/iam.md) documents current state,
proposed auth/access model, and migration direction.
- Data ownership model (docs/tech-specs/data-ownership-model.md)
captures the workspace/collection/flow hierarchy.
Schema + messaging
------------------
- Drop `user` field from AgentRequest/Step, GraphRagQuery,
DocumentRagQuery, Triples/Graph/Document/Row EmbeddingsRequest,
Sparql/Rows/Structured QueryRequest, ToolServiceRequest.
- Keep collection/workspace routing via flow.workspace at the
service layer.
- Translators updated to not serialise/deserialise user.
API specs
---------
- OpenAPI schemas and path examples cleaned of user fields.
- Websocket async-api messages updated.
- Removed the unused parameters/User.yaml.
Services + base
---------------
- Librarian, collection manager, knowledge, config: all operations
scoped by workspace. Config client API takes workspace as first
positional arg.
- `flow.workspace` set at flow start time by the infrastructure;
no longer pass-through from clients.
- Tool service drops user-personalisation passthrough.
CLI + SDK
---------
- tg-init-workspace and workspace-aware import/export.
- All tg-* commands drop user args; accept --workspace.
- Python API/SDK (flow, socket_client, async_*, explainability,
library) drop user kwargs from every method signature.
MCP server
----------
- All tool endpoints drop user parameters; socket_manager no longer
keyed per user.
Flow service
------------
- Closure-based topic cleanup on flow stop: only delete topics
whose blueprint template was parameterised AND no remaining
live flow (across all workspaces) still resolves to that topic.
Three scopes fall out naturally from template analysis:
* {id} -> per-flow, deleted on stop
* {blueprint} -> per-blueprint, kept while any flow of the
same blueprint exists
* {workspace} -> per-workspace, kept while any flow in the
workspace exists
* literal -> global, never deleted (e.g. tg.request.librarian)
Fixes a bug where stopping a flow silently destroyed the global
librarian exchange, wedging all library operations until manual
restart.
RabbitMQ backend
----------------
- heartbeat=60, blocked_connection_timeout=300. Catches silently
dead connections (broker restart, orphaned channels, network
partitions) within ~2 heartbeat windows, so the consumer
reconnects and re-binds its queue rather than sitting forever
on a zombie connection.
Tests
-----
- Full test refresh: unit, integration, contract, provenance.
- Dropped user-field assertions and constructor kwargs across
~100 test files.
- Renamed user-collection isolation tests to workspace-collection.
81 lines
2.7 KiB
Python
81 lines
2.7 KiB
Python
import asyncio
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
from trustgraph.base.flow import Flow
|
|
from trustgraph.base.parameter_spec import Parameter, ParameterSpec
|
|
from trustgraph.base.spec import Spec
|
|
|
|
|
|
def test_parameter_spec_is_a_spec_and_adds_parameter_value():
|
|
spec = ParameterSpec("temperature")
|
|
flow = MagicMock(parameter={})
|
|
processor = MagicMock()
|
|
|
|
spec.add(flow, processor, {"parameters": {"temperature": 0.7}})
|
|
|
|
assert isinstance(spec, Spec)
|
|
assert "temperature" in flow.parameter
|
|
assert isinstance(flow.parameter["temperature"], Parameter)
|
|
assert flow.parameter["temperature"].value == 0.7
|
|
|
|
|
|
def test_parameter_spec_defaults_missing_values_to_none():
|
|
spec = ParameterSpec("model")
|
|
flow = MagicMock(parameter={})
|
|
|
|
spec.add(flow, MagicMock(), {})
|
|
|
|
assert flow.parameter["model"].value is None
|
|
|
|
|
|
def test_parameter_start_and_stop_are_awaitable():
|
|
parameter = Parameter("value")
|
|
|
|
assert asyncio.run(parameter.start()) is None
|
|
assert asyncio.run(parameter.stop()) is None
|
|
|
|
|
|
def test_flow_initialization_calls_registered_specs():
|
|
spec_one = MagicMock()
|
|
spec_two = MagicMock()
|
|
processor = MagicMock(specifications=[spec_one, spec_two])
|
|
|
|
flow = Flow("processor-1", "flow-a", "default", processor, {"answer": 42})
|
|
|
|
assert flow.id == "processor-1"
|
|
assert flow.name == "flow-a"
|
|
assert flow.workspace == "default"
|
|
assert flow.producer == {}
|
|
assert flow.consumer == {}
|
|
assert flow.parameter == {}
|
|
spec_one.add.assert_called_once_with(flow, processor, {"answer": 42})
|
|
spec_two.add.assert_called_once_with(flow, processor, {"answer": 42})
|
|
|
|
|
|
def test_flow_start_and_stop_visit_all_consumers():
|
|
consumer_one = AsyncMock()
|
|
consumer_two = AsyncMock()
|
|
flow = Flow("processor-1", "flow-a", "default", MagicMock(specifications=[]), {})
|
|
flow.consumer = {"one": consumer_one, "two": consumer_two}
|
|
|
|
asyncio.run(flow.start())
|
|
asyncio.run(flow.stop())
|
|
|
|
consumer_one.start.assert_called_once_with()
|
|
consumer_two.start.assert_called_once_with()
|
|
consumer_one.stop.assert_called_once_with()
|
|
consumer_two.stop.assert_called_once_with()
|
|
|
|
|
|
def test_flow_call_returns_values_in_priority_order():
|
|
flow = Flow("processor-1", "flow-a", "default", MagicMock(specifications=[]), {})
|
|
flow.producer["shared"] = "producer-value"
|
|
flow.consumer["consumer-only"] = "consumer-value"
|
|
flow.consumer["shared"] = "consumer-value"
|
|
flow.parameter["parameter-only"] = Parameter("parameter-value")
|
|
flow.parameter["shared"] = Parameter("parameter-value")
|
|
|
|
assert flow("shared") == "producer-value"
|
|
assert flow("consumer-only") == "consumer-value"
|
|
assert flow("parameter-only") == "parameter-value"
|
|
assert flow("missing") is None
|