mirror of
https://github.com/trustgraph-ai/trustgraph.git
synced 2026-04-26 00:46:22 +02:00
d35473f7f7
Introduces `workspace` as the isolation boundary for config, flows,
library, and knowledge data. Removes `user` as a schema-level field
throughout the code, API specs, and tests; workspace provides the
same separation more cleanly at the trusted flow.workspace layer
rather than through client-supplied message fields.
Design
------
- IAM tech spec (docs/tech-specs/iam.md) documents current state,
proposed auth/access model, and migration direction.
- Data ownership model (docs/tech-specs/data-ownership-model.md)
captures the workspace/collection/flow hierarchy.
Schema + messaging
------------------
- Drop `user` field from AgentRequest/Step, GraphRagQuery,
DocumentRagQuery, Triples/Graph/Document/Row EmbeddingsRequest,
Sparql/Rows/Structured QueryRequest, ToolServiceRequest.
- Keep collection/workspace routing via flow.workspace at the
service layer.
- Translators updated to not serialise/deserialise user.
API specs
---------
- OpenAPI schemas and path examples cleaned of user fields.
- Websocket async-api messages updated.
- Removed the unused parameters/User.yaml.
Services + base
---------------
- Librarian, collection manager, knowledge, config: all operations
scoped by workspace. Config client API takes workspace as first
positional arg.
- `flow.workspace` set at flow start time by the infrastructure;
no longer pass-through from clients.
- Tool service drops user-personalisation passthrough.
CLI + SDK
---------
- tg-init-workspace and workspace-aware import/export.
- All tg-* commands drop user args; accept --workspace.
- Python API/SDK (flow, socket_client, async_*, explainability,
library) drop user kwargs from every method signature.
MCP server
----------
- All tool endpoints drop user parameters; socket_manager no longer
keyed per user.
Flow service
------------
- Closure-based topic cleanup on flow stop: only delete topics
whose blueprint template was parameterised AND no remaining
live flow (across all workspaces) still resolves to that topic.
Three scopes fall out naturally from template analysis:
* {id} -> per-flow, deleted on stop
* {blueprint} -> per-blueprint, kept while any flow of the
same blueprint exists
* {workspace} -> per-workspace, kept while any flow in the
workspace exists
* literal -> global, never deleted (e.g. tg.request.librarian)
Fixes a bug where stopping a flow silently destroyed the global
librarian exchange, wedging all library operations until manual
restart.
RabbitMQ backend
----------------
- heartbeat=60, blocked_connection_timeout=300. Catches silently
dead connections (broker restart, orphaned channels, network
partitions) within ~2 heartbeat windows, so the consumer
reconnects and re-binds its queue rather than sitting forever
on a zombie connection.
Tests
-----
- Full test refresh: unit, integration, contract, provenance.
- Dropped user-field assertions and constructor kwargs across
~100 test files.
- Renamed user-collection isolation tests to workspace-collection.
143 lines
4.1 KiB
Python
143 lines
4.1 KiB
Python
"""
|
|
Unit tests for PatternBase subagent helpers — is_subagent() and
|
|
emit_subagent_completion().
|
|
"""
|
|
|
|
import pytest
|
|
from unittest.mock import MagicMock, AsyncMock
|
|
from dataclasses import dataclass
|
|
|
|
from trustgraph.schema import AgentRequest
|
|
|
|
from trustgraph.agent.orchestrator.pattern_base import PatternBase
|
|
|
|
|
|
@dataclass
|
|
class MockProcessor:
|
|
"""Minimal processor mock for PatternBase."""
|
|
pass
|
|
|
|
|
|
def _make_request(**kwargs):
|
|
defaults = dict(
|
|
question="Test question",
|
|
collection="default",
|
|
)
|
|
defaults.update(kwargs)
|
|
return AgentRequest(**defaults)
|
|
|
|
|
|
def _make_pattern():
|
|
return PatternBase(MockProcessor())
|
|
|
|
|
|
class TestIsSubagent:
|
|
|
|
def test_returns_true_when_correlation_id_set(self):
|
|
pattern = _make_pattern()
|
|
request = _make_request(correlation_id="corr-123")
|
|
assert pattern.is_subagent(request) is True
|
|
|
|
def test_returns_false_when_correlation_id_empty(self):
|
|
pattern = _make_pattern()
|
|
request = _make_request(correlation_id="")
|
|
assert pattern.is_subagent(request) is False
|
|
|
|
def test_returns_false_when_correlation_id_missing(self):
|
|
pattern = _make_pattern()
|
|
request = _make_request()
|
|
assert pattern.is_subagent(request) is False
|
|
|
|
|
|
class TestEmitSubagentCompletion:
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_calls_next_with_completion_request(self):
|
|
pattern = _make_pattern()
|
|
request = _make_request(
|
|
correlation_id="corr-123",
|
|
parent_session_id="parent-sess",
|
|
subagent_goal="What is X?",
|
|
expected_siblings=4,
|
|
)
|
|
next_fn = AsyncMock()
|
|
|
|
await pattern.emit_subagent_completion(
|
|
request, next_fn, "The answer is Y",
|
|
)
|
|
|
|
next_fn.assert_called_once()
|
|
completion_req = next_fn.call_args[0][0]
|
|
assert isinstance(completion_req, AgentRequest)
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_completion_has_correct_step_type(self):
|
|
pattern = _make_pattern()
|
|
request = _make_request(
|
|
correlation_id="corr-123",
|
|
subagent_goal="What is X?",
|
|
)
|
|
next_fn = AsyncMock()
|
|
|
|
await pattern.emit_subagent_completion(
|
|
request, next_fn, "answer text",
|
|
)
|
|
|
|
completion_req = next_fn.call_args[0][0]
|
|
assert len(completion_req.history) == 1
|
|
step = completion_req.history[0]
|
|
assert step.step_type == "subagent-completion"
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_completion_carries_answer_in_observation(self):
|
|
pattern = _make_pattern()
|
|
request = _make_request(
|
|
correlation_id="corr-123",
|
|
subagent_goal="What is X?",
|
|
)
|
|
next_fn = AsyncMock()
|
|
|
|
await pattern.emit_subagent_completion(
|
|
request, next_fn, "The answer is Y",
|
|
)
|
|
|
|
completion_req = next_fn.call_args[0][0]
|
|
step = completion_req.history[0]
|
|
assert step.observation == "The answer is Y"
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_completion_preserves_correlation_fields(self):
|
|
pattern = _make_pattern()
|
|
request = _make_request(
|
|
correlation_id="corr-123",
|
|
parent_session_id="parent-sess",
|
|
subagent_goal="What is X?",
|
|
expected_siblings=4,
|
|
)
|
|
next_fn = AsyncMock()
|
|
|
|
await pattern.emit_subagent_completion(
|
|
request, next_fn, "answer",
|
|
)
|
|
|
|
completion_req = next_fn.call_args[0][0]
|
|
assert completion_req.correlation_id == "corr-123"
|
|
assert completion_req.parent_session_id == "parent-sess"
|
|
assert completion_req.subagent_goal == "What is X?"
|
|
assert completion_req.expected_siblings == 4
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_completion_has_empty_pattern(self):
|
|
pattern = _make_pattern()
|
|
request = _make_request(
|
|
correlation_id="corr-123",
|
|
subagent_goal="goal",
|
|
)
|
|
next_fn = AsyncMock()
|
|
|
|
await pattern.emit_subagent_completion(
|
|
request, next_fn, "answer",
|
|
)
|
|
|
|
completion_req = next_fn.call_args[0][0]
|
|
assert completion_req.pattern == ""
|