trustgraph/tests/integration/test_object_extraction_integration.py
cybermaggedon d35473f7f7
feat: workspace-based multi-tenancy, replacing user as tenancy axis (#840)
Introduces `workspace` as the isolation boundary for config, flows,
library, and knowledge data. Removes `user` as a schema-level field
throughout the code, API specs, and tests; workspace provides the
same separation more cleanly at the trusted flow.workspace layer
rather than through client-supplied message fields.

Design
------
- IAM tech spec (docs/tech-specs/iam.md) documents current state,
  proposed auth/access model, and migration direction.
- Data ownership model (docs/tech-specs/data-ownership-model.md)
  captures the workspace/collection/flow hierarchy.

Schema + messaging
------------------
- Drop `user` field from AgentRequest/Step, GraphRagQuery,
  DocumentRagQuery, Triples/Graph/Document/Row EmbeddingsRequest,
  Sparql/Rows/Structured QueryRequest, ToolServiceRequest.
- Keep collection/workspace routing via flow.workspace at the
  service layer.
- Translators updated to not serialise/deserialise user.

API specs
---------
- OpenAPI schemas and path examples cleaned of user fields.
- Websocket async-api messages updated.
- Removed the unused parameters/User.yaml.

Services + base
---------------
- Librarian, collection manager, knowledge, config: all operations
  scoped by workspace. Config client API takes workspace as first
  positional arg.
- `flow.workspace` set at flow start time by the infrastructure;
  no longer pass-through from clients.
- Tool service drops user-personalisation passthrough.

CLI + SDK
---------
- tg-init-workspace and workspace-aware import/export.
- All tg-* commands drop user args; accept --workspace.
- Python API/SDK (flow, socket_client, async_*, explainability,
  library) drop user kwargs from every method signature.

MCP server
----------
- All tool endpoints drop user parameters; socket_manager no longer
  keyed per user.

Flow service
------------
- Closure-based topic cleanup on flow stop: only delete topics
  whose blueprint template was parameterised AND no remaining
  live flow (across all workspaces) still resolves to that topic.
  Three scopes fall out naturally from template analysis:
    * {id} -> per-flow, deleted on stop
    * {blueprint} -> per-blueprint, kept while any flow of the
      same blueprint exists
    * {workspace} -> per-workspace, kept while any flow in the
      workspace exists
    * literal -> global, never deleted (e.g. tg.request.librarian)
  Fixes a bug where stopping a flow silently destroyed the global
  librarian exchange, wedging all library operations until manual
  restart.

RabbitMQ backend
----------------
- heartbeat=60, blocked_connection_timeout=300. Catches silently
  dead connections (broker restart, orphaned channels, network
  partitions) within ~2 heartbeat windows, so the consumer
  reconnects and re-binds its queue rather than sitting forever
  on a zombie connection.

Tests
-----
- Full test refresh: unit, integration, contract, provenance.
- Dropped user-field assertions and constructor kwargs across
  ~100 test files.
- Renamed user-collection isolation tests to workspace-collection.
2026-04-21 23:23:01 +01:00

549 lines
No EOL
22 KiB
Python

"""
Integration tests for Object Extraction Service
These tests verify the end-to-end functionality of the object extraction service,
testing configuration management, text-to-object transformation, and service coordination.
Following the TEST_STRATEGY.md approach for integration testing.
"""
import pytest
import json
import asyncio
from unittest.mock import AsyncMock, MagicMock, patch
from trustgraph.extract.kg.rows.processor import Processor
from trustgraph.schema import (
Chunk, ExtractedObject, Metadata, RowSchema, Field,
PromptRequest, PromptResponse
)
from trustgraph.base import PromptResult
@pytest.mark.integration
class TestObjectExtractionServiceIntegration:
"""Integration tests for Object Extraction Service"""
@pytest.fixture
def integration_config(self):
"""Integration test configuration with multiple schemas"""
customer_schema = {
"name": "customer_records",
"description": "Customer information schema",
"fields": [
{
"name": "customer_id",
"type": "string",
"primary_key": True,
"required": True,
"indexed": True,
"description": "Unique customer identifier"
},
{
"name": "name",
"type": "string",
"required": True,
"description": "Customer full name"
},
{
"name": "email",
"type": "string",
"required": True,
"indexed": True,
"description": "Customer email address"
},
{
"name": "phone",
"type": "string",
"required": False,
"description": "Customer phone number"
}
]
}
product_schema = {
"name": "product_catalog",
"description": "Product catalog schema",
"fields": [
{
"name": "product_id",
"type": "string",
"primary_key": True,
"required": True,
"indexed": True,
"description": "Unique product identifier"
},
{
"name": "name",
"type": "string",
"required": True,
"description": "Product name"
},
{
"name": "price",
"type": "double",
"required": True,
"description": "Product price"
},
{
"name": "category",
"type": "string",
"required": False,
"enum": ["electronics", "clothing", "books", "home"],
"description": "Product category"
}
]
}
return {
"schema": {
"customer_records": json.dumps(customer_schema),
"product_catalog": json.dumps(product_schema)
}
}
@pytest.fixture
def mock_integrated_flow(self):
"""Mock integrated flow context with realistic prompt responses"""
context = MagicMock()
# Mock prompt client with realistic responses
prompt_client = AsyncMock()
def mock_extract_objects(schema, text):
"""Mock extract_objects with schema-aware responses"""
# Schema is now a dict (converted by row_schema_translator)
schema_name = schema.get("name") if isinstance(schema, dict) else schema.name
if schema_name == "customer_records":
if "john" in text.lower():
return PromptResult(
response_type="jsonl",
objects=[
{
"customer_id": "CUST001",
"name": "John Smith",
"email": "john.smith@email.com",
"phone": "555-0123"
}
]
)
elif "jane" in text.lower():
return PromptResult(
response_type="jsonl",
objects=[
{
"customer_id": "CUST002",
"name": "Jane Doe",
"email": "jane.doe@email.com",
"phone": ""
}
]
)
else:
return PromptResult(response_type="jsonl", objects=[])
elif schema_name == "product_catalog":
if "laptop" in text.lower():
return PromptResult(
response_type="jsonl",
objects=[
{
"product_id": "PROD001",
"name": "Gaming Laptop",
"price": "1299.99",
"category": "electronics"
}
]
)
elif "book" in text.lower():
return PromptResult(
response_type="jsonl",
objects=[
{
"product_id": "PROD002",
"name": "Python Programming Guide",
"price": "49.99",
"category": "books"
}
]
)
else:
return PromptResult(response_type="jsonl", objects=[])
return PromptResult(response_type="jsonl", objects=[])
prompt_client.extract_objects.side_effect = mock_extract_objects
# Mock output producer
output_producer = AsyncMock()
def context_router(service_name):
if service_name == "prompt-request":
return prompt_client
elif service_name == "output":
return output_producer
else:
return AsyncMock()
context.side_effect = context_router
context.workspace = "default"
return context
@pytest.mark.asyncio
async def test_multi_schema_configuration_integration(self, integration_config):
"""Test integration with multiple schema configurations"""
# Arrange - Create mock processor with actual methods
processor = MagicMock()
processor.schemas = {}
processor.config_key = "schema"
processor.on_schema_config = Processor.on_schema_config.__get__(processor, Processor)
# Act
await processor.on_schema_config("default", integration_config, version=1)
# Assert
ws_schemas = processor.schemas["default"]
assert len(ws_schemas) == 2
assert "customer_records" in ws_schemas
assert "product_catalog" in ws_schemas
# Verify customer schema
customer_schema = ws_schemas["customer_records"]
assert customer_schema.name == "customer_records"
assert len(customer_schema.fields) == 4
# Verify product schema
product_schema = ws_schemas["product_catalog"]
assert product_schema.name == "product_catalog"
assert len(product_schema.fields) == 4
# Check enum field in product schema
category_field = next((f for f in product_schema.fields if f.name == "category"), None)
assert category_field is not None
assert len(category_field.enum_values) == 4
assert "electronics" in category_field.enum_values
@pytest.mark.asyncio
async def test_full_service_integration_customer_extraction(self, integration_config, mock_integrated_flow):
"""Test full service integration for customer data extraction"""
# Arrange - Create mock processor with actual methods
processor = MagicMock()
processor.schemas = {}
processor.config_key = "schema"
processor.flow = mock_integrated_flow
processor.on_schema_config = Processor.on_schema_config.__get__(processor, Processor)
processor.on_chunk = Processor.on_chunk.__get__(processor, Processor)
processor.extract_objects_for_schema = Processor.extract_objects_for_schema.__get__(processor, Processor)
# Import and bind the convert_values_to_strings function
from trustgraph.extract.kg.rows.processor import convert_values_to_strings
processor.convert_values_to_strings = convert_values_to_strings
# Load configuration
await processor.on_schema_config("default", integration_config, version=1)
# Create realistic customer data chunk
metadata = Metadata(
id="customer-doc-001",
collection="test_documents",
)
chunk_text = """
Customer Registration Form
Name: John Smith
Email: john.smith@email.com
Phone: 555-0123
Customer ID: CUST001
Registration completed successfully.
"""
chunk = Chunk(metadata=metadata, chunk=chunk_text.encode('utf-8'))
# Mock message
mock_msg = MagicMock()
mock_msg.value.return_value = chunk
# Act
await processor.on_chunk(mock_msg, None, mock_integrated_flow)
# Assert
output_producer = mock_integrated_flow("output")
# Should have calls for both schemas (even if one returns empty)
assert output_producer.send.call_count >= 1
# Find customer extraction
customer_calls = []
for call in output_producer.send.call_args_list:
extracted_obj = call[0][0]
if extracted_obj.schema_name == "customer_records":
customer_calls.append(extracted_obj)
assert len(customer_calls) == 1
customer_obj = customer_calls[0]
assert customer_obj.values[0]["customer_id"] == "CUST001"
assert customer_obj.values[0]["name"] == "John Smith"
assert customer_obj.values[0]["email"] == "john.smith@email.com"
assert customer_obj.confidence > 0.5
@pytest.mark.asyncio
async def test_full_service_integration_product_extraction(self, integration_config, mock_integrated_flow):
"""Test full service integration for product data extraction"""
# Arrange - Create mock processor with actual methods
processor = MagicMock()
processor.schemas = {}
processor.config_key = "schema"
processor.flow = mock_integrated_flow
processor.on_schema_config = Processor.on_schema_config.__get__(processor, Processor)
processor.on_chunk = Processor.on_chunk.__get__(processor, Processor)
processor.extract_objects_for_schema = Processor.extract_objects_for_schema.__get__(processor, Processor)
# Import and bind the convert_values_to_strings function
from trustgraph.extract.kg.rows.processor import convert_values_to_strings
processor.convert_values_to_strings = convert_values_to_strings
# Load configuration
await processor.on_schema_config("default", integration_config, version=1)
# Create realistic product data chunk
metadata = Metadata(
id="product-doc-001",
collection="test_documents",
)
chunk_text = """
Product Specification Sheet
Product Name: Gaming Laptop
Product ID: PROD001
Price: $1,299.99
Category: Electronics
High-performance gaming laptop with latest specifications.
"""
chunk = Chunk(metadata=metadata, chunk=chunk_text.encode('utf-8'))
# Mock message
mock_msg = MagicMock()
mock_msg.value.return_value = chunk
# Act
await processor.on_chunk(mock_msg, None, mock_integrated_flow)
# Assert
output_producer = mock_integrated_flow("output")
# Find product extraction
product_calls = []
for call in output_producer.send.call_args_list:
extracted_obj = call[0][0]
if extracted_obj.schema_name == "product_catalog":
product_calls.append(extracted_obj)
assert len(product_calls) == 1
product_obj = product_calls[0]
assert product_obj.values[0]["product_id"] == "PROD001"
assert product_obj.values[0]["name"] == "Gaming Laptop"
assert product_obj.values[0]["price"] == "1299.99"
assert product_obj.values[0]["category"] == "electronics"
@pytest.mark.asyncio
async def test_concurrent_extraction_integration(self, integration_config, mock_integrated_flow):
"""Test concurrent processing of multiple chunks"""
# Arrange - Create mock processor with actual methods
processor = MagicMock()
processor.schemas = {}
processor.config_key = "schema"
processor.flow = mock_integrated_flow
processor.on_schema_config = Processor.on_schema_config.__get__(processor, Processor)
processor.on_chunk = Processor.on_chunk.__get__(processor, Processor)
processor.extract_objects_for_schema = Processor.extract_objects_for_schema.__get__(processor, Processor)
# Import and bind the convert_values_to_strings function
from trustgraph.extract.kg.rows.processor import convert_values_to_strings
processor.convert_values_to_strings = convert_values_to_strings
# Load configuration
await processor.on_schema_config("default", integration_config, version=1)
# Create multiple test chunks
chunks_data = [
("customer-chunk-1", "Customer: John Smith, email: john.smith@email.com, ID: CUST001"),
("customer-chunk-2", "Customer: Jane Doe, email: jane.doe@email.com, ID: CUST002"),
("product-chunk-1", "Product: Gaming Laptop, ID: PROD001, Price: $1299.99, Category: electronics"),
("product-chunk-2", "Product: Python Programming Guide, ID: PROD002, Price: $49.99, Category: books")
]
chunks = []
for chunk_id, text in chunks_data:
metadata = Metadata(
id=chunk_id,
collection="test_collection",
)
chunk = Chunk(metadata=metadata, chunk=text.encode('utf-8'))
chunks.append(chunk)
# Act - Process chunks concurrently
tasks = []
for chunk in chunks:
mock_msg = MagicMock()
mock_msg.value.return_value = chunk
task = processor.on_chunk(mock_msg, None, mock_integrated_flow)
tasks.append(task)
await asyncio.gather(*tasks)
# Assert
output_producer = mock_integrated_flow("output")
# Should have processed all chunks (some may produce objects, some may not)
assert output_producer.send.call_count >= 2 # At least customer and product extractions
# Verify we got both types of objects
extracted_objects = []
for call in output_producer.send.call_args_list:
extracted_objects.append(call[0][0])
customer_objects = [obj for obj in extracted_objects if obj.schema_name == "customer_records"]
product_objects = [obj for obj in extracted_objects if obj.schema_name == "product_catalog"]
assert len(customer_objects) >= 1
assert len(product_objects) >= 1
@pytest.mark.asyncio
async def test_configuration_reload_integration(self, integration_config, mock_integrated_flow):
"""Test configuration reload during service operation"""
# Arrange - Create mock processor with actual methods
processor = MagicMock()
processor.schemas = {}
processor.config_key = "schema"
processor.flow = mock_integrated_flow
processor.on_schema_config = Processor.on_schema_config.__get__(processor, Processor)
# Load initial configuration (only customer schema)
initial_config = {
"schema": {
"customer_records": integration_config["schema"]["customer_records"]
}
}
await processor.on_schema_config("default", initial_config, version=1)
ws_schemas = processor.schemas["default"]
assert len(ws_schemas) == 1
assert "customer_records" in ws_schemas
assert "product_catalog" not in ws_schemas
# Act - Reload with full configuration
await processor.on_schema_config("default", integration_config, version=2)
# Assert
ws_schemas = processor.schemas["default"]
assert len(ws_schemas) == 2
assert "customer_records" in ws_schemas
assert "product_catalog" in ws_schemas
@pytest.mark.asyncio
async def test_error_resilience_integration(self, integration_config):
"""Test service resilience to various error conditions"""
# Arrange - Create mock processor with actual methods
processor = MagicMock()
processor.schemas = {}
processor.config_key = "schema"
processor.on_schema_config = Processor.on_schema_config.__get__(processor, Processor)
processor.on_chunk = Processor.on_chunk.__get__(processor, Processor)
processor.extract_objects_for_schema = Processor.extract_objects_for_schema.__get__(processor, Processor)
# Import and bind the convert_values_to_strings function
from trustgraph.extract.kg.rows.processor import convert_values_to_strings
processor.convert_values_to_strings = convert_values_to_strings
# Mock flow with failing prompt service
failing_flow = MagicMock()
failing_prompt = AsyncMock()
failing_prompt.extract_rows.side_effect = Exception("Prompt service unavailable")
def failing_context_router(service_name):
if service_name == "prompt-request":
return failing_prompt
elif service_name == "output":
return AsyncMock()
else:
return AsyncMock()
failing_flow.side_effect = failing_context_router
failing_flow.workspace = "default"
processor.flow = failing_flow
# Load configuration
await processor.on_schema_config("default", integration_config, version=1)
# Create test chunk
metadata = Metadata(id="error-test", collection="test")
chunk = Chunk(metadata=metadata, chunk=b"Some text that will fail to process")
mock_msg = MagicMock()
mock_msg.value.return_value = chunk
# Act & Assert - Should not raise exception
try:
await processor.on_chunk(mock_msg, None, failing_flow)
# Should complete without throwing exception
except Exception as e:
pytest.fail(f"Service should handle errors gracefully, but raised: {e}")
@pytest.mark.asyncio
async def test_metadata_propagation_integration(self, integration_config, mock_integrated_flow):
"""Test proper metadata propagation through extraction pipeline"""
# Arrange - Create mock processor with actual methods
processor = MagicMock()
processor.schemas = {}
processor.config_key = "schema"
processor.flow = mock_integrated_flow
processor.on_schema_config = Processor.on_schema_config.__get__(processor, Processor)
processor.on_chunk = Processor.on_chunk.__get__(processor, Processor)
processor.extract_objects_for_schema = Processor.extract_objects_for_schema.__get__(processor, Processor)
# Import and bind the convert_values_to_strings function
from trustgraph.extract.kg.rows.processor import convert_values_to_strings
processor.convert_values_to_strings = convert_values_to_strings
# Load configuration
await processor.on_schema_config("default", integration_config, version=1)
# Create chunk with rich metadata
original_metadata = Metadata(
id="metadata-test-chunk",
collection="test_collection",
)
chunk = Chunk(
metadata=original_metadata,
chunk=b"Customer: John Smith, ID: CUST001, email: john.smith@email.com"
)
mock_msg = MagicMock()
mock_msg.value.return_value = chunk
# Act
await processor.on_chunk(mock_msg, None, mock_integrated_flow)
# Assert
output_producer = mock_integrated_flow("output")
# Find extracted object
extracted_obj = None
for call in output_producer.send.call_args_list:
obj = call[0][0]
if obj.schema_name == "customer_records":
extracted_obj = obj
break
assert extracted_obj is not None
# Verify metadata propagation
assert extracted_obj.metadata.collection == "test_collection"
assert "metadata-test-chunk" in extracted_obj.metadata.id # Should include source reference