mirror of
https://github.com/trustgraph-ai/trustgraph.git
synced 2026-04-26 17:06:22 +02:00
4acd853023
Replace the config push mechanism that broadcast the full config blob on a 'state' class pub/sub queue with a lightweight notify signal containing only the version number and affected config types. Processors fetch the full config via request/response from the config service when notified. This eliminates the need for the pub/sub 'state' queue class and stateful pub/sub services entirely. The config push queue moves from 'state' to 'flow' class — a simple transient signal rather than a retained message. This solves the RabbitMQ late-subscriber problem where restarting processes never received the current config because their fresh queue had no historical messages. Key changes: - ConfigPush schema: config dict replaced with types list - Subscribe-then-fetch startup with retry: processors subscribe to notify queue, fetch config via request/response, then process buffered notifies with version comparison to avoid race conditions - register_config_handler() accepts optional types parameter so handlers only fire when their config types change - Short-lived config request/response clients to avoid subscriber contention on non-persistent response topics - Config service passes affected types through put/delete/flow operations - Gateway ConfigReceiver rewritten with same notify pattern and retry loop Tests updated New tests: - register_config_handler: without types, with types, multiple types, multiple handlers - on_config_notify: old/same version skipped, irrelevant types skipped (version still updated), relevant type triggers fetch, handler without types always called, mixed handler filtering, empty types invokes all, fetch failure handled gracefully - fetch_config: returns config+version, raises on error response, stops client even on exception - fetch_and_apply_config: applies to all handlers on startup, retries on failure
164 lines
5.7 KiB
Python
164 lines
5.7 KiB
Python
"""
|
|
Tests for queue naming and topic mapping.
|
|
"""
|
|
|
|
import pytest
|
|
import argparse
|
|
|
|
from trustgraph.schema.core.topic import queue
|
|
from trustgraph.base.pubsub import get_pubsub, add_pubsub_args
|
|
from trustgraph.base.pulsar_backend import PulsarBackend
|
|
|
|
|
|
class TestQueueFunction:
|
|
|
|
def test_flow_default(self):
|
|
assert queue('text-completion-request') == 'flow:tg:text-completion-request'
|
|
|
|
def test_request_class(self):
|
|
assert queue('config', cls='request') == 'request:tg:config'
|
|
|
|
def test_response_class(self):
|
|
assert queue('config', cls='response') == 'response:tg:config'
|
|
|
|
def test_state_class(self):
|
|
assert queue('config', cls='state') == 'state:tg:config'
|
|
|
|
def test_custom_topicspace(self):
|
|
assert queue('config', cls='request', topicspace='prod') == 'request:prod:config'
|
|
|
|
def test_default_class_is_flow(self):
|
|
result = queue('something')
|
|
assert result.startswith('flow:')
|
|
|
|
|
|
class TestPulsarMapTopic:
|
|
|
|
@pytest.fixture
|
|
def backend(self):
|
|
"""Create a PulsarBackend without connecting."""
|
|
b = object.__new__(PulsarBackend)
|
|
return b
|
|
|
|
def test_flow_maps_to_persistent(self, backend):
|
|
assert backend.map_topic('flow:tg:text-completion-request') == \
|
|
'persistent://tg/flow/text-completion-request'
|
|
|
|
def test_state_maps_to_persistent(self, backend):
|
|
assert backend.map_topic('state:tg:config') == \
|
|
'persistent://tg/state/config'
|
|
|
|
def test_request_maps_to_non_persistent(self, backend):
|
|
assert backend.map_topic('request:tg:config') == \
|
|
'non-persistent://tg/request/config'
|
|
|
|
def test_response_maps_to_non_persistent(self, backend):
|
|
assert backend.map_topic('response:tg:librarian') == \
|
|
'non-persistent://tg/response/librarian'
|
|
|
|
def test_passthrough_pulsar_uri(self, backend):
|
|
uri = 'persistent://tg/flow/something'
|
|
assert backend.map_topic(uri) == uri
|
|
|
|
def test_invalid_format_raises(self, backend):
|
|
with pytest.raises(ValueError, match="Invalid queue format"):
|
|
backend.map_topic('bad-format')
|
|
|
|
def test_invalid_class_raises(self, backend):
|
|
with pytest.raises(ValueError, match="Invalid queue class"):
|
|
backend.map_topic('unknown:tg:topic')
|
|
|
|
def test_custom_topicspace(self, backend):
|
|
assert backend.map_topic('flow:prod:my-queue') == \
|
|
'persistent://prod/flow/my-queue'
|
|
|
|
|
|
class TestGetPubsubDispatch:
|
|
|
|
def test_unknown_backend_raises(self):
|
|
with pytest.raises(ValueError, match="Unknown pub/sub backend"):
|
|
get_pubsub(pubsub_backend='redis')
|
|
|
|
|
|
class TestAddPubsubArgs:
|
|
|
|
def test_standalone_defaults_to_localhost(self):
|
|
parser = argparse.ArgumentParser()
|
|
add_pubsub_args(parser, standalone=True)
|
|
args = parser.parse_args([])
|
|
assert args.pulsar_host == 'pulsar://localhost:6650'
|
|
assert args.pulsar_listener == 'localhost'
|
|
|
|
def test_non_standalone_defaults_to_container(self):
|
|
parser = argparse.ArgumentParser()
|
|
add_pubsub_args(parser, standalone=False)
|
|
args = parser.parse_args([])
|
|
assert 'pulsar:6650' in args.pulsar_host
|
|
assert args.pulsar_listener is None
|
|
|
|
def test_cli_override_respected(self):
|
|
parser = argparse.ArgumentParser()
|
|
add_pubsub_args(parser, standalone=True)
|
|
args = parser.parse_args(['--pulsar-host', 'pulsar://custom:6650'])
|
|
assert args.pulsar_host == 'pulsar://custom:6650'
|
|
|
|
def test_pubsub_backend_default(self):
|
|
parser = argparse.ArgumentParser()
|
|
add_pubsub_args(parser)
|
|
args = parser.parse_args([])
|
|
assert args.pubsub_backend == 'pulsar'
|
|
|
|
|
|
class TestAddPubsubArgsRabbitMQ:
|
|
|
|
def test_rabbitmq_args_present(self):
|
|
parser = argparse.ArgumentParser()
|
|
add_pubsub_args(parser)
|
|
args = parser.parse_args([
|
|
'--pubsub-backend', 'rabbitmq',
|
|
'--rabbitmq-host', 'myhost',
|
|
'--rabbitmq-port', '5673',
|
|
])
|
|
assert args.pubsub_backend == 'rabbitmq'
|
|
assert args.rabbitmq_host == 'myhost'
|
|
assert args.rabbitmq_port == 5673
|
|
|
|
def test_rabbitmq_defaults_container(self):
|
|
parser = argparse.ArgumentParser()
|
|
add_pubsub_args(parser)
|
|
args = parser.parse_args([])
|
|
assert args.rabbitmq_host == 'rabbitmq'
|
|
assert args.rabbitmq_port == 5672
|
|
assert args.rabbitmq_username == 'guest'
|
|
assert args.rabbitmq_password == 'guest'
|
|
assert args.rabbitmq_vhost == '/'
|
|
|
|
def test_rabbitmq_standalone_defaults_to_localhost(self):
|
|
parser = argparse.ArgumentParser()
|
|
add_pubsub_args(parser, standalone=True)
|
|
args = parser.parse_args([])
|
|
assert args.rabbitmq_host == 'localhost'
|
|
|
|
|
|
class TestQueueDefinitions:
|
|
"""Verify the actual queue constants produce correct names."""
|
|
|
|
def test_config_request(self):
|
|
from trustgraph.schema.services.config import config_request_queue
|
|
assert config_request_queue == 'request:tg:config'
|
|
|
|
def test_config_response(self):
|
|
from trustgraph.schema.services.config import config_response_queue
|
|
assert config_response_queue == 'response:tg:config'
|
|
|
|
def test_config_push(self):
|
|
from trustgraph.schema.services.config import config_push_queue
|
|
assert config_push_queue == 'flow:tg:config'
|
|
|
|
def test_librarian_request(self):
|
|
from trustgraph.schema.services.library import librarian_request_queue
|
|
assert librarian_request_queue == 'request:tg:librarian'
|
|
|
|
def test_knowledge_request(self):
|
|
from trustgraph.schema.knowledge.knowledge import knowledge_request_queue
|
|
assert knowledge_request_queue == 'request:tg:knowledge'
|