apunkt/trustgraph
1
0
Fork 0
mirror of https://github.com/trustgraph-ai/trustgraph.git synced 2026-04-25 00:16:23 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
trustgraph/tests
History
Exact
Cyber MacGeddon bcd7a1694a fix: ontology extractor reads .objects, not .object, from PromptResult 
The extract-with-ontologies prompt is a JSONL prompt, which means the
prompt service returns a PromptResult with response_type="jsonl" and
the parsed items in `.objects` (plural).  The ontology extractor was
reading `.object` (singular) — the field used for response_type="json"
— which is always None for JSONL prompts.

Effect: the parser received None on every chunk, hit its "Unexpected
response type: <class 'NoneType'>" branch, returned no ExtractionResult,
and extract_with_simplified_format returned []. Every extraction
silently produced zero triples.

Graphs populated only with the seed ontology schema (TBox) and
document/chunk provenance — no instance triples at all.  The e2e test
threshold of >=100 edges per collection was met by schema + provenance
alone, so the failure mode was invisible until RAG queries couldn't
find any content.

Regression introduced in v2.3 with the token-usage work (commit
56d700f3 / 14e49d83) when PromptClient.prompt() began returning a
PromptResult wrapper instead of the raw text/dict/list.  All other
call sites of .prompt() across retrieval/, agent/, orchestrator/ were
already reading the correct field for their prompt's response_type;
ontology extraction was the sole stranded caller.

Also adds tests/unit/test_extract/test_ontology/test_extract_with_simplified_format.py
covering:
  - happy path: populated .objects produces non-empty triples
  - production failure shape: .objects=None returns [] cleanly
  - empty .objects returns [] without raising
  - defensive: do not silently fall back to .object for a JSONL prompt
2026-04-22 12:02:03 +01:00
..
contract Add agent explainability instrumentation and unify envelope field naming (#795) 2026-04-13 16:16:42 +01:00
integration Fix tests broken by the recent RabbitMQ/Cassandra async fixes (#815) 2026-04-16 10:00:18 +01:00
unit fix: ontology extractor reads .objects, not .object, from PromptResult 2026-04-22 12:02:03 +01:00
utils Add agent explainability instrumentation and unify envelope field naming (#795) 2026-04-13 16:16:42 +01:00
__init__.py Test suite executed from CI pipeline (#433) 2025-07-14 14:57:44 +01:00
conftest.py Feat: TrustGraph i18n & Documentation Translation Updates (#781) 2026-04-14 12:08:32 +01:00
pytest.ini Fix tests broken by the recent RabbitMQ/Cassandra async fixes (#815) 2026-04-16 10:00:18 +01:00
requirements.txt Test suite executed from CI pipeline (#433) 2025-07-14 14:57:44 +01:00