mirror of
https://github.com/trustgraph-ai/trustgraph.git
synced 2026-07-08 04:42:11 +02:00
fix: publisher not cleaned up on error in load_document (#871)
Wrap publisher send in try/finally so that pub.stop() is always called, even if pub.send() raises an exception. This matches the existing pattern used in emit_document_provenance (lines 345-361). Also expanded the FIXME comment on the asyncio.sleep(1) to clarify what it may be compensating for and that further investigation is needed.
This commit is contained in:
parent
1ffae12559
commit
f9ce373b70
1 changed files with 10 additions and 6 deletions
|
|
@ -418,14 +418,18 @@ class Processor(AsyncProcessor):
|
|||
self.pubsub, q, schema=schema
|
||||
)
|
||||
|
||||
await pub.start()
|
||||
try:
|
||||
await pub.start()
|
||||
|
||||
# FIXME: Time wait kludge?
|
||||
await asyncio.sleep(1)
|
||||
# FIXME: Time wait kludge?
|
||||
# This sleep may be compensating for async startup timing in the
|
||||
# underlying pubsub producer. Further investigation is needed to
|
||||
# determine if it can be removed.
|
||||
await asyncio.sleep(1)
|
||||
|
||||
await pub.send(None, doc)
|
||||
|
||||
await pub.stop()
|
||||
await pub.send(None, doc)
|
||||
finally:
|
||||
await pub.stop()
|
||||
|
||||
logger.debug("Document submitted")
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue