From d2e3e317b720ab12a03e1289c3a24e9ba6bace8a Mon Sep 17 00:00:00 2001
From: Cyber MacGeddon <cybermaggedon@gmail.com>
Date: Tue, 16 Sep 2025 23:49:35 +0100
Subject: [PATCH] Fixed tests

---
 .../test_structured_diag/test_schema_selection.py           | 6 ++++++
 .../trustgraph/messaging/translators/diagnosis.py           | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/tests/unit/test_retrieval/test_structured_diag/test_schema_selection.py b/tests/unit/test_retrieval/test_structured_diag/test_schema_selection.py
index 2a18287d..8ce1b97e 100644
--- a/tests/unit/test_retrieval/test_structured_diag/test_schema_selection.py
+++ b/tests/unit/test_retrieval/test_structured_diag/test_schema_selection.py
@@ -123,6 +123,7 @@ async def test_schema_selection_success(service, mock_flow):
     mock_response = MagicMock()
     mock_response.error = None
     mock_response.text = '["products", "orders"]'
+    mock_response.object = None  # Explicitly set to None
     prompt_request_flow.return_value = mock_response
 
     # Create request
@@ -162,6 +163,7 @@ async def test_schema_selection_empty_response(service, mock_flow):
     mock_response = MagicMock()
     mock_response.error = None
     mock_response.text = ""
+    mock_response.object = ""  # Both fields empty
     prompt_request_flow.return_value = mock_response
 
     # Create request
@@ -219,6 +221,7 @@ async def test_schema_selection_invalid_json(service, mock_flow):
     mock_response = MagicMock()
     mock_response.error = None
     mock_response.text = "not valid json"
+    mock_response.object = None
     prompt_request_flow.return_value = mock_response
 
     # Create request
@@ -246,6 +249,7 @@ async def test_schema_selection_non_array_response(service, mock_flow):
     mock_response = MagicMock()
     mock_response.error = None
     mock_response.text = '{"schema": "products"}'  # Object instead of array
+    mock_response.object = None
     prompt_request_flow.return_value = mock_response
 
     # Create request
@@ -273,6 +277,7 @@ async def test_schema_selection_with_options(service, mock_flow):
     mock_response = MagicMock()
     mock_response.error = None
     mock_response.text = '["products"]'
+    mock_response.object = None
     prompt_request_flow.return_value = mock_response
 
     # Create request with options
@@ -333,6 +338,7 @@ async def test_schema_selection_empty_schemas(service, mock_flow):
     mock_response = MagicMock()
     mock_response.error = None
     mock_response.text = '[]'
+    mock_response.object = None
     prompt_request_flow.return_value = mock_response
 
     # Create request
diff --git a/trustgraph-base/trustgraph/messaging/translators/diagnosis.py b/trustgraph-base/trustgraph/messaging/translators/diagnosis.py
index f4dbdbed..92bad16f 100644
--- a/trustgraph-base/trustgraph/messaging/translators/diagnosis.py
+++ b/trustgraph-base/trustgraph/messaging/translators/diagnosis.py
@@ -57,7 +57,7 @@ class StructuredDataDiagnosisResponseTranslator(MessageTranslator):
                 result["descriptor"] = obj.descriptor
         if obj.metadata:
             result["metadata"] = obj.metadata
-        if obj.schema_matches:
+        if obj.schema_matches is not None:
             result["schema-matches"] = obj.schema_matches
 
         return result