Fixed tests

This commit is contained in:
Cyber MacGeddon 2025-09-03 16:02:52 +01:00
parent 8667e604cc
commit cb887a6861

View file

@ -144,7 +144,7 @@ class TestObjectsWriterConfiguration:
mock_cluster.return_value = mock_cluster_instance
with patch.dict(os.environ, env_vars, clear=True):
processor = ObjectsWriter()
processor = ObjectsWriter(taskgroup=MagicMock())
processor.connect_cassandra()
# Verify auth provider was created with correct credentials
@ -182,6 +182,7 @@ class TestTriplesQueryConfiguration:
def test_mixed_old_new_parameters(self, mock_trust_graph):
"""Test mixing old and new parameter names (new should win)."""
processor = TriplesQuery(
taskgroup=MagicMock(),
cassandra_host='new-host',
graph_host='old-host',
cassandra_username='new-user',
@ -196,7 +197,7 @@ class TestTriplesQueryConfiguration:
class TestKgStoreConfiguration:
"""Test Cassandra configuration in knowledge store processor."""
@patch('trustgraph.tables.knowledge.KnowledgeTableStore')
@patch('trustgraph.storage.knowledge.store.KnowledgeTableStore')
def test_environment_variable_configuration(self, mock_table_store):
"""Test kg-store picks up configuration from environment variables."""
env_vars = {
@ -219,13 +220,14 @@ class TestKgStoreConfiguration:
keyspace='knowledge'
)
@patch('trustgraph.tables.knowledge.KnowledgeTableStore')
@patch('trustgraph.storage.knowledge.store.KnowledgeTableStore')
def test_explicit_parameters(self, mock_table_store):
"""Test kg-store with explicit parameters."""
mock_store_instance = MagicMock()
mock_table_store.return_value = mock_store_instance
processor = KgStore(
taskgroup=MagicMock(),
cassandra_host='explicit-host',
cassandra_username='explicit-user',
cassandra_password='explicit-pass'
@ -239,13 +241,14 @@ class TestKgStoreConfiguration:
keyspace='knowledge'
)
@patch('trustgraph.tables.knowledge.KnowledgeTableStore')
@patch('trustgraph.storage.knowledge.store.KnowledgeTableStore')
def test_backward_compatibility_cassandra_user(self, mock_table_store):
"""Test backward compatibility with cassandra_user parameter."""
mock_store_instance = MagicMock()
mock_table_store.return_value = mock_store_instance
processor = KgStore(
taskgroup=MagicMock(),
cassandra_host='compat-host',
cassandra_user='compat-user', # Old parameter name
cassandra_password='compat-pass'
@ -259,7 +262,7 @@ class TestKgStoreConfiguration:
keyspace='knowledge'
)
@patch('trustgraph.tables.knowledge.KnowledgeTableStore')
@patch('trustgraph.storage.knowledge.store.KnowledgeTableStore')
def test_default_configuration(self, mock_table_store):
"""Test kg-store default configuration."""
mock_store_instance = MagicMock()
@ -359,13 +362,17 @@ class TestCommandLineArgumentHandling:
help_text = parser.format_help()
# Should show environment variable values (except password)
assert 'help-host1,help-host2' in help_text
# Help text may have line breaks - argparse breaks long lines
# So check for the components that should be there
assert 'help-' in help_text and 'host1' in help_text
assert 'help-host2' in help_text
assert 'help-user' in help_text
assert '<set>' in help_text # Password should be hidden
assert 'help-pass' not in help_text # Password value not shown
assert '[from CASSANDRA_HOST]' in help_text
assert '[from CASSANDRA_USERNAME]' in help_text
assert '[from CASSANDRA_PASSWORD]' in help_text
# Check key components (may be split across lines by argparse)
assert '[from' in help_text and 'CASSANDRA_USERNAME]' in help_text
assert '[from' in help_text and 'CASSANDRA_PASSWORD]' in help_text
class TestConfigurationPriorityIntegration:
@ -383,6 +390,7 @@ class TestConfigurationPriorityIntegration:
with patch.dict(os.environ, env_vars, clear=True):
# Explicit parameters should override environment
processor = TriplesWriter(
taskgroup=MagicMock(),
cassandra_host='cli-host1,cli-host2',
cassandra_username='cli-user'
# Password not provided - should fall back to env
@ -392,7 +400,7 @@ class TestConfigurationPriorityIntegration:
assert processor.username == 'cli-user' # From CLI
assert processor.password == 'env-pass' # From env
@patch('trustgraph.tables.knowledge.KnowledgeTableStore')
@patch('trustgraph.storage.knowledge.store.KnowledgeTableStore')
def test_kg_store_priority_chain(self, mock_table_store):
"""Test configuration priority chain in kg-store processor."""
mock_store_instance = MagicMock()
@ -406,6 +414,7 @@ class TestConfigurationPriorityIntegration:
with patch.dict(os.environ, env_vars, clear=True):
processor = KgStore(
taskgroup=MagicMock(),
cassandra_host='param-host'
# username and password not provided - should use env
)