apunkt/trustgraph
1
0
Fork 0
mirror of https://github.com/trustgraph-ai/trustgraph.git synced 2026-04-26 00:46:22 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix incorrect property names in explainability (#698)

Browse source 
Remove type suffixes from explainability dataclass fields + fix show_explain_trace

Rename dataclass fields to match KG property naming conventions:
- Analysis: thought_uri/observation_uri → thought/observation
- Synthesis/Conclusion/Reflection: document_uri → document

Fix show_explain_trace for current API:
- Resolve document content via librarian fetch instead of removed
  inline content fields (synthesis.content, conclusion.answer)
- Add Grounding display for DocRAG traces
- Update fetch_docrag_trace chain: Question → Grounding → Exploration →
Synthesis
- Pass api/explain_client to all print functions for content resolution

Update all CLI tools and tests for renamed fields.
This commit is contained in:
cybermaggedon 2026-03-16 14:47:37 +00:00 • committed by GitHub
parent a115ec06ab
commit c387670944
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 122 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

16
tests/unit/test_provenance/test_explainability.py
View file

@ -142,7 +142,7 @@ class TestExplainEntityFromTriples:
]
entity = ExplainEntity.from_triples("urn:syn:1", triples)
assert isinstance(entity, Synthesis)
assert entity.document_uri == "urn:doc:answer-1"
assert entity.document == "urn:doc:answer-1"
def test_synthesis_no_document(self):
triples = [
@ -150,7 +150,7 @@ class TestExplainEntityFromTriples:
]
entity = ExplainEntity.from_triples("urn:syn:2", triples)
assert isinstance(entity, Synthesis)
assert entity.document_uri == ""
assert entity.document == ""
def test_reflection_thought(self):
triples = [
@ -161,7 +161,7 @@ class TestExplainEntityFromTriples:
entity = ExplainEntity.from_triples("urn:ref:1", triples)
assert isinstance(entity, Reflection)
assert entity.reflection_type == "thought"
assert entity.document_uri == "urn:doc:thought-1"
assert entity.document == "urn:doc:thought-1"
def test_reflection_observation(self):
triples = [
@ -172,7 +172,7 @@ class TestExplainEntityFromTriples:
entity = ExplainEntity.from_triples("urn:ref:2", triples)
assert isinstance(entity, Reflection)
assert entity.reflection_type == "observation"
assert entity.document_uri == "urn:doc:obs-1"
assert entity.document == "urn:doc:obs-1"
def test_analysis(self):
triples = [
@ -186,8 +186,8 @@ class TestExplainEntityFromTriples:
assert isinstance(entity, Analysis)
assert entity.action == "graph-rag-query"
assert entity.arguments == '{"query": "test"}'
assert entity.thought_uri == "urn:ref:thought-1"
assert entity.observation_uri == "urn:ref:obs-1"
assert entity.thought == "urn:ref:thought-1"
assert entity.observation == "urn:ref:obs-1"
def test_conclusion_with_document(self):
triples = [
@ -196,7 +196,7 @@ class TestExplainEntityFromTriples:
]
entity = ExplainEntity.from_triples("urn:conc:1", triples)
assert isinstance(entity, Conclusion)
assert entity.document_uri == "urn:doc:final"
assert entity.document == "urn:doc:final"
def test_conclusion_no_document(self):
triples = [
@ -204,7 +204,7 @@ class TestExplainEntityFromTriples:
]
entity = ExplainEntity.from_triples("urn:conc:2", triples)
assert isinstance(entity, Conclusion)
assert entity.document_uri == ""
assert entity.document == ""
def test_unknown_type(self):
triples = [