Fix unit tests

This commit is contained in:
Cyber MacGeddon 2025-12-18 21:58:48 +00:00
parent dcf7e69f70
commit ad247bab64
2 changed files with 46 additions and 59 deletions

View file

@ -291,8 +291,8 @@ class TestConfigReceiver:
# Verify Consumer was created with correct parameters # Verify Consumer was created with correct parameters
mock_consumer_class.assert_called_once() mock_consumer_class.assert_called_once()
call_args = mock_consumer_class.call_args call_args = mock_consumer_class.call_args
assert call_args[1]['client'] == mock_backend assert call_args[1]['backend'] == mock_backend
assert call_args[1]['subscriber'] == "gateway-test-uuid" assert call_args[1]['subscriber'] == "gateway-test-uuid"
assert call_args[1]['handler'] == config_receiver.on_config assert call_args[1]['handler'] == config_receiver.on_config
assert call_args[1]['start_of_messages'] is True assert call_args[1]['start_of_messages'] is True

View file

@ -19,23 +19,21 @@ class TestApi:
def test_api_initialization_with_defaults(self): def test_api_initialization_with_defaults(self):
"""Test Api initialization with default values""" """Test Api initialization with default values"""
with patch('pulsar.Client') as mock_client: with patch('trustgraph.gateway.service.get_pubsub') as mock_get_pubsub:
mock_client.return_value = Mock() mock_backend = Mock()
mock_get_pubsub.return_value = mock_backend
api = Api() api = Api()
assert api.port == default_port assert api.port == default_port
assert api.timeout == default_timeout assert api.timeout == default_timeout
assert api.pulsar_host == default_pulsar_host assert api.pulsar_host == default_pulsar_host
assert api.pulsar_api_key is None assert api.pulsar_api_key is None
assert api.prometheus_url == default_prometheus_url + "/" assert api.prometheus_url == default_prometheus_url + "/"
assert api.auth.allow_all is True assert api.auth.allow_all is True
# Verify Pulsar client was created without API key # Verify get_pubsub was called
mock_client.assert_called_once_with( mock_get_pubsub.assert_called_once()
default_pulsar_host,
listener_name=None
)
def test_api_initialization_with_custom_config(self): def test_api_initialization_with_custom_config(self):
"""Test Api initialization with custom configuration""" """Test Api initialization with custom configuration"""
@ -48,14 +46,13 @@ class TestApi:
"prometheus_url": "http://custom-prometheus:9090", "prometheus_url": "http://custom-prometheus:9090",
"api_token": "secret-token" "api_token": "secret-token"
} }
with patch('pulsar.Client') as mock_client, \ with patch('trustgraph.gateway.service.get_pubsub') as mock_get_pubsub:
patch('pulsar.AuthenticationToken') as mock_auth: mock_backend = Mock()
mock_client.return_value = Mock() mock_get_pubsub.return_value = mock_backend
mock_auth.return_value = Mock()
api = Api(**config) api = Api(**config)
assert api.port == 9000 assert api.port == 9000
assert api.timeout == 300 assert api.timeout == 300
assert api.pulsar_host == "pulsar://custom-host:6650" assert api.pulsar_host == "pulsar://custom-host:6650"
@ -63,35 +60,25 @@ class TestApi:
assert api.prometheus_url == "http://custom-prometheus:9090/" assert api.prometheus_url == "http://custom-prometheus:9090/"
assert api.auth.token == "secret-token" assert api.auth.token == "secret-token"
assert api.auth.allow_all is False assert api.auth.allow_all is False
# Verify Pulsar client was created with API key # Verify get_pubsub was called with config
mock_auth.assert_called_once_with("test-api-key") mock_get_pubsub.assert_called_once_with(**config)
mock_client.assert_called_once_with(
"pulsar://custom-host:6650",
listener_name="custom-listener",
authentication=mock_auth.return_value
)
def test_api_initialization_with_pulsar_api_key(self): def test_api_initialization_with_pulsar_api_key(self):
"""Test Api initialization with Pulsar API key authentication""" """Test Api initialization with Pulsar API key authentication"""
with patch('pulsar.Client') as mock_client, \ with patch('trustgraph.gateway.service.get_pubsub') as mock_get_pubsub:
patch('pulsar.AuthenticationToken') as mock_auth: mock_get_pubsub.return_value = Mock()
mock_client.return_value = Mock()
mock_auth.return_value = Mock()
api = Api(pulsar_api_key="test-key") api = Api(pulsar_api_key="test-key")
mock_auth.assert_called_once_with("test-key") # Verify api key was stored
mock_client.assert_called_once_with( assert api.pulsar_api_key == "test-key"
default_pulsar_host, mock_get_pubsub.assert_called_once()
listener_name=None,
authentication=mock_auth.return_value
)
def test_api_initialization_prometheus_url_normalization(self): def test_api_initialization_prometheus_url_normalization(self):
"""Test that prometheus_url gets normalized with trailing slash""" """Test that prometheus_url gets normalized with trailing slash"""
with patch('pulsar.Client') as mock_client: with patch('trustgraph.gateway.service.get_pubsub') as mock_get_pubsub:
mock_client.return_value = Mock() mock_get_pubsub.return_value = Mock()
# Test URL without trailing slash # Test URL without trailing slash
api = Api(prometheus_url="http://prometheus:9090") api = Api(prometheus_url="http://prometheus:9090")
@ -103,16 +90,16 @@ class TestApi:
def test_api_initialization_empty_api_token_means_no_auth(self): def test_api_initialization_empty_api_token_means_no_auth(self):
"""Test that empty API token results in allow_all authentication""" """Test that empty API token results in allow_all authentication"""
with patch('pulsar.Client') as mock_client: with patch('trustgraph.gateway.service.get_pubsub') as mock_get_pubsub:
mock_client.return_value = Mock() mock_get_pubsub.return_value = Mock()
api = Api(api_token="") api = Api(api_token="")
assert api.auth.allow_all is True assert api.auth.allow_all is True
def test_api_initialization_none_api_token_means_no_auth(self): def test_api_initialization_none_api_token_means_no_auth(self):
"""Test that None API token results in allow_all authentication""" """Test that None API token results in allow_all authentication"""
with patch('pulsar.Client') as mock_client: with patch('trustgraph.gateway.service.get_pubsub') as mock_get_pubsub:
mock_client.return_value = Mock() mock_get_pubsub.return_value = Mock()
api = Api(api_token=None) api = Api(api_token=None)
assert api.auth.allow_all is True assert api.auth.allow_all is True
@ -120,8 +107,8 @@ class TestApi:
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_app_factory_creates_application(self): async def test_app_factory_creates_application(self):
"""Test that app_factory creates aiohttp application""" """Test that app_factory creates aiohttp application"""
with patch('pulsar.Client') as mock_client: with patch('trustgraph.gateway.service.get_pubsub') as mock_get_pubsub:
mock_client.return_value = Mock() mock_get_pubsub.return_value = Mock()
api = Api() api = Api()
@ -147,8 +134,8 @@ class TestApi:
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_app_factory_with_custom_endpoints(self): async def test_app_factory_with_custom_endpoints(self):
"""Test app_factory with custom endpoints""" """Test app_factory with custom endpoints"""
with patch('pulsar.Client') as mock_client: with patch('trustgraph.gateway.service.get_pubsub') as mock_get_pubsub:
mock_client.return_value = Mock() mock_get_pubsub.return_value = Mock()
api = Api() api = Api()
@ -180,13 +167,13 @@ class TestApi:
def test_run_method_calls_web_run_app(self): def test_run_method_calls_web_run_app(self):
"""Test that run method calls web.run_app""" """Test that run method calls web.run_app"""
with patch('pulsar.Client') as mock_client, \ with patch('trustgraph.gateway.service.get_pubsub') as mock_get_pubsub, \
patch('aiohttp.web.run_app') as mock_run_app: patch('aiohttp.web.run_app') as mock_run_app:
mock_client.return_value = Mock() mock_get_pubsub.return_value = Mock()
api = Api(port=8080) api = Api(port=8080)
api.run() api.run()
# Verify run_app was called once with the correct port # Verify run_app was called once with the correct port
mock_run_app.assert_called_once() mock_run_app.assert_called_once()
args, kwargs = mock_run_app.call_args args, kwargs = mock_run_app.call_args
@ -195,19 +182,19 @@ class TestApi:
def test_api_components_initialization(self): def test_api_components_initialization(self):
"""Test that all API components are properly initialized""" """Test that all API components are properly initialized"""
with patch('pulsar.Client') as mock_client: with patch('trustgraph.gateway.service.get_pubsub') as mock_get_pubsub:
mock_client.return_value = Mock() mock_get_pubsub.return_value = Mock()
api = Api() api = Api()
# Verify all components are initialized # Verify all components are initialized
assert api.config_receiver is not None assert api.config_receiver is not None
assert api.dispatcher_manager is not None assert api.dispatcher_manager is not None
assert api.endpoint_manager is not None assert api.endpoint_manager is not None
assert api.endpoints == [] assert api.endpoints == []
# Verify component relationships # Verify component relationships
assert api.dispatcher_manager.backend == api.backend assert api.dispatcher_manager.backend == api.pubsub_backend
assert api.dispatcher_manager.config_receiver == api.config_receiver assert api.dispatcher_manager.config_receiver == api.config_receiver
assert api.endpoint_manager.dispatcher_manager == api.dispatcher_manager assert api.endpoint_manager.dispatcher_manager == api.dispatcher_manager
# EndpointManager doesn't store auth directly, it passes it to individual endpoints # EndpointManager doesn't store auth directly, it passes it to individual endpoints