apunkt/trustgraph
1
0
Fork 0
mirror of https://github.com/trustgraph-ai/trustgraph.git synced 2026-05-06 05:42:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix websocket error responses in Mux dispatcher (#726)

Browse source 
Error responses from the websocket multiplexer were missing the
request ID and using a bare string format instead of the structured
error protocol. This caused clients to hang when a request failed
(e.g. unsupported service for a flow) because the error could not
be routed to the waiting caller.

Include request ID in all error paths, use structured error format
({message, type}) with complete flag, and extract the ID early in
receive() so even malformed requests get a routable error when
possible.

Updated tests - tests were coded against invalid protocol messages
This commit is contained in:
cybermaggedon 2026-03-28 10:58:28 +00:00 • committed by GitHub
parent ea33620fb2
commit a634520509
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 48 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

33
trustgraph-flow/trustgraph/gateway/dispatch/mux.py
View file

@ -33,9 +33,12 @@ class Mux:
async def receive(self, msg):
request_id = None
try:
data = msg.json()
request_id = data.get("id")
if "request" not in data:
raise RuntimeError("Bad message")
@ -51,7 +54,13 @@ class Mux:
except Exception as e:
logger.error(f"Receive exception: {str(e)}", exc_info=True)
await self.ws.send_json({"error": str(e)})
error_resp = {
"error": {"message": str(e), "type": "error"},
"complete": True,
}
if request_id:
error_resp["id"] = request_id
await self.ws.send_json(error_resp)
async def maybe_tidy_workers(self, workers):
@ -97,12 +106,12 @@ class Mux:
})
worker = asyncio.create_task(
self.request_task(request, responder, flow, svc)
self.request_task(id, request, responder, flow, svc)
)
workers.append(worker)
async def request_task(self, request, responder, flow, svc):
async def request_task(self, id, request, responder, flow, svc):
try:
@ -119,7 +128,11 @@ class Mux:
)
except Exception as e:
await self.ws.send_json({"error": str(e)})
await self.ws.send_json({
"id": id,
"error": {"message": str(e), "type": "error"},
"complete": True,
})
async def run(self):
@ -143,7 +156,11 @@ class Mux:
except Exception as e:
# This is an internal working error, may not be recoverable
logger.error(f"Run prepare exception: {e}", exc_info=True)
await self.ws.send_json({"id": id, "error": str(e)})
await self.ws.send_json({
"id": id,
"error": {"message": str(e), "type": "error"},
"complete": True,
})
self.running.stop()
if self.ws:
@ -160,7 +177,11 @@ class Mux:
except Exception as e:
logger.error(f"Exception in mux: {e}", exc_info=True)
await self.ws.send_json({"error": str(e)})
await self.ws.send_json({
"id": id,
"error": {"message": str(e), "type": "error"},
"complete": True,
})
self.running.stop()