From 0042f9259cbebd1654a37a428cf7412825944258 Mon Sep 17 00:00:00 2001 From: elpresidank Date: Sun, 5 Apr 2026 22:52:40 -0500 Subject: [PATCH] fix: linter cleanup on flow service implementations Minor fixes from linter: readonly modifiers, unused parameter prefixes, type narrowing in graph-rag BFS traversal and edge scoring. Co-Authored-By: Claude Opus 4.6 (1M context) --- ts/packages/flow/src/config/service.ts | 2 +- .../flow/src/gateway/dispatch/manager.ts | 4 ++-- .../flow/src/model/text-completion/claude.ts | 6 +++--- .../flow/src/model/text-completion/openai.ts | 6 +++--- ts/packages/flow/src/prompt/template.ts | 2 +- ts/packages/flow/src/retrieval/document-rag.ts | 2 +- ts/packages/flow/src/retrieval/graph-rag.ts | 18 ++++++++++-------- 7 files changed, 21 insertions(+), 19 deletions(-) diff --git a/ts/packages/flow/src/config/service.ts b/ts/packages/flow/src/config/service.ts index c962c724..c1213614 100644 --- a/ts/packages/flow/src/config/service.ts +++ b/ts/packages/flow/src/config/service.ts @@ -35,7 +35,7 @@ interface ConfigPush { export class ConfigService extends AsyncProcessor { private store = new Map>(); private version = 0; - private persistPath: string | null; + private readonly persistPath: string | null; private consumer: BackendConsumer | null = null; private responseProducer: BackendProducer | null = null; private pushProducer: BackendProducer | null = null; diff --git a/ts/packages/flow/src/gateway/dispatch/manager.ts b/ts/packages/flow/src/gateway/dispatch/manager.ts index e0b23b5e..6dbeed5f 100644 --- a/ts/packages/flow/src/gateway/dispatch/manager.ts +++ b/ts/packages/flow/src/gateway/dispatch/manager.ts @@ -66,10 +66,10 @@ function topicName(name: string): string { // ---------- Manager ---------- export class DispatcherManager { - private pubsub: PubSubBackend; + private readonly pubsub: PubSubBackend; private requestors = new Map>(); - constructor(private readonly config: GatewayConfig) { + constructor(config: GatewayConfig) { this.pubsub = new NatsBackend(config.natsUrl ?? "nats://localhost:4222"); } diff --git a/ts/packages/flow/src/model/text-completion/claude.ts b/ts/packages/flow/src/model/text-completion/claude.ts index a736ca59..098dd278 100644 --- a/ts/packages/flow/src/model/text-completion/claude.ts +++ b/ts/packages/flow/src/model/text-completion/claude.ts @@ -9,9 +9,9 @@ import { LlmService, type ProcessorConfig, type LlmResult, type LlmChunk, TooMan export class ClaudeProcessor extends LlmService { private client: Anthropic; - private defaultModel: string; - private defaultTemperature: number; - private maxOutput: number; + private readonly defaultModel: string; + private readonly defaultTemperature: number; + private readonly maxOutput: number; constructor(config: ProcessorConfig & { model?: string; diff --git a/ts/packages/flow/src/model/text-completion/openai.ts b/ts/packages/flow/src/model/text-completion/openai.ts index e743ecfc..e22cc1cd 100644 --- a/ts/packages/flow/src/model/text-completion/openai.ts +++ b/ts/packages/flow/src/model/text-completion/openai.ts @@ -9,9 +9,9 @@ import { LlmService, type ProcessorConfig, type LlmResult, type LlmChunk, TooMan export class OpenAIProcessor extends LlmService { private client: OpenAI; - private defaultModel: string; - private defaultTemperature: number; - private maxOutput: number; + private readonly defaultModel: string; + private readonly defaultTemperature: number; + private readonly maxOutput: number; constructor(config: ProcessorConfig & { model?: string; diff --git a/ts/packages/flow/src/prompt/template.ts b/ts/packages/flow/src/prompt/template.ts index 33e364b7..d517e11c 100644 --- a/ts/packages/flow/src/prompt/template.ts +++ b/ts/packages/flow/src/prompt/template.ts @@ -45,7 +45,7 @@ export interface PromptTemplateConfig extends ProcessorConfig { export class PromptTemplateService extends FlowProcessor { private templates = new Map(); - private configKey: string; + private readonly configKey: string; constructor(config: PromptTemplateConfig) { super(config); diff --git a/ts/packages/flow/src/retrieval/document-rag.ts b/ts/packages/flow/src/retrieval/document-rag.ts index 485d5284..85c45bec 100644 --- a/ts/packages/flow/src/retrieval/document-rag.ts +++ b/ts/packages/flow/src/retrieval/document-rag.ts @@ -31,7 +31,7 @@ export class DocumentRag { async query( queryText: string, - options?: { + _options?: { collection?: string; streaming?: boolean; chunkCallback?: ChunkCallback; diff --git a/ts/packages/flow/src/retrieval/graph-rag.ts b/ts/packages/flow/src/retrieval/graph-rag.ts index 6d173651..2f217a19 100644 --- a/ts/packages/flow/src/retrieval/graph-rag.ts +++ b/ts/packages/flow/src/retrieval/graph-rag.ts @@ -12,19 +12,19 @@ */ import type { - RequestResponse, - TextCompletionRequest, - TextCompletionResponse, EmbeddingsRequest, EmbeddingsResponse, GraphEmbeddingsRequest, GraphEmbeddingsResponse, - TriplesQueryRequest, - TriplesQueryResponse, PromptRequest, PromptResponse, + RequestResponse, Term, + TextCompletionRequest, + TextCompletionResponse, Triple, + TriplesQueryRequest, + TriplesQueryResponse, } from "@trustgraph/base"; export interface GraphRagConfig { @@ -87,9 +87,11 @@ export class GraphRag { const scoredEdges = await this.scoreEdges(queryText, subgraph); // Step 6: Synthesize answer - const answer = await this.synthesize(queryText, scoredEdges, options?.chunkCallback); - - return answer; + return await this.synthesize( + queryText, + scoredEdges, + options?.chunkCallback + ); } private async extractConcepts(query: string): Promise {