mirror of
https://github.com/rowboatlabs/rowboat.git
synced 2026-07-12 21:02:17 +02:00
Findings from a fresh post-refactor review. The turn-runtime bridges imported convertFromMessages and getToolPermissionMetadata from agents/runtime.ts — the legacy engine file — making it undeletable; both move to neutral modules (agents/message-encoding.ts, agents/permission-metadata.ts) that both engines now share. The abort registry, used by the live tool registry, moves out of the legacy runs/ cluster into turns/. Dead surface goes: the zero-consumer CopilotInstructions, skillCatalog, RunLogger, and MappedToolCall exports are deleted, mapAgentTool/StreamStepMessageBuilder become module-private, and the mid-file import scar from the composer extraction is hoisted. Three review fixes ride along: ITurnEventBus gains subscribe/subscribeAll so consumers stop resolving the concrete hub; skill carry-forward becomes its own registry trait instead of overloading workspaceContext; and connection checks (slack/composio/ code-mode/google) collapse into one shared connections.ts consumed by both skill availability and the copilot prompt blocks — plus stale doc pointers (VIDEO_MODE.md to moved prompt text, CLAUDE.md's dangling AGENTS.md reference). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| core | ||
| shared | ||