mirror of
https://github.com/rowboatlabs/rowboat.git
synced 2026-05-02 11:52:38 +02:00
b9599f2a19
The callback server was acknowledging success before the asynchronous validation/token-exchange path had actually finished, which could leave users looking at a success page while the flow failed in an unhandled rejection. The handler now awaits callback completion and returns an error page when callback processing fails. Constraint: Needs to remain compatible with the existing full-callback-URL OAuth flow added in prior fixes Rejected: Catch-and-log callback errors without changing the response body | preserves the misleading success UX and hides failure state from users Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep the auth callback response coupled to actual callback completion; do not move async failures back onto an unobserved path Tested: pnpm install; pnpm run deps; apps/main npm run build; source-backed auth callback failure validation JSON Not-tested: Live provider OAuth round-trip against real credentials |
||
|---|---|---|
| .. | ||
| cli | ||
| docs | ||
| experimental | ||
| python-sdk | ||
| rowboat | ||
| rowboatx | ||
| x | ||