apunkt/rowboat
1
0
Fork 0
mirror of https://github.com/rowboatlabs/rowboat.git synced 2026-07-24 21:41:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #774 from rowboatlabs/bg_agent_run_failed

Browse source 
Log background agent failure reasons
This commit is contained in:
Ramnique Singh 2026-07-22 10:51:55 +05:30 • committed by GitHub
commit f10bfdf9f1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 29 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
apps/x/ANALYTICS.md
View file

@ -181,7 +181,8 @@ All renderer events live in `apps/renderer/src/lib/analytics.ts` (typed wrappers
- `email_send_failed` — send returned an error or threw (`components/email-view.tsx`) - `email_send_failed` — send returned an error or threw (`components/email-view.tsx`)
- `meeting_summarize_failed` — post-recording notes generation threw (`App.tsx`) - `meeting_summarize_failed` — post-recording notes generation threw (`App.tsx`)
- `bg_agent_run_failed` / `bg_agent_run_completed` — `{ trigger: 'manual' | 'cron' | 'window' | 'event' }` **(core)** — every background-agent run settles as exactly one of these (`packages/core/src/background-tasks/runner.ts`), giving a failure *rate* across all trigger sources, not just manual clicks - `bg_agent_run_failed` — `{ trigger: 'manual' | 'cron' | 'window' | 'event', error: string }` **(core)** — emitted when a background-agent run fails; `error` contains the normalized failure message
- `bg_agent_run_completed` — `{ trigger: 'manual' | 'cron' | 'window' | 'event' }` **(core)** — emitted when a background-agent run succeeds; together these events give a failure *rate* across all trigger sources, not just manual clicks
**Misc**: **Misc**:

29
apps/x/packages/core/src/background-tasks/runner.ts
View file

@ -93,6 +93,10 @@ Your task folder is \`${wsFolder}\`. The user-visible artifact is \`${wsFolder}i
const runningTasks = new Set<string>(); const runningTasks = new Set<string>();
type RunAnalyticsOutcome =
| { event: 'bg_agent_run_completed'; properties: { trigger: BackgroundTaskTriggerType } }
| { event: 'bg_agent_run_failed'; properties: { trigger: BackgroundTaskTriggerType; error: string } };
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
// Public API // Public API
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
@ -114,6 +118,8 @@ export async function runBackgroundTask(
} }
runningTasks.add(slug); runningTasks.add(slug);
let analyticsOutcome: RunAnalyticsOutcome | undefined;
try { try {
const task = await fetchTask(slug); const task = await fetchTask(slug);
if (!task) { if (!task) {
@ -211,7 +217,6 @@ export async function runBackgroundTask(
}); });
log.log(`${slug} — done summary="${truncate(summary)}"`); log.log(`${slug} — done summary="${truncate(summary)}"`);
capture('bg_agent_run_completed', { trigger });
backgroundTaskBus.publish({ backgroundTaskBus.publish({
type: 'background_task_agent_complete', type: 'background_task_agent_complete',
@ -220,10 +225,16 @@ export async function runBackgroundTask(
...(summary ? { summary } : {}), ...(summary ? { summary } : {}),
}); });
analyticsOutcome = { event: 'bg_agent_run_completed', properties: { trigger } };
return { slug, runId, summary }; return { slug, runId, summary };
} catch (err) { } catch (err) {
const msg = err instanceof Error ? err.message : String(err); const msg = err instanceof Error ? err.message : String(err);
analyticsOutcome = {
event: 'bg_agent_run_failed',
properties: { trigger, error: msg },
};
// Failure — only record the error. `lastRunAt` and `lastRunSummary` // Failure — only record the error. `lastRunAt` and `lastRunSummary`
// are deliberately untouched so the user keeps seeing the last good // are deliberately untouched so the user keeps seeing the last good
// state; the scheduler's backoff (lastAttemptAt + 5min) prevents // state; the scheduler's backoff (lastAttemptAt + 5min) prevents
@ -235,7 +246,6 @@ export async function runBackgroundTask(
} }
log.log(`${slug} — failed: ${truncate(msg)}`); log.log(`${slug} — failed: ${truncate(msg)}`);
capture('bg_agent_run_failed', { trigger });
backgroundTaskBus.publish({ backgroundTaskBus.publish({
type: 'background_task_agent_complete', type: 'background_task_agent_complete',
@ -246,7 +256,22 @@ export async function runBackgroundTask(
return { slug, runId, summary: null, error: msg }; return { slug, runId, summary: null, error: msg };
} }
} catch (err) {
// Preserve the original throw behavior for setup/infrastructure errors,
// but still settle analytics for the attempted run. If the agent had
// already failed, keep that original failure reason.
analyticsOutcome ??= {
event: 'bg_agent_run_failed',
properties: {
trigger,
error: err instanceof Error ? err.message : String(err),
},
};
throw err;
} finally { } finally {
if (analyticsOutcome) {
capture(analyticsOutcome.event, analyticsOutcome.properties);
}
runningTasks.delete(slug); runningTasks.delete(slug);
} }
} }