From df72bb2b298961162ed9ec5ccd4d90a3d4d539b3 Mon Sep 17 00:00:00 2001 From: Ramnique Singh <30795890+ramnique@users.noreply.github.com> Date: Thu, 23 Jul 2026 10:38:15 +0530 Subject: [PATCH] fix(ci): use renamed Microsoft.ArtifactSigning.Client NuGet package Microsoft renamed Trusted Signing to Artifact Signing and delisted the old Microsoft.Trusted.Signing.Client package, which broke the setup step. The dlib inside kept its Azure.CodeSigning.Dlib.dll filename; locate it by search instead of a hardcoded path so future package reshuffles fail loudly rather than at a stale path. Co-Authored-By: Claude Fable 5 --- .github/workflows/electron-build.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/electron-build.yml b/.github/workflows/electron-build.yml index 2eed5530..a7f2983a 100644 --- a/.github/workflows/electron-build.yml +++ b/.github/workflows/electron-build.yml @@ -252,10 +252,15 @@ jobs: $dir = "C:\azsign" New-Item -ItemType Directory -Force -Path $dir | Out-Null - # The signtool plugin that delegates signing to Azure Trusted Signing. - nuget install Microsoft.Trusted.Signing.Client -x -OutputDirectory "$dir\nuget" - $dlib = "$dir\nuget\Microsoft.Trusted.Signing.Client\bin\x64\Azure.CodeSigning.Dlib.dll" - if (-not (Test-Path $dlib)) { throw "Azure.CodeSigning.Dlib.dll not found at $dlib" } + # The signtool plugin that delegates signing to Azure Trusted Signing + # (renamed "Artifact Signing" — the old Microsoft.Trusted.Signing.Client + # package is gone from NuGet, but the dlib inside kept its filename). + nuget install Microsoft.ArtifactSigning.Client -x -OutputDirectory "$dir\nuget" + $dlib = Get-ChildItem "$dir\nuget" -Recurse -Filter "Azure.CodeSigning.Dlib.dll" | + Where-Object { $_.FullName -match '\\x64\\' } | + Select-Object -First 1 -ExpandProperty FullName + if (-not $dlib) { throw "x64 Azure.CodeSigning.Dlib.dll not found under $dir\nuget" } + echo "Using dlib: $dlib" # Tells the dlib which account/profile to sign with. @{