From b893700da632082ee79a7c7deeefda5105df0415 Mon Sep 17 00:00:00 2001
From: hrsvrn <harshvardhanvatsa@gmail.com>
Date: Wed, 22 Jul 2026 20:29:47 +0530
Subject: [PATCH] fix(x): default settings dialog tabs to scrollable

Invert the tab scroll logic in the settings dialog content area:
instead of listing every tab that should scroll, default to
overflow-y-auto and only opt out the JSON editor tabs (which render
a self-scrolling full-height textarea) and note-tagging (which
manages its own scroll region). New tabs are no longer clipped by
the fixed-height dialog unless explicitly opted out.
---
 apps/x/apps/renderer/src/components/settings-dialog.tsx | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/apps/x/apps/renderer/src/components/settings-dialog.tsx b/apps/x/apps/renderer/src/components/settings-dialog.tsx
index 3bd29929..db65997c 100644
--- a/apps/x/apps/renderer/src/components/settings-dialog.tsx
+++ b/apps/x/apps/renderer/src/components/settings-dialog.tsx
@@ -2802,7 +2802,10 @@ export function SettingsDialog({ children, defaultTab = "account", open: control
             </div>
 
             {/* Content */}
-            <div className={cn("flex-1 px-6 pb-5 min-h-0", (activeTab === "models" || activeTab === "connections" || activeTab === "mobile" || activeTab === "account" || activeTab === "code-mode" || activeTab === "notifications" || activeTab === "advanced") ? "overflow-y-auto" : activeTab === "note-tagging" ? "overflow-hidden flex flex-col" : "overflow-hidden")}>
+            {/* JSON tabs render a full-height textarea (it scrolls itself);
+                note-tagging manages its own scroll region; everything else
+                scrolls here so tall tabs aren't clipped by the fixed dialog. */}
+            <div className={cn("flex-1 px-6 pb-5 min-h-0", isJsonTab ? "overflow-hidden" : activeTab === "note-tagging" ? "overflow-hidden flex flex-col" : "overflow-y-auto")}>
               {activeTab === "account" ? (
                 <AccountSettings dialogOpen={open} />
               ) : activeTab === "connections" ? (