apunkt/rowboat
1
0
Fork 0
mirror of https://github.com/rowboatlabs/rowboat.git synced 2026-05-11 00:02:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

docs: note srcdoc relative-asset limitation in html viewer

Browse source
This commit is contained in:
Gagancreates 2026-05-08 16:46:22 +05:30
parent 385ed3377f
commit 89f56a8059
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
apps/x/apps/renderer/src/components/html-file-viewer.tsx
View file

@ -124,6 +124,14 @@ export function HtmlFileViewer({ path }: HtmlFileViewerProps) {
) )
} }
// We use `srcDoc` here (not `src=app://workspace/<path>`) so the iframe
// gets a null origin with no base URL. Trade-off: relative assets inside
// the file — `<link href="./style.css">`, `<img src="./pic.png">`,
// `<script src="./foo.js">` — will silently 404. Self-contained HTML
// works fine; HTML that ships next to sibling assets will look broken.
// TODO: switch to `src=app://workspace/<path>` if we want relative-asset
// support; that path also resolves through the existing path-traversal
// guard in resolveWorkspacePath.
return ( return (
<div className="relative h-full w-full"> <div className="relative h-full w-full">
{state.kind === 'loaded' && ( {state.kind === 'loaded' && (