apunkt/rowboat
1
0
Fork 0
mirror of https://github.com/rowboatlabs/rowboat.git synced 2026-07-15 21:11:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test(core): fix type errors in the elision test suite

Browse source 
The resolver helper's inline policy type predated middlePaneContent and
no longer satisfied ElisionPolicy; use the exported type. Coerce message
content to string where the preview assertions call string methods.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Ramnique Singh 2026-07-07 21:02:03 +05:30
parent 30570a9325
commit 7000f34c48
1 changed files with 7 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

18
apps/x/packages/core/src/turns/context-elision.test.ts
View file

@ -12,6 +12,7 @@ import {
elideHistoricMiddlePaneContent, elideHistoricMiddlePaneContent,
elideHistoricToolResults, elideHistoricToolResults,
loadElisionPolicy, loadElisionPolicy,
type ElisionPolicy,
} from "./context-elision.js"; } from "./context-elision.js";
import { TurnRepoContextResolver } from "./context-resolver.js"; import { TurnRepoContextResolver } from "./context-resolver.js";
import { InMemoryTurnRepo } from "./in-memory-turn-repo.js"; import { InMemoryTurnRepo } from "./in-memory-turn-repo.js";
@ -189,12 +190,14 @@ describe("elideHistoricToolResults", () => {
const content = `SKILL GUIDE${"y".repeat(5000)}`; const content = `SKILL GUIDE${"y".repeat(5000)}`;
const [elided] = elideHistoricToolResults([toolMsg(content)], 2500); const [elided] = elideHistoricToolResults([toolMsg(content)], 2500);
// Starts with the first 400 chars verbatim, then the marker. // Starts with the first 400 chars verbatim, then the marker.
expect(elided.content.startsWith(content.slice(0, 400))).toBe(true); expect(String(elided.content).startsWith(content.slice(0, 400))).toBe(true);
expect(elided.content).toContain("Rest of tool result elided"); expect(elided.content).toContain("Rest of tool result elided");
expect(elided.content.length).toBeLessThan(700); expect(String(elided.content).length).toBeLessThan(700);
// Preview never exceeds a tiny threshold. // Preview never exceeds a tiny threshold.
const [tiny] = elideHistoricToolResults([toolMsg(content)], 50); const [tiny] = elideHistoricToolResults([toolMsg(content)], 50);
expect(tiny.content.startsWith(`${content.slice(0, 50)}\n[Rest`)).toBe(true); expect(String(tiny.content).startsWith(`${content.slice(0, 50)}\n[Rest`)).toBe(
true,
);
}); });
it("keeps tool results at or below the threshold verbatim", () => { it("keeps tool results at or below the threshold verbatim", () => {
@ -340,14 +343,7 @@ describe("createContextResolver", () => {
}); });
describe("ElidingContextResolver", () => { describe("ElidingContextResolver", () => {
function resolver( function resolver(repo: InMemoryTurnRepo, policy: ElisionPolicy) {
repo: InMemoryTurnRepo,
policy: {
toolResults: boolean;
toolResultThresholdChars: number;
images: boolean;
},
) {
return new ElidingContextResolver({ return new ElidingContextResolver({
inner: new TurnRepoContextResolver({ turnRepo: repo }), inner: new TurnRepoContextResolver({ turnRepo: repo }),
loadPolicy: () => policy, loadPolicy: () => policy,