apunkt/plano
1
0
Fork 0
mirror of https://github.com/katanemo/plano.git synced 2026-06-17 15:25:17 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor: simplify trace listener initialization and remove debug mode handling

Browse source
This commit is contained in:
Musa 2026-02-13 16:38:54 -08:00
parent 8396a86279
commit 9435509109
2 changed files with 50 additions and 121 deletions
Download patch file Download diff file Expand all files Collapse all files

31
cli/test/test_trace_cmd.py
View file

@ -67,40 +67,38 @@ def failure_traces() -> list[dict]:
return copy.deepcopy(_load_failure_traces())
def test_trace_listen_starts_listener_with_debug_and_custom_bind_after_target(
def test_trace_listen_starts_listener_with_custom_bind_after_target(
runner, monkeypatch
):
seen = {}
def fake_start(host: str, port: int, debug: bool) -> None:
def fake_start(host: str, port: int) -> None:
seen["host"] = host
seen["port"] = port
seen["debug"] = debug
monkeypatch.setattr(trace_cmd, "_start_trace_listener", fake_start)
result = runner.invoke(
trace, ["listen", "--host", "127.0.0.1", "--port", "9876", "--debug"]
)
result = runner.invoke(trace, ["listen", "--host", "127.0.0.1", "--port", "9876"])
assert result.exit_code == 0, result.output
assert seen == {"host": "127.0.0.1", "port": 9876, "debug": True}
assert seen == {"host": "127.0.0.1", "port": 9876}
def test_trace_listen_starts_listener_with_debug_before_target(runner, monkeypatch):
def test_trace_listen_starts_listener_with_custom_bind_before_target(
runner, monkeypatch
):
seen = {}
def fake_start(host: str, port: int, debug: bool) -> None:
def fake_start(host: str, port: int) -> None:
seen["host"] = host
seen["port"] = port
seen["debug"] = debug
monkeypatch.setattr(trace_cmd, "_start_trace_listener", fake_start)
result = runner.invoke(trace, ["--debug", "listen"])
result = runner.invoke(trace, ["--host", "127.0.0.1", "--port", "9876", "listen"])
assert result.exit_code == 0, result.output
assert seen == {"host": "0.0.0.0", "port": 4317, "debug": True}
assert seen == {"host": "127.0.0.1", "port": 9876}
def test_trace_down_prints_success_when_listener_stopped(runner, monkeypatch):
@ -121,13 +119,6 @@ def test_trace_down_prints_no_listener_when_not_running(runner, monkeypatch):
assert "No background trace listener running" in result.output
def test_trace_debug_requires_listen_target(runner):
result = runner.invoke(trace, ["--debug", "any"])
assert result.exit_code != 0
assert "--debug is only valid with target 'listen'." in _plain_output(result.output)
def test_trace_host_port_requires_listen_target(runner):
result = runner.invoke(trace, ["--host", "127.0.0.1", "any"])
@ -159,7 +150,7 @@ def test_trace_default_target_uses_last_and_builds_first_trace(
def test_trace_list_any_prints_short_trace_ids(runner, monkeypatch, traces):
monkeypatch.setattr(trace_cmd, "_fetch_traces_raw", lambda: copy.deepcopy(traces))
result = runner.invoke(trace, ["--list", "any"])
result = runner.invoke(trace, ["--list", "--no-interactive", "any"])
assert result.exit_code == 0, result.output
assert "Trace IDs:" in result.output