From 676617b41b77540525eb4c9f1bed7368a0bb568c Mon Sep 17 00:00:00 2001
From: Adil Hafeez <adil@katanemo.com>
Date: Mon, 28 Oct 2024 21:16:53 -0700
Subject: [PATCH] fix comments

---
 chatbot_ui/app/run.py | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/chatbot_ui/app/run.py b/chatbot_ui/app/run.py
index ead9b0a8..2c1ca620 100644
--- a/chatbot_ui/app/run.py
+++ b/chatbot_ui/app/run.py
@@ -87,7 +87,7 @@ def get_prompt_targets():
         return None
 
 
-def chat(query: Optional[str], messages: Optional[List[Tuple[str, str]]], state):
+def chat(query: Optional[str], conversation: Optional[List[Tuple[str, str]]], state):
     if "history" not in state:
         state["history"] = []
 
@@ -119,7 +119,7 @@ def chat(query: Optional[str], messages: Optional[List[Tuple[str, str]]], state)
     if STREAM_RESPONSE:
         response = raw_response.parse()
         history.append({"role": "assistant", "content": "", "model": ""})
-        messages.append((query, ""))
+        conversation.append((query, ""))
         # for gradio UI we don't want to show raw tool calls and messages from developer application
         # so we're filtering those out
         history_view = [h for h in history if h["role"] != "tool" and "content" in h]
@@ -128,10 +128,9 @@ def chat(query: Optional[str], messages: Optional[List[Tuple[str, str]]], state)
             print("chunk: " + str(chunk.to_dict()))
             if len(chunk.choices) > 0:
                 if chunk.choices[0].delta.role:
-                    print("role (hist): " + chunk.choices[0].delta.role)
-                    print("role (resp): " + chunk.choices[0].delta.role)
+                    # create new history item if role changes
+                    # this is likely due to arch tool call and api response
                     if history[-1]["role"] != chunk.choices[0].delta.role:
-                        print("creating new history item: " + str(chunk.choices[0]))
                         history.append(
                             {
                                 "role": chunk.choices[0].delta.role,
@@ -152,12 +151,12 @@ def chat(query: Optional[str], messages: Optional[List[Tuple[str, str]]], state)
                     history[-1]["tool_calls"] = chunk.choices[0].delta.tool_calls
 
                 if history[-1]["role"] != "tool":
-                    if chunk.model and chunk.choices[0].delta.content:
-                        messages[-1] = (
-                            messages[-1][0],
-                            messages[-1][1] + chunk.choices[0].delta.content,
+                    if chunk.model and chunk.choices[0].delta.content != "":
+                        conversation[-1] = (
+                            conversation[-1][0],
+                            conversation[-1][1] + chunk.choices[0].delta.content,
                         )
-                yield "", messages, state
+                yield "", conversation, state
     else:
         log.error(f"raw_response: {raw_response.text}")
         response = raw_response.parse()
@@ -181,12 +180,12 @@ def chat(query: Optional[str], messages: Optional[List[Tuple[str, str]]], state)
         # so we're filtering those out
         history_view = [h for h in history if h["role"] != "tool" and "content" in h]
 
-        messages = [
+        conversation = [
             (history_view[i]["content"], history_view[i + 1]["content"])
             for i in range(0, len(history_view) - 1, 2)
         ]
 
-        yield "", messages, state
+        yield "", conversation, state
 
 
 def main():