From 56f97dea9b2a15ecc6408a469547792eabbb8f42 Mon Sep 17 00:00:00 2001 From: Salman Paracha Date: Tue, 28 Oct 2025 17:30:28 -0700 Subject: [PATCH] fixed tests for config generator --- arch/tools/test/test_config_generator.py | 19 +++++++++++-------- .../arch_config_with_aliases.yaml | 4 ---- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/arch/tools/test/test_config_generator.py b/arch/tools/test/test_config_generator.py index 0d8f69b9..7016a34f 100644 --- a/arch/tools/test/test_config_generator.py +++ b/arch/tools/test/test_config_generator.py @@ -243,14 +243,13 @@ listeners: timeout: 30s llm_providers: - - model: custom/gpt-4o """, }, { - "id": "base_url_no_prefix", - "expected_error": "Please provide base_url without path", + "id": "base_url_with_path_prefix", + "expected_error": None, "arch_config": """ version: v0.1.0 @@ -264,7 +263,7 @@ listeners: llm_providers: - model: custom/gpt-4o - base_url: "http://custom.com/test" + base_url: "http://custom.com/api/v2" provider_interface: openai """, @@ -322,8 +321,7 @@ def test_validate_and_render_schema_tests(monkeypatch, arch_config_test_case): monkeypatch.setenv("TEMPLATE_ROOT", "../") arch_config = arch_config_test_case["arch_config"] - expected_error = arch_config_test_case["expected_error"] - test_id = arch_config_test_case["id"] + expected_error = arch_config_test_case.get("expected_error") arch_config_schema = "" with open("../arch_config_schema.yaml", "r") as file: @@ -346,9 +344,14 @@ def test_validate_and_render_schema_tests(monkeypatch, arch_config_test_case): ] with mock.patch("builtins.open", m_open): with mock.patch("config_generator.Environment"): - with pytest.raises(Exception) as excinfo: + if expected_error: + # Test expects an error + with pytest.raises(Exception) as excinfo: + validate_and_render_schema() + assert expected_error in str(excinfo.value) + else: + # Test expects success - no exception should be raised validate_and_render_schema() - assert expected_error in str(excinfo.value) def test_convert_legacy_llm_providers(): diff --git a/demos/use_cases/model_alias_routing/arch_config_with_aliases.yaml b/demos/use_cases/model_alias_routing/arch_config_with_aliases.yaml index 847faabe..b9dcab81 100644 --- a/demos/use_cases/model_alias_routing/arch_config_with_aliases.yaml +++ b/demos/use_cases/model_alias_routing/arch_config_with_aliases.yaml @@ -43,10 +43,6 @@ llm_providers: access_key: $AWS_BEARER_TOKEN_BEDROCK base_url: https://bedrock-runtime.us-west-2.amazonaws.com - - model: zhipu/glm-4.6 - access_key: $ZHIPU_API_KEY - base_url: https://api.z.ai/api/coding/paas/v4 - # Ollama Models - model: ollama/llama3.1 base_url: http://host.docker.internal:11434