adding PR suggestions for transformations and code quality

This commit is contained in:
Musa 2026-03-09 12:23:14 -07:00
parent 6b37c5a133
commit 546ad1b8e1
No known key found for this signature in database
10 changed files with 219 additions and 255 deletions

View file

@ -159,18 +159,18 @@ def _resolve_cli_agent_endpoint(plano_config_yaml: dict) -> tuple[str, int]:
if isinstance(listeners, dict):
egress_config = listeners.get("egress_traffic", {})
host = egress_config.get("host") or egress_config.get("address") or "127.0.0.1"
host = egress_config.get("host") or egress_config.get("address") or "0.0.0.0"
port = egress_config.get("port", 12000)
return host, port
if isinstance(listeners, list):
for listener in listeners:
if listener.get("type") in ["model", "model_listener"]:
host = listener.get("host") or listener.get("address") or "127.0.0.1"
host = listener.get("host") or listener.get("address") or "0.0.0.0"
port = listener.get("port", 12000)
return host, port
return "127.0.0.1", 12000
return "0.0.0.0", 12000
def _apply_non_interactive_env(env: dict, additional_settings: dict) -> None:

View file

@ -1,42 +0,0 @@
from unittest import mock
from planoai.core import start_cli_agent
PLANO_CONFIG = """
version: v0.3.0
listeners:
egress_traffic:
host: 127.0.0.1
port: 12000
"""
def test_start_cli_agent_codex_defaults():
with mock.patch("builtins.open", mock.mock_open(read_data=PLANO_CONFIG)):
with mock.patch("subprocess.run") as mock_run:
start_cli_agent("fake_plano_config.yaml", "codex", "{}")
mock_run.assert_called_once()
args, kwargs = mock_run.call_args
assert args[0] == ["codex", "--model", "gpt-5.3-codex"]
assert kwargs["check"] is True
assert kwargs["env"]["OPENAI_BASE_URL"] == "http://127.0.0.1:12000/v1"
assert kwargs["env"]["OPENAI_API_KEY"] == "test"
def test_start_cli_agent_claude_keeps_existing_flow():
with mock.patch("builtins.open", mock.mock_open(read_data=PLANO_CONFIG)):
with mock.patch("subprocess.run") as mock_run:
start_cli_agent(
"fake_plano_config.yaml",
"claude",
'{"NON_INTERACTIVE_MODE": true}',
)
mock_run.assert_called_once()
args, kwargs = mock_run.call_args
assert args[0] == ["claude"]
assert kwargs["check"] is True
assert kwargs["env"]["ANTHROPIC_BASE_URL"] == "http://127.0.0.1:12000"
assert kwargs["env"]["ANTHROPIC_AUTH_TOKEN"] == "test"