fix tracing flags

cli/planoai/config_generator.py

@@ -6,6 +6,7 @@ import yaml
 from jsonschema import validate
 from urllib.parse import urlparse
 from copy import deepcopy
+from planoai.consts import DEFAULT_OTEL_TRACING_GRPC_ENDPOINT
 
 
 SUPPORTED_PROVIDERS_WITH_BASE_URL = [
@@ -158,6 +159,29 @@ def validate_and_render_schema():
 
     arch_tracing = config_yaml.get("tracing", {})
 
+    opentracing_grpc_endpoint = arch_tracing.get(
+        "opentracing_grpc_endpoint", DEFAULT_OTEL_TRACING_GRPC_ENDPOINT
+    )
+    arch_tracing["opentracing_grpc_endpoint"] = opentracing_grpc_endpoint
+    # resolve env vars in opentracing_grpc_endpoint if present
+    if opentracing_grpc_endpoint and "$" in opentracing_grpc_endpoint:
+        opentracing_grpc_endpoint = os.path.expandvars(opentracing_grpc_endpoint)
+        print(
+            f"Resolved opentracing_grpc_endpoint to {opentracing_grpc_endpoint} after expanding environment variables"
+        )
+        arch_tracing["opentracing_grpc_endpoint"] = opentracing_grpc_endpoint
+    # ensure that opentracing_grpc_endpoint is a valid URL if present and start with http and must not have any path
+    if opentracing_grpc_endpoint:
+        urlparse_result = urlparse(opentracing_grpc_endpoint)
+        if urlparse_result.scheme != "http":
+            raise Exception(
+                f"Invalid opentracing_grpc_endpoint {opentracing_grpc_endpoint}, scheme must be http"
+            )
+        if urlparse_result.path and urlparse_result.path != "/":
+            raise Exception(
+                f"Invalid opentracing_grpc_endpoint {opentracing_grpc_endpoint}, path must be empty"
+            )
+
     llms_with_endpoint = []
     llms_with_endpoint_cluster_names = set()
     updated_model_providers = []

cli/planoai/consts.py

@@ -3,3 +3,4 @@ import os
 SERVICE_NAME_ARCHGW = "plano"
 PLANO_DOCKER_NAME = "plano"
 PLANO_DOCKER_IMAGE = os.getenv("PLANO_DOCKER_IMAGE", "katanemo/plano:0.4.4")
+DEFAULT_OTEL_TRACING_GRPC_ENDPOINT = "http://host.docker.internal:4317"

cli/planoai/docker_cli.py

@@ -116,11 +116,18 @@ def stream_gateway_logs(follow, service="plano"):
 
 
 def docker_validate_plano_schema(arch_config_file):
+    import os
+
+    env = os.environ.copy()
+    env.pop("PATH", None)
+    env_args = [item for key, value in env.items() for item in ["-e", f"{key}={value}"]]
+
     result = subprocess.run(
         [
             "docker",
             "run",
             "--rm",
+            *env_args,
             "-v",
             f"{arch_config_file}:/app/arch_config.yaml:ro",
             "--entrypoint",

cli/planoai/main.py

@@ -26,6 +26,7 @@ from planoai.core import (
     start_cli_agent,
 )
 from planoai.consts import (
+    DEFAULT_OTEL_TRACING_GRPC_ENDPOINT,
     PLANO_DOCKER_IMAGE,
     PLANO_DOCKER_NAME,
     SERVICE_NAME_ARCHGW,
@@ -153,7 +154,7 @@ def up(file, path, foreground):
 
     # Set the ARCH_CONFIG_FILE environment variable
     env_stage = {
-        "OTEL_TRACING_GRPC_ENDPOINT": "http://host.docker.internal:4317",
+        "OTEL_TRACING_GRPC_ENDPOINT": DEFAULT_OTEL_TRACING_GRPC_ENDPOINT,
     }
     env = os.environ.copy()
     # Remove PATH variable if present