fixed PR comments

This commit is contained in:
Salman Paracha 2026-01-07 11:10:23 -08:00
parent 654225a524
commit 2ec4e3517a
2 changed files with 2 additions and 2 deletions

View file

@ -295,7 +295,7 @@ pub async fn llm_chat(
operation_component::LLM, operation_component::LLM,
llm_span, llm_span,
request_start_time, request_start_time,
(!messages_for_signals.is_empty()).then_some(messages_for_signals), Some(messages_for_signals),
); );
// === v1/responses state management: Wrap with ResponsesStateProcessor === // === v1/responses state management: Wrap with ResponsesStateProcessor ===

View file

@ -141,7 +141,7 @@ impl StreamProcessor for ObservableStreamProcessor {
// Analyze signals if messages are available and add to span attributes // Analyze signals if messages are available and add to span attributes
if let Some(ref messages) = self.messages { if let Some(ref messages) = self.messages {
let analyzer = TextBasedSignalAnalyzer::new(); let analyzer: Box<dyn SignalAnalyzer> = Box::new(TextBasedSignalAnalyzer::new());
let report = analyzer.analyze(messages); let report = analyzer.analyze(messages);
// Add overall quality // Add overall quality