From 2656af89bfdb5dd0ee0b5fa85fb03200f40a31c0 Mon Sep 17 00:00:00 2001 From: Tom Stoffer Date: Mon, 25 May 2026 21:28:06 +1200 Subject: [PATCH] fix(request_adapter): ensure normalization of ChatGPT responses request --- crates/hermesllm/src/providers/request.rs | 6 ++++-- crates/hermesllm/src/providers/request_adapter.rs | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/crates/hermesllm/src/providers/request.rs b/crates/hermesllm/src/providers/request.rs index f652972f..c4cfd283 100644 --- a/crates/hermesllm/src/providers/request.rs +++ b/crates/hermesllm/src/providers/request.rs @@ -1025,7 +1025,7 @@ mod tests { input: InputParam::Text("Hello, Codex!".to_string()), temperature: None, max_output_tokens: Some(8192), - stream: Some(false), + stream: None, metadata: None, tools: None, tool_choice: None, @@ -1051,7 +1051,9 @@ mod tests { let upstream_api = SupportedUpstreamAPIs::OpenAIResponsesAPI(Responses); let mut request = ProviderRequestType::ResponsesAPIRequest(responses_req); - request.normalize_for_upstream(ProviderId::ChatGPT, &upstream_api); + request + .normalize_for_upstream(ProviderId::ChatGPT, &upstream_api) + .expect("ChatGPT responses request should normalize"); match request { ProviderRequestType::ResponsesAPIRequest(req) => { diff --git a/crates/hermesllm/src/providers/request_adapter.rs b/crates/hermesllm/src/providers/request_adapter.rs index 0e610e71..97cfb6a5 100644 --- a/crates/hermesllm/src/providers/request_adapter.rs +++ b/crates/hermesllm/src/providers/request_adapter.rs @@ -613,7 +613,9 @@ mod tests { let mut request = ProviderRequestType::ResponsesAPIRequest(req); // normalize_for_upstream sets store=false, stream=true, wraps input in Items - request.normalize_for_upstream(ProviderId::ChatGPT, &upstream_api); + request + .normalize_for_upstream(ProviderId::ChatGPT, &upstream_api) + .expect("ChatGPT responses request should normalize"); // serialize_for_upstream then renames max_output_tokens and flattens content let bytes = serialize_for_upstream(&request, ProviderId::ChatGPT).unwrap();