mirror of
https://github.com/ModernRelay/omnigraph.git
synced 2026-07-03 02:51:04 +02:00
b5c0c6238b
iss-merge-rowid-overlap-corrupts-filtered-reads / lance#7444: an
update-style merge_insert over a merge-written fragment legally reuses the
updated rows' stable row ids (row-id-lineage spec: updates preserve
_rowid) while the superseded fragment keeps its full sequence plus a
deletion vector. A later delete leaves the overlapping id range sparsely
tiled, and lance-table 7.0.0's RowIdIndex::new asserted dense tiling —
failing every filtered read that builds the id→address map ("Wrong range"
debug assert; "all columns in a record batch must have the same length"
or a silently-wrong batch in release).
The upstream fix (lance#7480, merged 2026-07-01) landed hours AFTER
v8.0.0 was cut, so no release ≤ 8.0.0 carries it. Consume it now as a
vendored pin: vendor/lance-table is the pristine published 7.0.0 source
plus ONLY the #7480 rowids/index.rs hunk (drop the false tiling assert;
hard-error on the true invariant — one live id claimed by two fragments)
and upstream's regression unit test, wired via [patch.crates-io]. The fix
is read-side only, so already-written graphs become readable as-is — no
data repair.
Removal condition (see vendor/lance-table/README.omnigraph.md): drop the
vendor dir + patch entry at the first Lance bump whose lance-table ships
lance#7480 (9.0.0, or a backported 8.0.1). The surface guard
filtered_scan_tolerates_merge_update_row_id_overlap keeps that honest in
both directions.
Turns the previous commit's red tests green. Full workspace gate passes
(cargo test --workspace --locked --no-fail-fast, 68 suites).
29 lines
800 B
Rust
29 lines
800 B
Rust
// SPDX-License-Identifier: Apache-2.0
|
|
// SPDX-FileCopyrightText: Copyright The Lance Authors
|
|
|
|
use std::io::Result;
|
|
|
|
fn main() -> Result<()> {
|
|
println!("cargo:rerun-if-changed=protos");
|
|
|
|
#[cfg(feature = "protoc")]
|
|
// Use vendored protobuf compiler if requested.
|
|
unsafe {
|
|
std::env::set_var("PROTOC", protobuf_src::protoc());
|
|
}
|
|
|
|
let mut prost_build = prost_build::Config::new();
|
|
prost_build.extern_path(".lance.file", "::lance_file::format::pb");
|
|
prost_build.protoc_arg("--experimental_allow_proto3_optional");
|
|
prost_build.enable_type_names();
|
|
prost_build.compile_protos(
|
|
&[
|
|
"./protos/table.proto",
|
|
"./protos/transaction.proto",
|
|
"./protos/rowids.proto",
|
|
],
|
|
&["./protos"],
|
|
)?;
|
|
|
|
Ok(())
|
|
}
|