omnigraph/crates/omnigraph-cli/src
aaltshuler 8d2128438e fix(cli): quote @embed annotation values in schema show so they round-trip
`render_annotations` emitted `@embed` values unquoted — `@embed(title,
model=openai/text-embedding-3-large)`. The parser stores values via
`decode_string_literal` (quotes stripped) and `annotation_kwarg` requires a
quoted `literal`, so the rendered output did not re-parse: a `model` containing
`/` or `-` is not a valid bare token. `schema show` therefore produced schema
text that `schema apply`/lint would reject.

Re-quote the positional value and every kwarg value as string literals, so
`schema show` reproduces `@embed("title", model="openai/text-embedding-3-large")`
and round-trips. Regression: `render_annotations_quotes_values_so_embed_round_trips`
parses the rendered form back through the schema grammar.

Addresses the bot-review finding on #248.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-16 01:25:27 +03:00
..
cli.rs feat(cli)!: remove legacy data-plane addressing (--target, positional http→remote, --as-on-served) (#238) 2026-06-15 04:29:16 +03:00
client.rs feat(cli)!: remove legacy data-plane addressing (--target, positional http→remote, --as-on-served) (#238) 2026-06-15 04:29:16 +03:00
embed.rs fix(embedding): address PR review feedback (RFC-012 Phase 2) 2026-06-15 18:37:34 +02:00
helpers.rs feat(cli)!: remove legacy data-plane addressing (--target, positional http→remote, --as-on-served) (#238) 2026-06-15 04:29:16 +03:00
main.rs feat(cli)!: remove legacy data-plane addressing (--target, positional http→remote, --as-on-served) (#238) 2026-06-15 04:29:16 +03:00
main_tests.rs feat(cli)!: remove legacy data-plane addressing (--target, positional http→remote, --as-on-served) (#238) 2026-06-15 04:29:16 +03:00
migrate.rs feat(cli)!: remove legacy data-plane addressing (--target, positional http→remote, --as-on-served) (#238) 2026-06-15 04:29:16 +03:00
operator.rs feat(cli): RFC-011 Slice A — additive scope/profile addressing (#235) 2026-06-15 02:37:55 +03:00
output.rs fix(cli): quote @embed annotation values in schema show so they round-trip 2026-06-16 01:25:27 +03:00
planes.rs feat(cli)!: remove legacy data-plane addressing (--target, positional http→remote, --as-on-served) (#238) 2026-06-15 04:29:16 +03:00
read_format.rs Initial public Omnigraph repository 2026-04-10 20:49:41 +03:00
scope.rs feat(cli)!: remove legacy data-plane addressing (--target, positional http→remote, --as-on-served) (#238) 2026-06-15 04:29:16 +03:00