mirror of
https://github.com/ModernRelay/omnigraph.git
synced 2026-06-15 01:55:13 +02:00
81b66f9427
The full workspace + failpoints suite was the slowest PR gate (~15min warm, up to the 75min cold ceiling) and dominated PR turnaround. Gate the `test` job with `if: github.event_name != 'pull_request'` so it runs only on push to `main` (post-merge), on `v*` tags, and on manual `workflow_dispatch`. `RustFS S3 Integration` needs `test`, so it becomes push-/dispatch-only by the same cascade. Drop `Test Workspace` from the required-check list in branch-protection.json: a required context that never reports on PRs (the job no longer runs there) would leave every PR permanently pending — the job-never-reports trap the policy already documents. Trade-off accepted deliberately (chosen by the maintainer): a regression the suite would catch now lands on `main` and reddens the post-merge run instead of being blocked pre-merge, so `main` can briefly break. Mitigations documented in ci.md: run `cargo test --workspace --locked` locally before merging non-trivial changes (or trigger the workflow on your branch via workflow_dispatch), and regenerate openapi.json locally for server/API changes (the auto-regen step lived in the now-PR-skipped test job). The fast PR gates remain: Classify Changes, Check AGENTS.md Links, the AWS-feature build/test, and the two CODEOWNERS checks. NOTE: an admin must run ./scripts/apply-branch-protection.sh after this merges, or GitHub keeps requiring the now-unreported Test Workspace context. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
34 lines
1.3 KiB
JSON
34 lines
1.3 KiB
JSON
{
|
|
"_comment": "Branch protection policy for main. Applied via scripts/apply-branch-protection.sh. See docs/branch-protection.md for rationale. NOTE: bypass_pull_request_allowances.users must mirror the engineering owners in .github/codeowners-roles.yml — code owners merge their own PRs without a second review; non-owners still need a code-owner approval. (render-codeowners.py does NOT generate this list; keep it in sync by hand.)",
|
|
"required_status_checks": {
|
|
"strict": true,
|
|
"contexts": [
|
|
"Classify Changes",
|
|
"Check AGENTS.md Links",
|
|
"Test omnigraph-server --features aws",
|
|
"CODEOWNERS matches source",
|
|
"CODEOWNERS not hand-edited"
|
|
]
|
|
},
|
|
"enforce_admins": false,
|
|
"required_pull_request_reviews": {
|
|
"dismissal_restrictions": {},
|
|
"dismiss_stale_reviews": true,
|
|
"require_code_owner_reviews": true,
|
|
"required_approving_review_count": 1,
|
|
"require_last_push_approval": false,
|
|
"bypass_pull_request_allowances": {
|
|
"users": ["ragnorc", "aaltshuler"],
|
|
"teams": [],
|
|
"apps": []
|
|
}
|
|
},
|
|
"restrictions": null,
|
|
"required_linear_history": true,
|
|
"allow_force_pushes": false,
|
|
"allow_deletions": false,
|
|
"block_creations": false,
|
|
"required_conversation_resolution": true,
|
|
"lock_branch": false,
|
|
"allow_fork_syncing": false
|
|
}
|